Received-SPF: pass (google.com: domain of linux-kernel+bounces-143259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <57c32cfd-136d-4c72-9f4d-12599b508fb8@intel.com>
Date: Fri, 12 Apr 2024 12:31:01 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] platform/x86/intel/ifs: Classify error scenarios
 correctly
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
	<ilpo.jarvinen@linux.intel.com>, <hdegoede@redhat.com>,
	<markgross@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <platform-driver-x86@vger.kernel.org>,
	<ashok.raj@intel.com>, <tony.luck@intel.com>, <rostedt@goodmis.org>,
	<ravi.v.shankar@intel.com>, <patches@lists.linux.dev>
References: <20240412172349.544064-1-jithu.joseph@intel.com>
 <20240412172349.544064-2-jithu.joseph@intel.com>
 <69d360fc-85e4-4a6d-8f08-9f90dd7ec583@linux.intel.com>
Content-Language: en-US
From: "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <69d360fc-85e4-4a6d-8f08-9f90dd7ec583@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZW51eENZSWRyYzcrMXBwUnUrOHFLRi92WDdsN0N0TmtQdzlHZ1N6bDVUZ3hE?=
 =?utf-8?B?dENxR2tuSmhYZFE1MTdOWmFLcUVDMU5IaTloNXpmb1lSNTExOVI3Q3ByZ3lP?=
 =?utf-8?B?eFJhQWdFNWtDb2NsM202RFdYWmd0VVBtRWQ4dTVUcFA4cTkrK2orRnVpZExp?=
 =?utf-8?B?bFNPNGw0UVAyOHNvQ0tZMVpZTnFpUmNRNjM3SXMzU2xhUU4zdFRZZ0REZ1A1?=
 =?utf-8?B?SFFwaTFiQ0pnYVppbWtUZU9CV3VrbENoZ1o0NDBvd09Oa3VpaGFCR1B6TTl3?=
 =?utf-8?B?M3k3OTh3NUFrZUVvUXBGTUhMRTRENVBQbitrZ2RYV2FaZ1dhRDFxTEJlUzRq?=
 =?utf-8?B?dDRkelEralRnSEJSMDhIVHY2TWg3aVpyMVdUQ2Y1MllDbkNzR2lOdWVXYk0v?=
 =?utf-8?B?NXllTGxKME1GYzI5R0g0SUk1Y0xqRTBEclpOYk5vR3hDVWxIbjkyWkFzd3o2?=
 =?utf-8?B?Y05XTzNEeWFwdWUyWUVOdytPTE1WSGpoZ1lFaS85VVpOSTdnNk1JbGdMbjhM?=
 =?utf-8?B?WFJ2b3JCeUhpTGZsV1dNbW9ZaWlVV3ZmaVR4cmpkZjEzWmlSb21id3ZGQ3Fh?=
 =?utf-8?B?QTBTWmEvRUxWR1o4VnlsdVNBSzlDK0NVZnBvak9ZYVNsSzNpWEgzWUIrOWgz?=
 =?utf-8?B?UURVTyt4cVA5ai9xWTUzeUNjRlRkdWxMb3BuTnFUK21DZjhONXptYUJlOVpw?=
 =?utf-8?B?REdHdG5FeTROYkhnNHBwTUJXVlEzWURlbDF5eEhMR1Vycng1T0luYk56RW4w?=
 =?utf-8?B?a1ljQVBTRFNKcVVVQ0hHL3ZDWjNlK3oxSkRmdjlsWFBPei80TVQyU2dWcSs1?=
 =?utf-8?B?WjJSOGNISXFHcU44Y2JBcDUzcU9TOE5xUkUyRnVTR243NmtKZXl4MmpVL3Vz?=
 =?utf-8?B?enNaNlJkSGpxRjg4b05ZNlRlaTFCUGlGeGNtY2o1TFcrSlZ3RG5CdVRDd2pt?=
 =?utf-8?B?UGs2cXMzSUI0YVlkb21PcUp4R0ZpSUxhV2NIUTZmWVIreHVGL2l1Y0xMV1Fz?=
 =?utf-8?B?STVJU1Y1TjF2RWtyWEdvV2hhalNKUDJtQTg3ak50djlvbHRNcFUvTUdieTB1?=
 =?utf-8?B?UGVTaytBWkpxRGJRbW40dHBod2NGMHduaWhkOFVLaDlKVmQzd3hYckEvN0kr?=
 =?utf-8?B?Rm0ySCt1TXRnb3lKa2F3OUd1NGRpMXJvZTl5bDZDdnB2QitkUVFzT3dRby9K?=
 =?utf-8?B?cTJYVzZONlZJa0Z4eng2VDErZVZraGRaN0tFYkt5UlV2VnVjRTBVUjdDSndV?=
 =?utf-8?B?Q0pIY2YvZFdzVVpEVUZqOFk1Y2VCQmw1c3E2WmxKWVhsM1M2dWVoYzdkMG1k?=
 =?utf-8?B?aWI4OTlBTDJxYUVyd0FMenEybURvRmFYaWxEeHp6UlpMQTZYMTlXc2pqa2Rk?=
 =?utf-8?B?YXZUWE5FSUsrMHFWN1M2ZmRyVEVrOGZDSGRFVDBGSSt5aTZkQ1htdCtBWmJQ?=
 =?utf-8?B?RjJVL2YyYlJSVE5PNzc5ZFdDczRpWUxTeHV1STdWRjBwdDVtM3k3Qkd5UGpG?=
 =?utf-8?B?enJLYzRNb1JVYmd3dFJkam5kZ3BxNGNFZ0RvdGU5dXE2eWMrRmNJWGNSWXVz?=
 =?utf-8?B?Ni9vaXNpYTl4UFNYUThZRlJnaXZyTkJhYmdheW9EaVh3aTRMZUVkTERDTklI?=
 =?utf-8?B?RlhGQVZOOWJPQkkvSWF6dnBTb3ZDUlFOZS9qeXNKclp0Z0krQWVTblVOL0FU?=
 =?utf-8?B?ajJOYkE5djd0aTVvdFJjdTNycStXa3hPZ1IyVE5teENvY0xDS0lPNXA0Q3Rj?=
 =?utf-8?B?Q3kveElyd1ppZXNhTUY3VE53bHp3bU50QTNwdW9kRTRqb1h3R0VMZEU1dWJ3?=
 =?utf-8?B?K2xUNkJiQ2xyYmJQL2N4WWR1QjhVdFZTcWl3UFhBbk0rOEd2MmVQUEU1aElI?=
 =?utf-8?B?TCtmSEhuc05sbEdrNkVOcFh0QWdHb0R0VkI1ZWV0YVZWN2RJZllxWk1ERlVG?=
 =?utf-8?B?YWdHYTZ1K0Q5OVpXR0xQSkg3bzdTdHVwbU1KRXJrZkpqMlJQUG9lTDlURnpy?=
 =?utf-8?B?d2lFVEF6TGNDZHRvazloTkxhbHFWblRraEFaQ0JwWWtIRWYyMS9qRmYya1g0?=
 =?utf-8?B?UkI0M2ZxTXIwTnI2M3ZUU3NhR095eTd5WlkyQVllUzR1MjRXa2NHTVI5WjZ5?=
 =?utf-8?B?blF2Zkdudlpyais0WmFiZU81UGl2SjlpK2FOTTd6RXNqTHd1U2xJbXI2Rm5m?=
 =?utf-8?B?NWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c418ec49-a00d-4cc6-2164-08dc5b27181e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 19:31:04.8033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ApB/IWHGac1IAKIJLmZfNw8Jg1Zj7RGCY3CJxUFxgBHRmf2QdYZ9UM7Ps/gqaIiIwqANustGnlStTkOXE7+jVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6862
X-OriginatorOrg: intel.com

Sathya,

Thanks for reviewing this

On 4/12/2024 11:32 AM, Kuppuswamy Sathyanarayanan wrote:
> 
> On 4/12/24 10:23 AM, Jithu Joseph wrote:
>> Based on inputs from hardware architects, only "scan signature failures"
>> should be treated as actual hardware/cpu failure.
> 
> Instead of just saying input from hardware architects, it would be better
> if you mention the rationale behind it.

I can reword the first para as below:

"Scan controller error" means that scan hardware encountered an error
prior to doing an actual test on the target CPU. It does not mean that
there is an actual cpu/core failure. "scan signature failure" indicates
that the test result on the target core did not match the expected value
and should be treated as a cpu failure.

Current driver classifies both these scenarios as failures. Modify ...

> 
>> Current driver, in addition, classifies "scan controller error" scenario
>> too as a hardware/cpu failure. Modify the driver to classify this situation
>> with a more appropriate "untested" status instead of "fail" status.
>>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> Reviewe
> 
> Code wise it looks good to me.
> 
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> 


Jithu