Received-SPF: pass (google.com: domain of linux-kernel+bounces-143267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 12 Apr 2024 16:38:55 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Ian Rogers <irogers@google.com>, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	Kajol Jain <kjain@linux.ibm.com>,
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/4] Add shellcheck beyond perf/tests
Message-ID: <ZhmNz00T1iAzuMiq@x1>
References: <20240409023216.2342032-1-irogers@google.com>
 <4949d61b-6b25-4433-bd2b-a50b4f22ff42@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4949d61b-6b25-4433-bd2b-a50b4f22ff42@arm.com>

On Tue, Apr 09, 2024 at 11:02:58AM +0100, James Clark wrote:
> 
> 
> On 09/04/2024 03:32, Ian Rogers wrote:
> > Add shellcheck to other locations of shell scripts, not just
> > tools/perf/tests. Fix issues detected by shellcheck.
> > 
> > Ian Rogers (4):
> >   perf build: Add shellcheck to tools/perf scripts
> >   perf arch x86: Add shellcheck to build
> >   perf util: Add shellcheck to generate-cmdlist.sh
> >   perf trace beauty: Add shellcheck to scripts
> > 
> >  tools/perf/Build                              | 14 +++++++++++
> >  tools/perf/arch/x86/Build                     | 14 +++++++++++
> >  tools/perf/arch/x86/tests/Build               | 14 +++++++++++
> >  tools/perf/arch/x86/tests/gen-insn-x86-dat.sh |  2 +-
> >  tools/perf/perf-archive.sh                    |  2 +-
> >  tools/perf/perf-completion.sh                 | 23 +++++++++++++------
> >  tools/perf/trace/beauty/Build                 | 14 +++++++++++
> >  tools/perf/trace/beauty/arch_errno_names.sh   |  8 ++++---
> >  tools/perf/util/Build                         | 14 +++++++++++
> >  9 files changed, 93 insertions(+), 12 deletions(-)
> > 
> 
> Reviewed-by: James Clark <james.clark@arm.com>

Thanks, applied to perf-tools-next.

- Arnaldo