Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp141909lqp; Fri, 12 Apr 2024 12:58:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW3DmGGVHDkeYwEllsXkK26K7GM9ErExgkFzEMdeYW91OHrV8YBiMc8+hZSbQlNB00CR8BduNvI+e2s7XvEd3BekB9Q5KuujIdvW4OTlQ== X-Google-Smtp-Source: AGHT+IE2P+ElrGmbkETYtA5MdQKRSSGVS6C0M0wDSye9FM/9d3fqmgxYJDgNt254WzZrSOgofZKE X-Received: by 2002:a05:622a:283:b0:431:82ce:92ca with SMTP id z3-20020a05622a028300b0043182ce92camr4883661qtw.42.1712951930018; Fri, 12 Apr 2024 12:58:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712951930; cv=pass; d=google.com; s=arc-20160816; b=ZIfmbnDOpKa6D1e0b9qaVLKV9g3JeVdFqA37ljcpFUaJ6oSu2OiKV5cG+mfblCCCN5 T2bYsHtd8C290FGMUq/rge/G/iI+7S9Xf5j0X8RGjD8wHkneVs3TaYLqREXZtADH9fwS 6h/QRodVl8s4DGKxQAGW17fAEW5QJ2DbKRGgmltWhQtxLFDkkdC00E0rPSap8nh4VWAX wUFNczet895vu3GsB0jhuoJcbAk/C3JJzuLIKAPAG9P4SjKHMxRqC4SmZN8hwgwt97Z8 xR3MuP1Nyn0ZBIMFBHWuMqrA5A3nhOsD2nwFXNRHw2Cj1htEBQ7lvnOy85l4sk/sv+R3 4Ufg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:subject:cc:to:from :date:dkim-signature; bh=9HYoa2q9zbdAwhkuDRDtehEu+C2d3K7WfVfQ1MwY5ts=; fh=xCF1Y+dlA9P7VH9wcKmlDGZUb4WVpwOL/1lWAZ7LFJ8=; b=JsWaXO68lnFZsCSKvVa0IF91ecbEXL1ZdpHB9ocZorSXvsOZMM7ZrRZfI77hUaOhfr qjOiEdIewxxVpBVY0PGYS/d4aw8U2P+xmd2SnQdtcXuV3XxRKq9ns+Q7Lzcxmlx4+FFb 0N1xPUYrPuUcx8VPcWpBN8OVuxuqCYu9ephtbwn4SvxENGKMvSpra7DrSDzfNTnggtSk rrxOTqBiU8w9jYDdihLTXQ2qAnBGBEJggW33CLCg2OL5bpqJZEKrzZCBzAJvRJU3LwFt XIWZP5OGlOLA9XIkNawjHuMOmg8LVhKBVCT4HN8cVWQ4L7Y+OxwNDSB0nDaJAE7IuPju 2UqQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SGLpNFOb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-143277-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143277-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id r17-20020a05622a035100b0043699f2ba5fsi1625427qtw.302.2024.04.12.12.58.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 12:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143277-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SGLpNFOb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-143277-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143277-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BB0451C23EA1 for ; Fri, 12 Apr 2024 19:58:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C9411514C4; Fri, 12 Apr 2024 19:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SGLpNFOb" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9585714EC4E; Fri, 12 Apr 2024 19:58:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712951918; cv=none; b=tUNWqS8kDPD2iSRPXX7ITzIOurlnUJO34qa7H8vSyQcbT4N/FvjH5Ou62Ss4tKQ+GTNoK0dmKZ79E2x2X/De1XROV1vYtQV7u5toFuKbOUPkST2T/i99+IxG8tuWDEO+s3QN3YFx4H2KvzSNGGRkgJgTzpag1USrikgS8yxMewM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712951918; c=relaxed/simple; bh=9HYoa2q9zbdAwhkuDRDtehEu+C2d3K7WfVfQ1MwY5ts=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=UsMt+tALfGQvR5WojI3kGQuCYNcAgf0jkY0t4zMgTu1sd92HQk1Mh1jQKPWWkdVXFIR7rYzpyds/KIVkKjm+4MwbDW9Fq5P7LKc6xqJTyooB8CefGvDLsDybDzoVCR4oi8twyh38lFfNcgAeboUPaKhVk4ZggKEcYlIxuMLxpG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SGLpNFOb; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECFEAC113CC; Fri, 12 Apr 2024 19:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712951918; bh=9HYoa2q9zbdAwhkuDRDtehEu+C2d3K7WfVfQ1MwY5ts=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=SGLpNFOblQMeIbaJAa2RR1y9xP1A4VwRPfNvrMemMrQdH7DFIEqXfWjED1/QhvtxO hJwupFe0Zppd9Hx7FQ6sAD9A8zlkGNqxCKL93Lgv+HM/Tlv2ihysEEhBSMme0WU/xZ RmyWk2LZ0EfMI6v7/A50srEd/rQl8GV6TNI7lhloC7ZsNkN79QdcezoDxDudu48TlU 6yeJb0nSJDsOMZYNoTJ//yRoBGLYAUywwOLqZRW1kYosaZ/FAmRG8UQ0qWOU9fuvNj MUvOqI6C3if4nm0zgjmb2nXTx/fQpWCIEwE1QW09jgPv9Q7AQOn6hkEUrmUqhOGaI4 DTF2TST3dsEgA== Date: Fri, 12 Apr 2024 14:58:36 -0500 From: Bjorn Helgaas To: Manivannan Sadhasivam Cc: Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , Shawn Lin , Heiko Stuebner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel , linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org, Frank Li Subject: Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240412195836.GA13344@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327-pci-dbi-rework-v12-2-082625472414@linaro.org> On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote: > All of the APIs are missing the Kernel-doc comments. Hence, add them. > + * dw_pcie_ep_reset_bar - Reset endpoint BAR Apparently this resets @bar for every function of the device, so it's not just a single BAR? > + * dw_pcie_ep_raise_intx_irq - Raise INTx IRQ to the host > + * @ep: DWC EP device > + * @func_no: Function number of the endpoint > + * > + * Return: 0 if success, errono otherwise. s/errono/errno/ (another instance below) Bjorn