Received-SPF: pass (google.com: domain of linux-kernel+bounces-143279-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240412053245.3328123-1-jfraker@google.com> <661953c285139_38e2532941f@willemb.c.googlers.com.notmuch>
In-Reply-To: <661953c285139_38e2532941f@willemb.c.googlers.com.notmuch>
From: John Fraker <jfraker@google.com>
Date: Fri, 12 Apr 2024 12:59:42 -0700
Message-ID: <CAGH0z2Hp_tXb1dBUDDbWn8J4VG4E9COBkYdWT3HB2NAHB4tXVA@mail.gmail.com>
Subject: Re: [PATCH net-next 12] gve: Correctly report software timestamping capabilities
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, Harshitha Ramamurthy <hramamurthy@google.com>, 
	Shailend Chand <shailend@google.com>, Willem de Bruijn <willemb@google.com>, 
	"David S. Miller" <davem@davemloft.net>, Jeroen de Borst <jeroendb@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Junfeng Guo <junfeng.guo@intel.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 12, 2024 at 8:31=E2=80=AFAM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>
> John Fraker wrote:
> > gve has supported software timestamp generation since its inception,
> > but has not advertised that support via ethtool. This patch correctly
> > advertises that support.
> >
> > Signed-off-by: John Fraker <jfraker@google.com>
> > Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>

Thank you

> > ---
> > v2: Used ethtool_op_get_ts_info instead of our own implementation, as
> >     suggested by Jakub
>
> FYI: the subject says "net-next 12", not "net-next v2"
>
Sorry about that!

I made two rookie mistakes haha. Sending the patch late at night, and
not re-doing my test email after editing.