Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp144373lqp; Fri, 12 Apr 2024 13:02:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW/+XXsS503Oc7d5Q4FuwSB0ZtsiD7PhKpCynhoJoy+QHrNI53+8gwWzCpQaCujKP4psx32EX9C97OoQ6Z5y6sNbV0h9RGrUNh5ZJX/6g== X-Google-Smtp-Source: AGHT+IGJJkLSmsjw9djWxUrmxBTS1aITKsMD+ZD0nioEycBIgpEaDFSJy9r47oyDkpy4hmNIM9tI X-Received: by 2002:a05:6830:1e6c:b0:6ea:2ef7:d749 with SMTP id m12-20020a0568301e6c00b006ea2ef7d749mr3432063otr.2.1712952177262; Fri, 12 Apr 2024 13:02:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712952177; cv=pass; d=google.com; s=arc-20160816; b=cMvWgJufBOGAiJPn7JKGTwCboiseV8DtyeQ4blC4Mnlb2uLrfhtFHlLCvH+XXlCPEy 7CiIxelcyO4ZOlMRYuszGL7kwaA1uyzYFcpV4zuXQNkI+m6g8VmhLV9DxA+Riu0uOqY0 058aBT9ba+OhBHh9YmghpAX6MpHDkLf9yBXY3FRbYvwBqwN4f+IstOMk/etHx/FtmgKJ QsbZyyn1z36P2NRvuWKfLNlyDlue1TzDhLhVRFlkQDNmX6fLFTD2Gsxm2Lurj31aANu0 h7STIOWLxCijX8mODfJEEnq332nJxp+6xDKHCi9qRTMnOE3ibxYPtX7kqy6TaBNty4l1 bWWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=fW4TbgGzIIRwzH2FntIEg5O7YLhVW+FYjD5M9RQsevE=; fh=+esTqoyaCd2K10uwZj8pKYPqx9AXbGBijcFCCPW++0Q=; b=FB6eXXmLm7oUajR5S+4OjbjTq7BrXH/G1b1mp17siyhwhQx2HXPzgtwcAq4OpH6FgK xpCV5/qMskyHY8d9K6SjDnwXARZeYy9NwvvtGyAz82XSp3BJ1lNU4qq2HP9GEjdUrA0j cG4DdP4vro8XBJzye1mLt8ivA+rNKjrAFNkUsN/6FKgVUwWzEuHXzULFCb9qkWYhSQgm giM5QM4fkR2lXZiZQRsy7dQNNda1cwF3pLauChkGsANT3qB+ZTXnxSPREf/WHnWMYCNe 2mGv5BpCVwQ2ipaEjDOfwrjvY9vNmdFsQnP0Ee+HQZgT0BD+7W3HRcOlm0wIWpId2zXc 8+YA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=qSSqkuGp; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-143282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143282-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ia2-20020a0561024b0200b0047b65a5ad09si153529vsb.78.2024.04.12.13.02.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 13:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=qSSqkuGp; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-143282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143282-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F02731C2167F for ; Fri, 12 Apr 2024 20:02:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9D3441509B8; Fri, 12 Apr 2024 20:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="qSSqkuGp"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="J+6c3ifU" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A4514F9C6; Fri, 12 Apr 2024 20:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712952170; cv=none; b=gVDEauOoCOcPaRioQZeYfqHxK407r46jEr0KuwIWTxgkwxnNEf458oXrPPEuV+1eSjf2lWZYbZQ+qtspkuF3QfVXCPKuWwzVPMQLAGnXBsBktzKZkOuXAtkqvO/pM7aD0+YpEt1BWqMcZyEI8wH/s5k7OcvBAm/C6no0T1pYpik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712952170; c=relaxed/simple; bh=op41Sqyr8uRfLj1kuBiDgqpP5F12Vli+Jni7UAzFnxA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ha8S7N8/zNu2BuEaKTuikHZcxdDKs66I2OU5X8gHTF7AFqZbo6IOc2dqgAqRMW/PBdrf+sxvW8UgLf1sQP1zLQauSaI4nTsWtBcMPhNtvHTxqPr2qcU/q+GFIOZDg65gPyXqk8g74iI003Fce8pwuail5Kkm6kkIQ23WO50Fgcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=qSSqkuGp; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=J+6c3ifU; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1712952168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fW4TbgGzIIRwzH2FntIEg5O7YLhVW+FYjD5M9RQsevE=; b=qSSqkuGpvy4oJWtuxviFmMf9uBQ/v5PZ6bY5p2IrCythD0yQYK3q1Sn+TSs+odu5E/W2us bD9kXSlaP+3DVtTOG3FSjQgNDEn14D6bLLmzkaJIUOQvw0SzLi0t/HIyB29FmwQAwkczvI c+vvoSz9sftPgkNTTqFWO7d8lo9y0fX0I/ypPJeBm7sVGxFf8Yimpp3upp4cDbvSc+4g6T Gjk5zANXyg1YZaJL+GAumuZgDErPh1E1qOvwcksmKgrA3yguvt0POmRfKGQ/7Bz0B1ONUz nhPLENsBzVPRzAOWWwHFQs3Eln0Ybt/+pmrWtEDL9V/xgpnvBEezNR5CoTdX+A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1712952168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fW4TbgGzIIRwzH2FntIEg5O7YLhVW+FYjD5M9RQsevE=; b=J+6c3ifUSjkLEaL9IfdBMfoARZZPCAjA+WXQtpVQsGMsAMO8UildIYSdAjxI7dAceD/H1Z tj2oTBkv2gu7vbDA== To: Pavel Machek , Greg Kroah-Hartman Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, broonie@kernel.org, maco@android.com, christophe.jaillet@wanadoo.fr, sean.anderson@linux.dev Subject: Re: [PATCH 4.19 000/175] 4.19.312-rc1 review In-Reply-To: References: <20240411095419.532012976@linuxfoundation.org> Date: Fri, 12 Apr 2024 22:02:47 +0200 Message-ID: <87edbaz6vs.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Apr 12 2024 at 21:46, Pavel Machek wrote: >> Thomas Gleixner >> timers: Move clearing of base::timer_running under base:: Lock > > AFAICT, we don't have those NULL assignments in expire_timers in > 4.19. Can someone doublecheck this? We also don't support PREEMPT_RT > there. This has nothing to do with RT. But yes, 4.19 has the original bass::running_timer clearing which happens at the end of handling all expired timer callbacks and that actually happens with base->lock held. So right, 4.19 is not affected by this. Thanks, tglx