Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp151991lqp; Fri, 12 Apr 2024 13:18:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUPTN+B9NGgO8sEvOmtDsMyQtEa5CDJ7uBQxxZJy05CXoTXCNx+d3/9MU3srGaio/tAloClpSi0230tnlLVyc9crdQm0rafmOSaZjGqqw== X-Google-Smtp-Source: AGHT+IEpDG/RT//i25snM3s/GSgFmvDWepXvr2PKZdps4TSALSvhXWLHp+faxh9O+VB9uz9s6Bu6 X-Received: by 2002:a17:906:6a09:b0:a52:42b:4d59 with SMTP id qw9-20020a1709066a0900b00a52042b4d59mr3942458ejc.26.1712953120645; Fri, 12 Apr 2024 13:18:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712953120; cv=pass; d=google.com; s=arc-20160816; b=UnGIAllxdxaoGL6TjY2jPeJbXFX0sYNY3kngJrtdoUVQufZsLaZ+wwJibyttEyk6TL YrGzscUJTrai4adpIhmXV6314CryCUfl3lmq6QVvevJVYDoSY4jDzvAV5s6kFh/jlgqj kmowclAWf1B4twijYu2XIKv+yGMlIwarsa7obazRUbzpWcPghNBUKj8tuMKtGhiQaG3X m7vAzIJewawFHbGo7ef0hvyy3+fAQ8DEAgjmcUzRPBU0I3E4xjiejfyKIPGGCdBnKb3d Iu3Rq0/YZN8CfAL0azpJm5T91SCw7VtSgrGDK1jpxjjWfEIkoBZEkk9CoI2SexeIiYAp E05Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:date:dkim-signature:message-id; bh=nLHlIUYkkULgzyqbRS6FF1LI5GIXKe6Pa6vjv4BQWm8=; fh=/VFqLo1+JS5vkXbLqbw7aMhaiE4qlpsNH/ennrwLKxQ=; b=ZLN+jzOoFtlBGrEzpcu8ARUau7pShYwcEoiPNfGeySTpIHDXY0/3fNGb1OGp9uBpuZ Q/WFrlr3caq0/uC7EJ4M4dYZ7Z61J+hheOY5P84mSY7RGZ5qCH/63vNrYbCZuDpCfpjS Fu17pKXejgC1OFVKN8Kl2ytNlsrTPCzAWDVLHSmYHiPni2XXsIXedjgN/Z34ZPvIR0y+ cYrG24R4Y9/GUAb/j/eeM7SIqitG7lazTAX5e1sDeI8JFAlCfu1hSvWA2T0SScCuNyWB 9awsJuPJBh7UqFEMzbqF1BXgj1AlRtUH+EPwJigLYS39qtgXuBuUWx7ByXG3ogjXnx2d r6uA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=p7jt+z9c; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-143298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id sh15-20020a1709076e8f00b00a4e7dfb0e74si2157822ejc.724.2024.04.12.13.18.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 13:18:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=p7jt+z9c; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-143298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5416E1F2200F for ; Fri, 12 Apr 2024 20:18:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 904611514C6; Fri, 12 Apr 2024 20:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p7jt+z9c" Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66582150990; Fri, 12 Apr 2024 20:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712953111; cv=none; b=BE3grueGpCVy+RxOtZDufurX+iN+3mJkkwLkB/SEtyTdb6NLMU49aVAUgdDD58sYKXyJ/Gv1xtsuJ1vzxTAbhQ6EVwDZBo47/QAjcUPPtLmEPlOveGa90qw+0RLIz93P5eisIG+yne9smNwVeYya54+0fMsSUtlFTTUV5GU9Okw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712953111; c=relaxed/simple; bh=+8yd8nRZnsK4xoNUZ2lOwNHS5meRrf+aFzhiGaoSBD0=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=HHpl93OB7FAFjPom8D/hDUnG6+4Daz0JP5VnTX0uwvLobqJIkpTZEO+OfknB9yoBCMdcFcVeCE0UGD7V4otN9Ll9ndxAsv0uDfwIVK4zNdp3TEuqOSoLgiL2/aQZngQC1k97x04qVe4tt9b2SjW8bYrTUpiTB6zxCq/65MhWpNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p7jt+z9c; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Message-ID: <7040a36b-b74a-41df-bd84-093b0e97a6b4@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712953107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLHlIUYkkULgzyqbRS6FF1LI5GIXKe6Pa6vjv4BQWm8=; b=p7jt+z9cc4v9PIS8lyAxIEXownkEIzBPe2g/oZJocDj4+m7XfpeRT8+5MwP1cGjSpwfvEH 97EB0INVEdoR8NvS9SGgD7uUEnXN+IrXV35yevhrSx32zgnj95OyuNzJ51zSnNGtSUxKV2 9ajPlMK08u5WN2ucsSuKB2G77y3VFAI= Date: Fri, 12 Apr 2024 16:18:01 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 4.19 000/175] 4.19.312-rc1 review X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson To: Pavel Machek , Greg Kroah-Hartman Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, broonie@kernel.org, maco@android.com, tglx@linutronix.de, christophe.jaillet@wanadoo.fr References: <20240411095419.532012976@linuxfoundation.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 4/12/24 16:10, Sean Anderson wrote: > On 4/12/24 15:46, Pavel Machek wrote: >>> Sean Anderson >>> soc: fsl: qbman: Use raw spinlock for cgr_lock >> >> As we don't have commit ef2a8d5478b9 ("net: dpaa: Adjust queue depth >> on rate change") in 4.19, we should not really need this. Sorry, I missed this the first time around, but this bug will still occur (just much more rarely) without this commit. --Sean > Plus, 10msec >> under raw spinlock is quite evil, such kernel is not realtime any >> more. We should not be doing that. > > Patches welcome :) > > At some point I will try and revisit this. > > --Sean