Received-SPF: pass (google.com: domain of linux-kernel+bounces-143307-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 12 Apr 2024 16:23:39 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-stable <stable@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "patches@kernelci.org" <patches@kernelci.org>,
        "lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
        "pavel@denx.de" <pavel@denx.de>,
        "jonathanh@nvidia.com" <jonathanh@nvidia.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
        "srw@sladewatkins.net" <srw@sladewatkins.net>,
        "rwarsow@gmx.de" <rwarsow@gmx.de>,
        "conor@kernel.org" <conor@kernel.org>,
        "allen.lkml@gmail.com" <allen.lkml@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        Calum Mackay <calum.mackay@oracle.com>,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Darren Kenny <darren.kenny@oracle.com>,
        Ramanan Govindarajan <ramanan.govindarajan@oracle.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review
Message-ID: <ZhmYS9ntNbDZvkKE@tissot.1015granger.net>
References: <20240411095407.982258070@linuxfoundation.org>
 <2c2362c7-ace7-4a79-861e-fa435e46ac85@oracle.com>
 <27E1E4C4-86C3-4D78-AF85-50C1612675E0@oracle.com>
 <21c9bcf9-2d44-4ab2-b05c-a1712ac1a434@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <21c9bcf9-2d44-4ab2-b05c-a1712ac1a434@oracle.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?mM77e4n3UjYB3NrzfZWOiGx188K1rbnRhFnmFRAylF1eUHCpGmLQHGujRxbA?=
 =?us-ascii?Q?n+uuqd0Zy9KjM9/3aPl749HYZIbYEwXpD+hs1Q19cYNHj9xIOb5012xkgJjb?=
 =?us-ascii?Q?utYLdj0d1ABKQkiUe/Oq1I0rhunJ8wG+SwsrJLumjpI5c75XsR8yDAM6BUaZ?=
 =?us-ascii?Q?YPlTAsepFmLzUSAbgwgEXmnCGJj6GIdbQQy2+PjHXbsJW2dVMRQgdL04z6Ry?=
 =?us-ascii?Q?HiM4d8oIoKiw5dXWxh7cD+4G2z2M6dVeyZfhYsBnyYxyvrAjpmzAN5zaKJQH?=
 =?us-ascii?Q?1lC8gJ7VhuDaEbRMDqkh3JTG2gmH/CECOuG/9Ds8iIuSPXLO+/lq0Sr6O+/i?=
 =?us-ascii?Q?hwBmiScz9JWaL61wOeWPdPfzhzfFSaYaTKLpR3lWC37rorWTPykKtZm6IHAR?=
 =?us-ascii?Q?MGdhqDpl1Ae5FOvYg8ts3h4nTgtRaBA9iyp7pqm9YJCYdfl/zKbDx5XxRPou?=
 =?us-ascii?Q?z1SRmmD6M2hpUMbFqwtlqpdy2OwEm0E83mwqaPRsRf6iRUejAfTX/lMrNy6J?=
 =?us-ascii?Q?fw3T2/eKAh/RdB31kQwTaLr7ORtJo2HxiJflg+GxadaBNJWbXJe4vpQ/njkZ?=
 =?us-ascii?Q?ETbHCwuE55cl/A+iEp2/gzOkLLB7EX433iiKlyzE+pA/bOEbZKU1RcEh1NxD?=
 =?us-ascii?Q?GANek/IFO7vCc8BP5ekSaNDUJKMqfynxRn3V5YYNE9DEOKqgOAPlM9M7v/q3?=
 =?us-ascii?Q?m6MWBMB7qRMr9SMv7+XvCKmdO84KsE48Qnd1DKcAKvIVU38fgSrthJZ8+93z?=
 =?us-ascii?Q?B70dT3gJiUHFus3D3bawzSWY3/+oOHFGiyOD5uiF3//zsew4LC9tTtQiM9Is?=
 =?us-ascii?Q?SAI4nXKsqMhq1P1AP3BidZeIuwbJu15SjaPfakPfmbxikGXsg8wxyw7LEiHE?=
 =?us-ascii?Q?8cHuud8HjueefT2AfoJ75lL/W77Tzvos+q2M+97mIi+pUdR7bKM1JM1GxNUO?=
 =?us-ascii?Q?IVoD5pWaHX4vhEcn/syVEDif16Z+3iuQPyozLYF9nLDbWpQxLcMIAj9TFwgD?=
 =?us-ascii?Q?0lchqIU9agu0AP5mp2FdC0SBBELUshigv7nf2jY4Z9paPDp+NlLCsEDOuLTW?=
 =?us-ascii?Q?er7b/eBqBNaq8jmAk6AKj00MjZTeBOWv55YgM8EywiPLw2PCV3Z6+UQDnT9o?=
 =?us-ascii?Q?o171qsPoP+mBMl3xWRsi3EVuJN/NGBTiojKGd7PrIaJWi0LdViZsKk3gx0kK?=
 =?us-ascii?Q?lHG3eD1eKK7l6lqE8Mcn/vyGwrKf981MaXAFMePgUFyZXEZFYQZptQD7aeL5?=
 =?us-ascii?Q?9UaZzG7Gfos7jyhcWBPUMTo1omKgQm+Cx6zF/JzLJHDYMMlL4qLMTkDTEW8f?=
 =?us-ascii?Q?RX9mSa1+EE0+i0yLbAUAqHCqddEr+26enKyrBXPYVs6mkaZiF0mXGpHe19R8?=
 =?us-ascii?Q?soFbvBcvS639EanEI4PqWK7jzp13gmQLzRI9RIVsfwV8exG+CrWSOS0Dbnmv?=
 =?us-ascii?Q?9fhTsSWQz6zEQxgEhoLtcJ8cghUd/1zB0ms8qk/Tj3teT2myn/dVXpMpKM7v?=
 =?us-ascii?Q?iUfNCJCu9xwTnoLPmRWpvb9hktLD3jiHPmTDHzsMoca3aCIS3KBA5pHMSs79?=
 =?us-ascii?Q?pAXo6mt9QOlvzbM/BguBg1dNrs4zbV4Fm3NyZvTz3///kySkIgJgMK+C4Qve?=
 =?us-ascii?Q?tA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	fQeqnZKIakxmmuXKNw4vVDxIMFtK7UtO/tbDPj1Pq5rvXfkaTPedUdGjwEjlgr6fM9MWCpjhcqFW6OtRw+6Xp/vfGFd03ynWRPyomhwtkm/MO5TkkmZDZnqFOLD90yrMIZwCn7lNoiYOzwE90m5CHJhRY2RLfTnXzEDam4AaistH8tk+V1RD3xgORME+bz83ugGEL/DL+tTSX6izU4FbImdQmrTLvSUtBp9e2ZK59aZLPfIMu8Uo4ylQZ4uAQmmUNRWgA6doEmc2bY1L+rpXs75wDs+b96g+vEqgBKhFhpb3yi2aGI6TQJoskGuLyUJHgngoLVF8+gYUQYKD/CrUW8agtRQjq61nBGd3Ysbdy37jTTlTpoRlK6Hv2ERO+96Gecf5lbMuylugKkTIqgHRYvVi3NUqZ/avfAcdi00tKup3CBwbkIPpGA9q5LRZDQPm6J6Bm93GGcr+t4QtnditMlndfXTCKmyzdE5D5+3hiXK3xj1iR8uFzCdhUOV3vZvuccdwNm0u8JsnJMK1idCiYZ8qAUA3HE/lzt/g5Zo4YU+faiyBYWWi2PiD4MPNVowqnAHCiWjnl7emFt6jJCxYC3bMs5ELbIfh5RTAFTJNdN0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67e16453-3ec7-4667-8899-08dc5b2e7318
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 20:23:43.8804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QF6W9tgGZNFXruyn5LhWeDVzUA93xPrTiI2uciFR5fPSwW8QulVVf66B94Ck6xOLV8rRm8LrqdthujnwKz/Zqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR10MB7687
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-12_16,2024-04-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404120148
X-Proofpoint-ORIG-GUID: ibq-hUkF_2ZN5r_Ry9JJaqojSb6O6WO2
X-Proofpoint-GUID: ibq-hUkF_2ZN5r_Ry9JJaqojSb6O6WO2

On Sat, Apr 13, 2024 at 01:41:52AM +0530, Harshit Mogalapalli wrote:
> Hi Greg, Chuck,
> 
> On 12/04/24 21:27, Chuck Lever III wrote:
> > 
> > 
> > > I have noticed a regression in lts test case with nfsv4 and this was overlooked in the previous cycle(5.15.154). So the regression is from 153-->154 update. And I think that is due to nfs backports we had in 5.15.154.
> > > 
> > > # ./runltp -d /tmpdir -s fcntl17
> > > 
> > > <<<test_start>>>
> > > tag=fcntl17 stime=1712915065
> ...
> > > fcntl17     1  TFAIL  :  fcntl17.c:429: Alarm expired, deadlock not detected
> > > fcntl17     0  TWARN  :  fcntl17.c:430: You may need to kill child processes by hand
> > > fcntl17     2  TPASS  :  Block 1 PASSED
> > > fcntl17     0  TINFO  :  Exit block 1
> > > fcntl17     0  TWARN  :  tst_tmpdir.c:342: tst_rmdir: rmobj(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed: unlink(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed; errno=2: ENOENT
> > > 
> > > 
> > > Steps used after installing latest ltp:
> > > 
> > > $ mkdir /tmpdir
> > > $ yum install nfs-utils  -y
> > > $ echo "/media *(rw,no_root_squash,sync)" >/etc/exports
> > > $ systemctl start nfs-server.service
> > > $ mount -o rw,nfsvers=3 127.0.0.1:/media /tmpdir
> > > $ cd /opt/ltp
> > > $ ./runltp -d /tmpdir -s fcntl17
> > > 
> > > 
> > > 
> > > This does not happen in 5.15.153 tag.
> > > 
> > > Adding nfs people to the CC list
> > 
> > The reproducer uses NFSv3, but the bug report says NFSv4
> > at the top.
> > 
> > I was able to reproduce this on my nfsd-5.15.y branch
> > with NFSv3.
> > 
> > A bisect would be most helpful.
> > 
> 
> I was able to bisect: here are the results:
> 
> 
> 
> 2267b2e84593bd3d61a1188e68fba06307fa9dab is the first bad commit
> commit 2267b2e84593bd3d61a1188e68fba06307fa9dab
> Author: Alexander Aring <aahringo@redhat.com>
> Date:   Tue Sep 12 17:53:18 2023 -0400
> 
>     lockd: introduce safe async lock op
> 
>     [ Upstream commit 2dd10de8e6bcbacf85ad758b904543c294820c63 ]
> 
>     This patch reverts mostly commit 40595cdc93ed ("nfs: block notification
>     on fs with its own ->lock") and introduces an EXPORT_OP_ASYNC_LOCK
>     export flag to signal that the "own ->lock" implementation supports
>     async lock requests. The only main user is DLM that is used by GFS2 and
>     OCFS2 filesystem. Those implement their own lock() implementation and
>     return FILE_LOCK_DEFERRED as return value. Since commit 40595cdc93ed
>     ("nfs: block notification on fs with its own ->lock") the DLM
>     implementation were never updated. This patch should prepare for DLM
>     to set the EXPORT_OP_ASYNC_LOCK export flag and update the DLM
>     plock implementation regarding to it.
> 
>     Acked-by: Jeff Layton <jlayton@kernel.org>
>     Signed-off-by: Alexander Aring <aahringo@redhat.com>
>     Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> 
>  Documentation/filesystems/nfs/exporting.rst |  7 +++++++
>  fs/lockd/svclock.c                          |  4 +---
>  fs/nfsd/nfs4state.c                         | 10 +++++++---
>  include/linux/exportfs.h                    | 14 ++++++++++++++
>  4 files changed, 29 insertions(+), 6 deletions(-)
> 
> Bisect log:
> ==========
> 
> git bisect start
> # status: waiting for both good and bad commits
> # bad: [cdfd0a7f01396303e9d4fb3513a1127636f12e5e] Linux 5.15.154
> git bisect bad cdfd0a7f01396303e9d4fb3513a1127636f12e5e
> # status: waiting for good commit(s), bad commit known
> # good: [9465fef4ae351749f7068da8c78af4ca27e61928] Linux 5.15.153
> git bisect good 9465fef4ae351749f7068da8c78af4ca27e61928
> # good: [4420d19ed4e4fe2adc9bed8a49bf195db1137458] NFSD: Report average age
> of filecache items
> git bisect good 4420d19ed4e4fe2adc9bed8a49bf195db1137458
> # good: [94e412c945e64579798204aee7bc669d0acfaf79] nfsd: fix courtesy client
> with deny mode handling in nfs4_upgrade_open
> git bisect good 94e412c945e64579798204aee7bc669d0acfaf79
> # bad: [254f1c2521716cafc63530750ce313059f5d5979] iwlwifi: mvm: rfi: use
> kmemdup() to replace kzalloc + memcpy
> git bisect bad 254f1c2521716cafc63530750ce313059f5d5979
> # bad: [e635f652696ef6f1230621cfd89c350cb5ec6169] serial: sc16is7xx: convert
> from _raw_ to _noinc_ regmap functions for FIFO
> git bisect bad e635f652696ef6f1230621cfd89c350cb5ec6169
> # good: [05b452e8748bcf92c00725691437e16d46af7c28] nfsd: Fix creation time
> serialization order
> git bisect good 05b452e8748bcf92c00725691437e16d46af7c28
> # bad: [ccd9fe71b9ee46ebcecec8aec5c4f1e1ddd35dfd] nfsd: Fix a regression in
> nfsd_setattr()
> git bisect bad ccd9fe71b9ee46ebcecec8aec5c4f1e1ddd35dfd
> # bad: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd: introduce safe
> async lock op
> git bisect bad 2267b2e84593bd3d61a1188e68fba06307fa9dab
> # good: [56e5eeff6cfa4bd6ffa2b2ae5b8bfc1c28044faf] nfsd: separate
> nfsd_last_thread() from nfsd_put()
> git bisect good 56e5eeff6cfa4bd6ffa2b2ae5b8bfc1c28044faf
> # good: [6e5fed48d8b7b25f8517a1292b62a3a86a5aec91] NFSD: fix possible oops
> when nfsd/pool_stats is closed.
> git bisect good 6e5fed48d8b7b25f8517a1292b62a3a86a5aec91
> # first bad commit: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd:
> introduce safe async lock op
> 
> 
> Hope the above might help.

Nice work. Thanks!


> I didnot test the revert of culprit commit on top of 5.15.154 yet.

Please try reverting that one -- it's very close to the top so one
or two others might need to be pulled off as well.

I expect this is due to a missing pre-requisite commit.


-- 
Chuck Lever