Received-SPF: pass (google.com: domain of linux-kernel+bounces-143309-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 12 Apr 2024 13:27:13 -0700
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] scripts/faddr2line: Check only two symbols when
 calculating symbol size
Message-ID: <20240412202713.ntmhxrpjovbhafu2@treble>
References: <20240311204019.1183634-1-bjohannesmeyer@gmail.com>
 <20240311204019.1183634-8-bjohannesmeyer@gmail.com>
 <CAOZ5it1NaWyUM4GTJ+XrMet7aQXT27q1VZ4FeD8osbTccVpj9w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAOZ5it1NaWyUM4GTJ+XrMet7aQXT27q1VZ4FeD8osbTccVpj9w@mail.gmail.com>

On Thu, Apr 11, 2024 at 12:28:29PM -0700, Brian Johannesmeyer wrote:
> Hey Josh,
> 
> I just noticed that this patch does not correctly handle duplicate
> sym_names. To fix, the "--no-group-separator" option should be added
> as follows:
> 
> > -               done < <(echo "${ELF_SYMS}" | sed 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2)
> > +               done < <(echo "${ELF_SYMS}" | sed 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2 | ${GREP} -A1 --no-group-separator " ${sym_name}$")
> 
> Would you like me to re-submit the patch series with this fix?

Yes, that would be helpful.  Thanks!

-- 
Josh