Received-SPF: pass (google.com: domain of linux-kernel+bounces-143461-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Inochi Amaoto <inochiama@outlook.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Chen Wang <unicorn_wang@outlook.com>,
	Inochi Amaoto <inochiama@outlook.com>
Cc: linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: [PATCH] clk: sophgo: Use div64 for fpll rate calculation
Date: Sat, 13 Apr 2024 08:53:33 +0800
Message-ID:
 <IA1PR20MB4953CB4FCCDE82AB25F6880EBB0B2@IA1PR20MB4953.namprd20.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|SJ2PR20MB6159:EE_
X-MS-Office365-Filtering-Correlation-Id: fc8c2648-43b6-4743-5e31-08dc5b541c51
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	E4FLxoyDAwHTAxLTXdCBHxmE8ItMfwqMgIcjjawm9p+O/DYzeaQMOc4MsBNczU81IBTUYDX+4x3K6QUF5HoYrbblPjSjVWm8Qig046bFWL0ObYnXaBGSiWYl3LdMA0PTNYqgK3I6p1Sm4MUakWin0s1LnBcaoSqwD/hR/YvLXS2EWWFb/aEf+vtVWgJ4z2FRYhJQTp1UN56bzCkxgmYbo5AxputjHqyzXbbekHo2k2fnVFHbwY3QxNZOvgPFSUodvQODNh+uVZMsAGGGVppNh4rWiESDrws5Jd3EilVap8tCFtkqtS7GLrLBG2XWnIjnZgxuWMG/SYZIUj2awZ4TLryMjd/rsu4uyd3Y6ETZxofiNZ9NoahE+nRubDUIgm5u0jWNSegKX6lWW/Jh2101qXj87XWryy4lcxjfPNHlqJRNwLX0+spqTLB6uSmx9H0fucBDUEFaCnxJ/VUFpuHjGCLar53UipefXbbRjfD7SSnNLGdTDNfO/nrCvY7xhp5heMPvBznoU2aNYAuSRayM8UJagZaNA17EjPwJPV++UYhrt3vIdFq0wmG5E5jzGUc6OPD0zhHYnqtRIA3BO9vvmOUtFHxG/ev08P3u+Kg7HgNzmNju+dtA9gUsQ2G8IT4op+T/Oa3TlS4jgOCNWPpe/tYk5nWsUDU5SNY5ks+1S5zbh2UBqY5LV6rSd2fjuLkNP5Kv9vCfETKfyE/Zm19PwQ63w0+2Zqecl0ayD6sFslNQZX6sxIgXori8iCW/jNuX
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qheEYyZutnUBz96xA4eKDCXd6Cl92E2zRCfIK8Btof0OE6mjWr3wfiHA3sNF?=
 =?us-ascii?Q?8+FgX2qM7sztnxVzNNSXSrtqHyqOvn7hpUsXRbfJ25Shhi7e3JMqqlRK6Xkj?=
 =?us-ascii?Q?ceTD8/055BBz3bTcZM3u9d5HHb3IeYD9jxgRym7TQ45xhvxtl0VltaUMURIz?=
 =?us-ascii?Q?gH0S6z4zSoURJwPtHx5IlYA8PZBYGAo9ddznhkpfC1xmHfcgtWbtIJelKfrj?=
 =?us-ascii?Q?Myp03DX9AQG6Od2HFPCb3AgwYWDwOpihcbHxCi/jT/Buh6sYP65JBo+QT2Sr?=
 =?us-ascii?Q?ifVQQLIb7iPycYr5jDKv4MYOhJaIbY2vTCIxBj66o7i2qV2dTBdg8VKl+Qgu?=
 =?us-ascii?Q?buHlZwa3568e0PUBfvKwOMykT9mv8Bwx9Ch0mbW4Ui3JEchvZbEy9TcUYl2m?=
 =?us-ascii?Q?6DYLC6ZowOBtvcO86I20EjBETqUJKouLr5BOkIft05ChFVk/gZa7l6rQtCkx?=
 =?us-ascii?Q?xYU31y2otp/mFCjx2WGcLQ8dHFdwGbDbh2DxlcmlDp82BKwiohVx8FQTwOuU?=
 =?us-ascii?Q?hCQrhDwEdnyRcIkaE8O1SKAX0tYc+kCBD1ecZlXQh49lWD5zEJ+mUxGhI4W0?=
 =?us-ascii?Q?P3w98ymr6vAfhRGyaxXeolsNWxXsp5As4vMJhSesMEMiIaYCnB3hC1exk+Wh?=
 =?us-ascii?Q?sP772VwFj6pxZ3XDaHySVX2U7SHpBN9fPVAjrBGzGoQHt+0YKZNUpTiyH5PU?=
 =?us-ascii?Q?0vp6ScuCQ25qylLbNSswljyXc9dahO5Haf65ey5YvPRG/9TxIb4avTRyvHcy?=
 =?us-ascii?Q?tyy/bGpsORomXPvmz3YdDx2D6g8RUWqlU/f2XVxGbOadZc8ZZujRZ4gJ2q9l?=
 =?us-ascii?Q?miOPitnGonhlHPBJ1hhVgRKl0ovlb8AdNSYSJG118zGEYWEvP+sWzqTJL3fr?=
 =?us-ascii?Q?MQDPpXb7aJOdbpdNyyJv41NYfcKz4JcbKnqH/Zhng3dTYqsBLEOrx6ON2rwd?=
 =?us-ascii?Q?aa9OhWmEyVGH8l9Je5gU3MWPyBTRrQ+kDiav6dCTFF57cLIDPR//hmS4MfE4?=
 =?us-ascii?Q?mHLTUeGMCNrPLNClPdRnJ0S7H+9A3Pcg13dB/GvaziH6Jb07mNVur+RajAaL?=
 =?us-ascii?Q?f1Cacb4uVP1qD/GhvNd9tsC+VWkP2qeW8Gf0tJrZavO0d3E6EdNL1h613atd?=
 =?us-ascii?Q?WGC5Vt7jet0CIpSX7EIqX/P+eBxzNvRt373PGvVOcL8sv+84vGlyRitc37ED?=
 =?us-ascii?Q?5ACDfwnQe0ViUXRCnlQV87SCndQrDjb9Vvf+nolW4FjTfKwfwa03Xj/FLfBT?=
 =?us-ascii?Q?yaO/PxYi946/IDmhOifu?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc8c2648-43b6-4743-5e31-08dc5b541c51
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 00:53:19.8144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR20MB6159

The CV1800 SoC needs to use 64-bit division for fpll rate
calculation, which will cause problem on 32-bit system.
Use div64 series function to avoid this problem.

Fixes: 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404122344.d5pb2N1I-lkp@intel.com/
---
 drivers/clk/sophgo/clk-cv18xx-pll.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/sophgo/clk-cv18xx-pll.c b/drivers/clk/sophgo/clk-cv18xx-pll.c
index c546dad1791c..65aba3b95cf7 100644
--- a/drivers/clk/sophgo/clk-cv18xx-pll.c
+++ b/drivers/clk/sophgo/clk-cv18xx-pll.c
@@ -6,6 +6,7 @@
 #include <linux/clk-provider.h>
 #include <linux/io.h>
 #include <linux/limits.h>
+#include <linux/math64.h>
 #include <linux/spinlock.h>

 #include "clk-cv18xx-pll.h"
@@ -202,18 +203,18 @@ static unsigned long fpll_calc_rate(unsigned long parent_rate,
 {
 	u64 dividend = parent_rate * div_sel;
 	u64 factor = ssc_syn_set * pre_div_sel * post_div_sel;
+	u64 remainder;
 	unsigned long rate;

 	dividend <<= PLL_SYN_FACTOR_DOT_POS - 1;
-	rate = dividend / factor;
-	dividend %= factor;
+	rate = div64_u64_rem(dividend, factor, &remainder);

 	if (is_full_parent) {
-		dividend <<= 1;
+		remainder <<= 1;
 		rate <<= 1;
 	}

-	rate += DIV64_U64_ROUND_CLOSEST(dividend, factor);
+	rate += DIV64_U64_ROUND_CLOSEST(remainder, factor);

 	return rate;
 }
--
2.44.0