Received-SPF: pass (google.com: domain of linux-kernel+bounces-143502-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240413-tcp-ao-selftests-fixes-v1-0-f9c41c96949d@gmail.com> <20240413-tcp-ao-selftests-fixes-v1-4-f9c41c96949d@gmail.com>
In-Reply-To: <20240413-tcp-ao-selftests-fixes-v1-4-f9c41c96949d@gmail.com>
From: Dmitry Safonov <0x7f454c46@gmail.com>
Date: Sat, 13 Apr 2024 02:50:46 +0100
Message-ID: <CAJwJo6bjzgL7Y_EPOL1rYqSz5MNO60iKtCFF-_guq48FwxwKKg@mail.gmail.com>
Subject: Re: [PATCH net 4/4] selftests/tcp_ao: Printing fixes to confirm with format-security
To: 0x7f454c46@gmail.com
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, 
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 13 Apr 2024 at 02:43, Dmitry Safonov via B4 Relay
<devnull+0x7f454c46.gmail.com@kernel.org> wrote:
>
> From: Dmitry Safonov <0x7f454c46@gmail.com>
>
> On my new laptop with packages from nixos-unstable, gcc 12.3.0 produces
> > lib/setup.c: In function =E2=80=98__test_msg=E2=80=99:
> > lib/setup.c:20:9: error: format not a string literal and no format argu=
ments [-Werror=3Dformat-security]
> >    20 |         ksft_print_msg(buf);
> >       |         ^~~~~~~~~~~~~~
> > lib/setup.c: In function =E2=80=98__test_ok=E2=80=99:
> > lib/setup.c:26:9: error: format not a string literal and no format argu=
ments [-Werror=3Dformat-security]
> >    26 |         ksft_test_result_pass(buf);
> >       |         ^~~~~~~~~~~~~~~~~~~~~
> > lib/setup.c: In function =E2=80=98__test_fail=E2=80=99:
> > lib/setup.c:32:9: error: format not a string literal and no format argu=
ments [-Werror=3Dformat-security]
> >    32 |         ksft_test_result_fail(buf);
> >       |         ^~~~~~~~~~~~~~~~~~~~~
> > lib/setup.c: In function =E2=80=98__test_xfail=E2=80=99:
> > lib/setup.c:38:9: error: format not a string literal and no format argu=
ments [-Werror=3Dformat-security]
> >    38 |         ksft_test_result_xfail(buf);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~
> > lib/setup.c: In function =E2=80=98__test_error=E2=80=99:
> > lib/setup.c:44:9: error: format not a string literal and no format argu=
ments [-Werror=3Dformat-security]
> >    44 |         ksft_test_result_error(buf);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~
> > lib/setup.c: In function =E2=80=98__test_skip=E2=80=99:
> > lib/setup.c:50:9: error: format not a string literal and no format argu=
ments [-Werror=3Dformat-security]
> >    50 |         ksft_test_result_skip(buf);
> >       |         ^~~~~~~~~~~~~~~~~~~~~
> > cc1: some warnings being treated as errors
>
> As the buffer was already pre-printed into, print it as a string
> rather than a format-string.
>
> Fixes: cfbab37b3da0 ("selftests/net: Add TCP-AO library")
> Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>

And this one as well,

Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/all/0c6d4f0d-2064-4444-986b-1d1ed782135f@coll=
abora.com/

--=20
             Dmitry