Received-SPF: pass (google.com: domain of linux-kernel+bounces-143508-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 12 Apr 2024 19:00:43 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: Jiri Pirko <jiri@resnulli.us>, <yisen.zhuang@huawei.com>,
 <salil.mehta@huawei.com>, <davem@davemloft.net>, <edumazet@google.com>,
 <pabeni@redhat.com>, <horms@kernel.org>, <rkannoth@marvell.com>,
 <shenjian15@huawei.com>, <wangjie125@huawei.com>, <liuyonglong@huawei.com>,
 <chenhao418@huawei.com>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V7 net-next 4/4] net: hns3: add support to query scc
 version by devlink info
Message-ID: <20240412190043.69c306c5@kernel.org>
In-Reply-To: <5e9abc23-96c8-4a37-abae-f6c208aacda2@huawei.com>
References: <20240410125354.2177067-1-shaojijie@huawei.com>
	<20240410125354.2177067-5-shaojijie@huawei.com>
	<ZhapUja4xXiJe4Q2@nanopsycho>
	<16347737-f0ac-4710-85ee-189abed59d6b@huawei.com>
	<ZheB58bjmkFzIEbG@nanopsycho>
	<5e9abc23-96c8-4a37-abae-f6c208aacda2@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 12 Apr 2024 15:12:17 +0800 Jijie Shao wrote:
> >> +   * - ``fw.scc``
> >> +     - running
> >> +     - Used to represent the soft congestion control firmware version.
> >>
> >> scc means "soft congestion control"  
> > I guess this is something specific to your device, isn't it? Can't you
> > please extend the description a bit more?
> >
> SCC is a firmware which provides multiple congestion control algorithms, including dcqcn.
> Congestion control is a mechanism that controls the entry of rdma packets into the network,
> enabling a better use of a shared network infrastructure and avoiding congestive collapse.

Thanks, I'll amend the patch with a condensed version of this info.
Otherwise I feel like we'll need another 3 revisions to polish it..