Received-SPF: pass (google.com: domain of linux-kernel+bounces-143528-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 13 Apr 2024 10:56:10 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v1 1/1] fpga: ice40-spi: Remove redundant of_match_ptr()
 macros
Message-ID: <Zhn0SgGulHq8Bbk3@yilunxu-OptiPlex-7050>
References: <20240412155830.96137-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240412155830.96137-1-andriy.shevchenko@linux.intel.com>

On Fri, Apr 12, 2024 at 06:58:30PM +0300, Andy Shevchenko wrote:
> Since the driver hi6421-regulator depends on CONFIG_OF,
                   ^
It is ice40-spi

> it makes no difference to wrap of_match_ptr() here.
> 
> Remove of_match_ptr() macros to clean it up.
> 
> While at it, add missing mod_devicetable.h.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/r/20240412151147.22a059ff@canb.auug.org.au
> Fixes: 5d04660b29fb ("fpga: ice40-spi: Remove unused of_gpio.h")

Since 5d04660b29fb is not merged yet, could you just merge them into one?
Or it breaks bisecting.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/fpga/ice40-spi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c
> index 46927945f1b9..62c30266130d 100644
> --- a/drivers/fpga/ice40-spi.c
> +++ b/drivers/fpga/ice40-spi.c
> @@ -10,6 +10,7 @@
>  
>  #include <linux/fpga/fpga-mgr.h>
>  #include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/spi/spi.h>
>  #include <linux/stringify.h>
> @@ -198,7 +199,7 @@ static struct spi_driver ice40_fpga_driver = {
>  	.probe = ice40_fpga_probe,
>  	.driver = {
>  		.name = "ice40spi",
> -		.of_match_table = of_match_ptr(ice40_fpga_of_match),
> +		.of_match_table = ice40_fpga_of_match,

It works, thanks for quick fix.

Yilun

>  	},
>  	.id_table = ice40_fpga_spi_ids,
>  };
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
> 
>