Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp304630lqp; Fri, 12 Apr 2024 20:18:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUg/AeY/hxq5aIIdPKfDeiu1NRTYFC3jmhW+r2aOBsUKl5m53kIi4rptusSHh99YsQLrf7XHR6Z+DCCw7qoqsyIk/hjZ2qqP46nAIBhsg== X-Google-Smtp-Source: AGHT+IHx0/Q/MIaw2tivkTW9ALB/Zn+qXMWX+Jz+CRL6sKo4HA7IpBnmHPOt0UNyr8LQK8iViQJ+ X-Received: by 2002:a50:c054:0:b0:56e:e8f:d525 with SMTP id u20-20020a50c054000000b0056e0e8fd525mr3091183edd.27.1712978305217; Fri, 12 Apr 2024 20:18:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712978305; cv=pass; d=google.com; s=arc-20160816; b=RKwXhzr7HVBN3w/xGXSV9NNujxny8d4nj+3wSNHayYxsoQqg0xjzjXwi8Jm7P81Pew 0F9srkrzWxbJDBj9Xc1YO8CsECYOPGoVcSQpl9SdLPh3LcP/kMWA6I5LtuRm2K6URPIH XNjn43ssb/J1AYBC24Q0qugHX/f3TZn7ZWsckCiOfVwmVsx+vfsxtqy61yL6YymrPTBs 4JPgi35rHvtreZ7PFgoZ/8djL+8TlvumWEo5TrPlrWHju01UiJAAF50U1Zkeb0IpyBbp oobozn5+2M/r0XAvAdEqklxkZhdhHZEpns6UMmsZs98D25N+UKCGZxKj5OUur2oFnHSx V4XA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=PNnFVE6OxAC9vi6MOO4Z+HaTgoU0dnwIGRx/mpHEgUA=; fh=r16d8/bmHyNP40IdIhj8XVHy6Xk9NgCfMRuB32fOfTU=; b=LbIGwDCbKcUnnruIcC4QQNqnQdvbtNAXnmc4BVdE5k6EJ/gUIITwZaczqva/zN7dET qJqDRDYE7T6d/NsfDDZYOO3gZVhdf2JNfGzQpoDyrtYxU98A0Hon933Q1mmj8WJ19vh+ CM94k90FEIePGLZRGz6nLcxe+wONMndrxPLFrNPy3Eek09Ayh/G+2ZIJ9ZI3Oo3NHhPt Un3HwdrR3xpY3RW/UYFmIgJzbSBHq248AfxLcrPV8T0m39LEVy56F2dgAwW4lep8NjQ5 sySpq0doI9rMXrNMamyPSrZ0uLCfEoyH414I+EKGmxp/wTi+/eXQrRZKNzHxbi8HZbSw rAbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Xp4eOUFL; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-143532-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143532-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t19-20020a50d713000000b0056dfbee4e73si2258412edi.209.2024.04.12.20.18.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 20:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143532-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Xp4eOUFL; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-143532-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143532-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C315E1F23A9B for ; Sat, 13 Apr 2024 03:18:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2830A18633; Sat, 13 Apr 2024 03:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xp4eOUFL" Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEE12EEA9 for ; Sat, 13 Apr 2024 03:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712978297; cv=none; b=hkTc+696i9BSNHlvcw1MTMJeuqYD5FlPmXoqOiKuHa9iTFp2uLFIO9fOKZycGol6g2jkNMdNvu0TdA+H1uouWsMb3pehvtqQfrtzmuqMMVPnA8JaF3F5GZwtOD9AdiDL/veXylq8G4OrXZmLG5WAVBKh1bBrpf+WjPqgCZzcRmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712978297; c=relaxed/simple; bh=Fama9Su1+zJu7/zSs5t57yOZMei5xDHkLujGRBWKBKI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uEclKEMvikaPSzd1qpjHzJeg9OtHOu0KeUcQo5EjSRW0sDDI2bx6lDeD+PE4nhldAUTR0YKAd86oI1DC+60siz8lQMyCDxFfMtI8cAjERyUyOpk9MGNzSWjf9kEMQefE1Qf+toGxDd2xXmfdQj4Eli0ah0hsBcBQGWZo5qmeT7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xp4eOUFL; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a469dffbdfeso46579466b.0 for ; Fri, 12 Apr 2024 20:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712978294; x=1713583094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PNnFVE6OxAC9vi6MOO4Z+HaTgoU0dnwIGRx/mpHEgUA=; b=Xp4eOUFLhhdcJIizdNGX4hxL9MZPxLaLmLmkwovu1pUF9gTqdeSiQLv2PomfU5fjk+ 04m+ZTpmM5s5Cfm1EJ0Ym7osnaQvfX7dt41tcdhJ8T3g/NI3kuWwd+q2diJrBrRleucM HtCTfgljZQjwUUmGp0kSZn5Mu3Ih8dqxq0sF/Wgx+npWOEf347h/wC1+Xxl46Vq2moHr 8v23e5Iau0krZK6NTHVZ1mS3ZPXnuZwKH7MvkcbhxzpN1dPyrG3y+8y2jb6NVm8WCuWJ 45yIIzYCZnvjGz7JfYgrWORTbjGl60MckARx3canYLwLQPqMCVRPKTVMzOj4cNMoH3YZ IAtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712978294; x=1713583094; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PNnFVE6OxAC9vi6MOO4Z+HaTgoU0dnwIGRx/mpHEgUA=; b=MDd8HGGxUf/mXaeqJ6Qy2wRyLOpWwKvgTT+7eqTQGVDceOMkQhq3Te6T/BLl43YEbl rHHzYpBGqiZId/IUj+iCcAJFoL+C31UrnqsGXGAfTlHIl8p8g649hTO8AHICHUa2QaIt SODAif6XcW4dQUwbcmVb+0yATJxVGw/TXG4ETBEusTbaBgxKm4T3SwjA6K0qV2jTLQpX XlajlPhqMCAfeJ4iTe1VcYo76Kl+hIJ3qHMDFWbwYQERGZwoy3xT5FJPp/DIydFxPMIa Lj9KPbBKON4YYhZ55QF7z6F111fK2MZgPEgFfQGxCwln85rMn2vcGK7pMW8AFh/osXBV 497Q== X-Gm-Message-State: AOJu0YyYCBcLGvi9cdpgF/Lf/AsQR5Pgg33uuvt47KmAffqNyM8P0F9Y XWe7RKKwPxbi1zwb2FHOKuKhguWIfmIXw9Z72HbEZ6gwv4MT31gl0SE6PcT4 X-Received: by 2002:a17:907:6d24:b0:a52:431e:636a with SMTP id sa36-20020a1709076d2400b00a52431e636amr1046090ejc.7.1712978293773; Fri, 12 Apr 2024 20:18:13 -0700 (PDT) Received: from dmitrii-TM1701.. ([2001:8f8:1d36:b77d:8995:4615:5d13:26]) by smtp.gmail.com with ESMTPSA id g4-20020a1709063b0400b00a51bbee7e55sm2450153ejf.53.2024.04.12.20.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 20:18:13 -0700 (PDT) From: Dmitrii Bundin To: linux-kernel@vger.kernel.org Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com, daniel@ffwll.ch, dmitrii.bundin.a@gmail.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, bp@suse.de, gongruiqi1@huawei.com, rdunlap@infradead.org, michal.wajdeczko@intel.com Subject: [PATCH] drm/i915/guc: Fix UB due to signed int overflow Date: Sat, 13 Apr 2024 06:17:47 +0300 Message-Id: <20240413031747.2416581-1-dmitrii.bundin.a@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix compile errors of the form "FIELD_PREP: mask is not constant" caused by signed integer constant overflow. Files affected: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Reproducible with gcc 7.5 Signed-off-by: Dmitrii Bundin --- drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h index 58012edd4eb0..8814d4cd371c 100644 --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h @@ -29,7 +29,7 @@ */ #define GUC_KLV_LEN_MIN 1u -#define GUC_KLV_0_KEY (0xffff << 16) +#define GUC_KLV_0_KEY (0xffffU << 16) #define GUC_KLV_0_LEN (0xffff << 0) #define GUC_KLV_n_VALUE (0xffffffff << 0) -- 2.34.1