Received-SPF: pass (google.com: domain of linux-kernel+bounces-143546-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sat, 13 Apr 2024 11:39:00 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Peter Colberg <peter.colberg@intel.com>
Cc: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
	Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	Russ Weight <russ.weight@linux.dev>,
	Marco Pagani <marpagan@redhat.com>,
	Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH] fpga: dfl: remove unused function is_dfl_feature_present
Message-ID: <Zhn+VHyaD9rZ0X/w@yilunxu-OptiPlex-7050>
References: <20240402222038.1438718-1-peter.colberg@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240402222038.1438718-1-peter.colberg@intel.com>

On Tue, Apr 02, 2024 at 06:20:38PM -0400, Peter Colberg wrote:
> The function is_dfl_feature_present was added in commit 5b57d02a2f94
> ("fpga: dfl: add feature device infrastructure") but never used.

Same git commit reference problem, please see:

https://lore.kernel.org/all/Zhn8bjex94DpkGBw@yilunxu-OptiPlex-7050/

Thanks,
Yilun

> 
> Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
>  drivers/fpga/dfl.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 1d724a28f00a..5063d73b0d82 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
>  	return NULL;
>  }
>  
> -static inline bool is_dfl_feature_present(struct device *dev, u16 id)
> -{
> -	return !!dfl_get_feature_ioaddr_by_id(dev, id);
> -}
> -
>  static inline
>  struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
>  {
> -- 
> 2.44.0
> 
>