Received-SPF: pass (google.com: domain of linux-kernel+bounces-143585-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <96b7f74b-548c-451c-b08e-86173db2e40a@infradead.org>
Date: Fri, 12 Apr 2024 22:39:23 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] include/linux/bitops.h: Fix function fns
To: Chin-Chun Chen <chinchunchen2001@gmail.com>, linux-kernel@vger.kernel.org
References: <20240413052850.9419-1-chinchunchen2001@gmail.com>
Content-Language: en-US
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240413052850.9419-1-chinchunchen2001@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/12/24 10:28 PM, Chin-Chun Chen wrote:
> Modified the function fns to resolve a calculation error by:
> 1. Reducing n first.
> 2. Adding 1 at the end to get the correct index.
> 
> This commit improves the accuracy and reliability of the code.
> 
> Signed-off-by: Chin-Chun Chen <chinchunchen2001@gmail.com>
> ---
>  include/linux/bitops.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> index 2ba557e067fe..2457610f74eb 100644
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -258,8 +258,8 @@ static inline unsigned long fns(unsigned long word, unsigned int n)
>  
>  	while (word) {
>  		bit = __ffs(word);
> -		if (n-- == 0)
> -			return bit;
> +		if (--n == 0)
> +			return bit + 1;
>  		__clear_bit(bit, &word);
>  	}
>  
> 
> base-commit: 8f2c057754b25075aa3da132cd4fd4478cdab854

Hi,

Please send your patch to some maintainer.
People don't browse the mailing list for patches to pick up.


-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html