Received-SPF: pass (google.com: domain of linux-kernel+bounces-143609-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 13 Apr 2024 09:10:59 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: linux-i2c@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>, 
	Andi Shyti <andi.shyti@kernel.org>, linux-arm-kernel@lists.infradead.org, 
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts
Message-ID: <4ogowge36wr2lk2zdsv3zc3sm3pjk4h5wmy2hjth734kgsr3rs@lb4wsmkpavnd>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Dragan Simic <dsimic@manjaro.org>, linux-i2c@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>, 
	Andi Shyti <andi.shyti@kernel.org>, linux-arm-kernel@lists.infradead.org, 
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>
 <20240410112418.6400-33-wsa+renesas@sang-engineering.com>
 <4bcd397ec377a4932c34d62c85ef28ed@manjaro.org>
 <hgdhrf2jiovfxcppdtsq32sfbk4xuq7ewiwq4awwztj4mp3yez@kj6ixihkcxhe>
 <af8ac48f10a1636ab2486aef91e01c3f@manjaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="v5pm4t4sjideud7d"
Content-Disposition: inline
In-Reply-To: <af8ac48f10a1636ab2486aef91e01c3f@manjaro.org>


--v5pm4t4sjideud7d
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Dragan,

> Sure, but I think that having such an additional debug facility
> can only help and save the people from adding temporary printk()s
> while debugging.

Mileages, I guess. I like temporary printouts for temporary debug
sessions. This way the upstream source code stays slim. In my experience
with I2C over the years, debugging happens with developers anyhow.
Logfiles from users which help developers create patches are very rare.
And those users are usually capable enough to add debug patches.
Given these experiences (which may be different in other subsystems), I
don't see why we should carry the bloat.

That said, I'll leave the final decision to the driver maintainers.

Happy hacking,

   Wolfram


--v5pm4t4sjideud7d
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmYaL/8ACgkQFA3kzBSg
KbbTqw/9HLHorgJpCWkk5dX2IWoSeGm6vwPo9lvfGt+zKqEFeo4X5NK/tZq1+DDw
VwDbGJjA1rQX/yVVyVfOMJ5WjijOh2VqDxFp1MDLHyjFFIUgsTUmks9xu5THk5BE
crRGbBhB6Js3rYdvcnbhePf/Y640ARyk2yHaQertEy7iJLhT+c+LyFbUFu3MDQj+
eUWXzHO0XApJnJ1YqnpDYYveqJBzC+IX5CYRJBVYHfyze4chasZZlwQgSVQR/wIM
wBc043r+6y8mN9M4qnApS/IipmF4kpJC39C3P49SxCx51XAQUfxELsQ3/xKoamZD
byF6vf07dheL8z5yTCDEBNGR04qAVtcMpIU8rWprjQB+rcYw1RJJmfr2gcut6Sf8
EogV42Z9O/evQdgOQnV7mGTFd79scfnhoJvO+0o6dYb9hMMk23D0rOcvK+hhaaQC
Tq9prAYaocSLx1lIYp0XZb7jPpdt1KPGIA0y8tygrniikjs202OPAESgA6yQD524
W2VhkwlmeDWS5QpPLe97sMNDyZAkAfRaYzIiDjzrBEU6bZyg5xpsTYo8LgWMIAGR
LcpKTnLZGRfe+d7NlEDJ5PoEjDUpqAsAUNm1n5+6fVoSthRcLtmX/YJJGmDOCDl2
RqcupKY08BVqunvPrT1Ub9LlD9sAARcBi4mGQKAv4Y2m8Q7Onus=
=dhyf
-----END PGP SIGNATURE-----

--v5pm4t4sjideud7d--