Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp384584lqp; Sat, 13 Apr 2024 01:07:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXjQkerrRpNN2RY9f489SQllsDji8a94jlLu3gXArxSdhm4QzFdB2gVhRRxosT2U1xX+criaoT+dr4s4TneExcCBAWh+DfeKlSMrRhCSw== X-Google-Smtp-Source: AGHT+IGCDA2ITdyb0/AIk6hCgRsbtfMR6z+5+NzrRvqfW0jmqytdCBqJY8zmOluLluT+zQ0s+NpQ X-Received: by 2002:a17:906:53c8:b0:a51:d48e:52a0 with SMTP id p8-20020a17090653c800b00a51d48e52a0mr4175447ejo.27.1712995669859; Sat, 13 Apr 2024 01:07:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712995669; cv=pass; d=google.com; s=arc-20160816; b=TqowmQltaaVk+3JbrO9Iyj0v9Axqjne49f/1egOFsiWV3SfDycIVUi7ENIIqyYsKy1 2RzCE0QuTDMANRj5HBIUCPS7+mIPt03hiILVc5wxvH1QV72NEX9MLgr5waEcJM9TnJqY kA/72zHazYCfStVo2MYn0JMTVGE5zkf15/Up6IzEDX9XksY2hrb0pmaLtm+N43lRs9Vh vHsTnvabwm3HrdxQ3sGZY6d63vkbl+ySzZqJJ3rZSUGU1EK1rT6q6qOjmwl0njUljRsg wDOS+HW5Fwx0rIl3arQAjF1L1IY13d2nLTR9ANTryTo3LKpU/ArhAsYdMNvA/YeaN/f9 CPRg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:message-id:references:in-reply-to:subject :cc:to:from:date:dkim-signature:mime-version:list-unsubscribe :list-subscribe:list-id:precedence; bh=LYnFdov+ZX/QOZ7UzZrEIgIh+j/rWuxjP60G0MEoink=; fh=488m8VbjZQbzY+KC8Zzuigz0lHmPkFYRCdjRqZkk0sw=; b=XvBgZE3+TPrHM0g/UMBAqq5eChD0SDuNtM+VKIBRkJI0NAEpVAK9jqI8SBHD/4Oe/Y B4NFzPde1tdjP5OD2VNciTDSO/yvrVaL0HoUXAdpyGZOZwBoZ0gAp9zY7f1Hgchv1rLo nh9NpmYOBSOj+cE7XEmmO9ZQjxd0U7Zx3Ks9pw5jos19KEjDJKeNSCLGktd1YYYtEM36 s88EPAoJSHF8nU31nJqUVIDQFppzHuj485zppKOVIbl4QhiC9d6T2EnPMqVYy+wVer2O +CFAbGvwVoIn/psUPJ1E7E9bug5vH0lRMMUPWzmvrCCXv0WDRvPGIDHkUspr37CCbTMC TdnA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@manjaro.org header.s=2021 header.b="SXSI/zHn"; arc=pass (i=1 spf=pass spfdomain=manjaro.org dkim=pass dkdomain=manjaro.org dmarc=pass fromdomain=manjaro.org); spf=pass (google.com: domain of linux-kernel+bounces-143626-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143626-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manjaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qf4-20020a1709077f0400b00a51ce4057c2si2677257ejc.995.2024.04.13.01.07.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 01:07:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143626-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@manjaro.org header.s=2021 header.b="SXSI/zHn"; arc=pass (i=1 spf=pass spfdomain=manjaro.org dkim=pass dkdomain=manjaro.org dmarc=pass fromdomain=manjaro.org); spf=pass (google.com: domain of linux-kernel+bounces-143626-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143626-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manjaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 94B151F220C7 for ; Sat, 13 Apr 2024 08:07:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 615F2208BC; Sat, 13 Apr 2024 08:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="SXSI/zHn" Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A35A31CD29; Sat, 13 Apr 2024 08:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712995661; cv=none; b=fDKtzYbI1HUwf3hET3sLMHU/NDCH+Ddemy/F1blQwi3yBvpoWC6UKK6fHrdewH6+rUwBJU7v9mPbmOG5TSFJtk1jn/xbac3JWyVsIdoicjVOsvk0zZKE+Me7zx2/kDditVEWUi9cbNl2JLFv+c8eLsYXG2dRbqU5xCjZqajSVAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712995661; c=relaxed/simple; bh=fDnR91pUPs9k8ayRt2nN8sDKaX3MojOlE08aMckL2cA=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=XrU5eUcVy+kS4seUbxaeU8xfy8Hg9JAKQKLsBqent2Ns4DXEfJ2bBcmZi/icqBkZ0YP/prCPSWlZ2ZuwIbRZnjbu3HxvBt9MlmcwcR+kkGDEP5ymx9+fod3jRhSo+dKXooWZjjAtfTxO2k451G/kCtjkPUEqHQp5w9zU4bIt4vo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=SXSI/zHn; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1712995656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LYnFdov+ZX/QOZ7UzZrEIgIh+j/rWuxjP60G0MEoink=; b=SXSI/zHnVe20vBjAJpoMtu0ZvHlgIlLW7ApEhhizFKZ5rvG3+XevLHEewK3oKkfjTsSqqk t0Srxkbcjs68F3n41znGHHd3qszBWObflOHquPzzRIm2sQ7dnjDFaP0u6F76deVkS1HGoq UKtUVd0UCTwoj43JUugxjLUfXlEiqLZOBRcxZguwJOeDzz4Hv5O3mnoL6TaVNzHSSaQtNs TMThbVDIkw3H27nn6oOH6/6JPUaZ7TS0c6V4frYeZveVLK1OBwYV4iBgWseru5XxW2jdvi FrbF4kZwpxsLThi2XHh/yhc5YWCOjIv+7xTmf1UavFjeWclZc19do+HsdPnRUA== Date: Sat, 13 Apr 2024 10:07:36 +0200 From: Dragan Simic To: Dragan Simic Cc: linux-i2c@vger.kernel.org, Heiko Stuebner , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts In-Reply-To: <4ogowge36wr2lk2zdsv3zc3sm3pjk4h5wmy2hjth734kgsr3rs@lb4wsmkpavnd> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> <20240410112418.6400-33-wsa+renesas@sang-engineering.com> <4bcd397ec377a4932c34d62c85ef28ed@manjaro.org> <4ogowge36wr2lk2zdsv3zc3sm3pjk4h5wmy2hjth734kgsr3rs@lb4wsmkpavnd> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello Wolfram, On 2024-04-13 09:10, Wolfram Sang wrote: > Hi Dragan, > >> Sure, but I think that having such an additional debug facility >> can only help and save the people from adding temporary printk()s >> while debugging. > > Mileages, I guess. I like temporary printouts for temporary debug > sessions. This way the upstream source code stays slim. In my > experience > with I2C over the years, debugging happens with developers anyhow. > Logfiles from users which help developers create patches are very rare. > And those users are usually capable enough to add debug patches. > Given these experiences (which may be different in other subsystems), I > don't see why we should carry the bloat. Yup, adding some printk()s while debugging is pretty much inevitable, and having full debugging available would add a lot of code, regardless of the subsystem. > That said, I'll leave the final decision to the driver maintainers. Agreed.