Received-SPF: pass (google.com: domain of linux-kernel+bounces-143629-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 13 Apr 2024 04:31:26 -0400
From: William Breathitt Gray <wbg@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] gpio: sch: Switch to memory mapped IO accessors
Message-ID: <ZhpC3lLD-BHqJEZz@ishi>
References: <20240410072102.1200869-1-andy.shevchenko@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="d/IvkqaW6ax31Foy"
Content-Disposition: inline
In-Reply-To: <20240410072102.1200869-1-andy.shevchenko@gmail.com>


--d/IvkqaW6ax31Foy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 10:21:02AM +0300, Andy Shevchenko wrote:
> Convert driver to use memory mapped IO accessors.
>=20
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Acked-by: William Breathitt Gray <wbg@kernel.org>

A minor suggestion below, but I find this patch accepted as-is.

>  static int sch_gpio_probe(struct platform_device *pdev)
>  {
> +	struct device *dev =3D &pdev->dev;

In general I think this is a good variable to define to simplify all the
&pdev->dev appearing throughout this callback, but I'd rather have seen
it as its own patch so we could change all the other uses of &pdev->dev
at once without distracting from the memory-mapped I/O change of this
particular patch. Not really necessary, but maybe at some point in the
future a follow-up patch doing such a cleanup would be nice.

William Breathitt Gray

--d/IvkqaW6ax31Foy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZhpC3gAKCRC1SFbKvhIj
Ky0kAQDUwdQ4ta2t1mSTRTCD2R1i1TroJSyem81dRGJsBgFClQEAivISTvpcs3gq
w5sOoWbOz8Ij4TChn9SnPje/ioR81w4=
=MCt1
-----END PGP SIGNATURE-----

--d/IvkqaW6ax31Foy--