Received-SPF: pass (google.com: domain of linux-kernel+bounces-143643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID:
 <MA0P287MB2822087FAA743D612EC7C110FE0B2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Sat, 13 Apr 2024 17:03:53 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] riscv: dts: sophgo: use real clock for sdhci
To: Inochi Amaoto <inochiama@outlook.com>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Paul Walmsley
 <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>,
 Albert Ou <aou@eecs.berkeley.edu>, Jisheng Zhang <jszhang@kernel.org>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <IA1PR20MB4953CA5D46EA8913B130D502BB052@IA1PR20MB4953.namprd20.prod.outlook.com>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <IA1PR20MB4953CA5D46EA8913B130D502BB052@IA1PR20MB4953.namprd20.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN3P287MB2108:EE_
X-MS-Office365-Filtering-Correlation-Id: b624d2d3-4bb4-4c42-9129-08dc5b98a631
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CgLCLe3EcbyurMNhP44jzxFq3uIhXnusgzCF+dTmurI9yQIrCI63cFHXEB80Imflc+a7goBoFjet/B6GvydWfHCXhavtjPZvLLL4AS8+5Zx2IYCj4GtiR0F+1upMxAvUp/PxvFlb+DjbLNNxL6bRPWtxhTbOcpO1HiUBOJ2gNes6uW5KcVmIi0VmgmKhpllJ4ytnCzTTa2XinNfA0gQu4YD4/WYcMdNV+A0nA+uAxaAG8JJJzTo4mp1P1IkNTYGl0+KxeZcRWI/Ku3iPjtT73SgCc1aNxmYvPGc42jWrE7Xbbzk2SC3eM2tjl0F2tpqCFKGYyD6f+FT22LoY9ljJewLbqPcyD14AXpbz9FZd/Ml1CpdHXXvyz2Of5Oeuf2qDJ8+JDlE8xLPMI4vJ6oazGPBC3l9QNKqnm7EyhEEpdikWN9EuXhYJ9GfcJo9IUBFXYATBDbS2DPSWiMz53Yozo7gSO5blepzmu3iNOpH2m6pjAMfAhEYJVp9Tk5uHxb5IoCjrZkSWgZ7XiYwMbmtf476b1QFvNxdyXQt65wV2cESFgq5W3cwCPvXia7rZYl+X
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZTViZDFDMkp5VUJ5MVArSzcvRmdsanNKbTBZWFp5SnJuVFRlM3VQVUFBSklE?=
 =?utf-8?B?WGdxTHM0YVhBbnFlbFAxbWx5a2ZWMFF4WWgzK3MxYSs5cGdzVWpIL1JkbFNm?=
 =?utf-8?B?ZzczMDFraXVUU2VhYUVHQi9JeklWMStiNS9WWk5PZExUSWpLRmJObVpCRVRv?=
 =?utf-8?B?c205RWFHTVRLNmY0MWg0UnpRdWVHMWIwWDE1U1RmSEVub2U2R294M0lqbzI4?=
 =?utf-8?B?Smc5MEZkY1JPWDRWbTFWQW1OdGk2MUpCNStMN2NoL1JPb2lJU05EUVlER0NK?=
 =?utf-8?B?NFZWVDV1eklSOXRBV211SFhxcG1wMXRCUkw0aWRFNXhoOUxORnBKcHphMmE5?=
 =?utf-8?B?dFNNeVdUSWkvWGg2SzdlZUdyQkR5T3dvaWdFOFlCT3ptWGhVQnlBdFpkejJo?=
 =?utf-8?B?NVB6bWw0ZitlelFUZ1RzNTZZRHFGQ3VkbVRjdThVMGZIamw0bk1JTUJxeFEr?=
 =?utf-8?B?MlJQL1Fmdk5ZWlBzZWswclNiN0YxWlU3WkgyZWhXbzZQNzlGeGVXYi81MjNP?=
 =?utf-8?B?SFhidkEyM2tBT0twR0lnSG1MZHMrT2tUSlBPUzNpNFZHaUp0VXd2UWFidmFJ?=
 =?utf-8?B?SDBIQkREaW0zTHdpUjA4Tm90UXkzTmp0aWpMWGpyS3J1Q0RxVDArVTNEVVhW?=
 =?utf-8?B?bktjYWkwNDY3Uy9EMzRTOGdPT2JOUmp2ZER4Mmh1ek1lMEVtVmtTZGlFaVp5?=
 =?utf-8?B?TGk0SWZKRW92cDBkclUzYWdDcHJvb0wzdlBlSndTL1VnNys5SWVia3NTekh3?=
 =?utf-8?B?QTg0OTAwVVJsTlJUZFdVV1A2TGVIcFRlbmNWMFZITk51OEVlY2FNdTdiRFFz?=
 =?utf-8?B?bDU1TWQ4R1VBNnEvYmhxN2ErU0t0UUVZMjU4cU5sdXMyZmtXcEh2SDFaTTg2?=
 =?utf-8?B?cnJDTmxKa0hnY0J2RjMxVDVZdFpJd0U4SzZVeTRpZTV4TEh4d3JmSkxJTS9J?=
 =?utf-8?B?S2prYzBPQ3pVSDhNdUIxeXZ2a3FrZzNxVmhlTytlUTdGaDZxWTluKzYzRGg2?=
 =?utf-8?B?cnlpWmlXZHFHT2IwWFVac3dPM0F6SUdReFNaUVNNck9hTHlQeFd0Y0oyZ1lp?=
 =?utf-8?B?cUlSNnR2WHNudlNuV1UwS09xRHVyZ3FaMytHTStjM3V6RWQ1Y1hRendSL3Ix?=
 =?utf-8?B?dzl0WEovQmliM0dxTFdVbllYNmVaWlpka2ZMc3VocXlvcFdDT3o5SzIyTkg4?=
 =?utf-8?B?cmFDazR4MjFaWUJBR1pmSFBMb1dmblpvSFJKQitSQ3FTUStYdEdXWnBzOFla?=
 =?utf-8?B?K3pFeXY4OSsvd2hvUUlWaXgySXJwVzVjYm5JaU95OFVZMzRDWDJqckl3bHJW?=
 =?utf-8?B?T0pkdWZUSVRIZk1EWnVHOUJIWXNqakxPVFdndHczTVNzaWZaUHdJdDhCK3kv?=
 =?utf-8?B?RkJEZmFXaS9WOTlFUndRWmdsUE9pS0VsNjVaV2JWSXpEYStITlVGWEh5RkV1?=
 =?utf-8?B?YnJVdnNPL0NMdDdRNU5lYkdpVzJFa29qcXh2aFBTajNkaFFzeGczY29ySW9B?=
 =?utf-8?B?WkFDU2dadzBsdnNXY3p2MnUxNi9RQmR0L1lyVmhKaVRUWFoxbkxNQ1FXb3Fi?=
 =?utf-8?B?QUYyYUlNUWxyK3RRRHNQVS8rMnAvUll0ZlhKQWVXTGVEanM3VGY5V1lGZjdL?=
 =?utf-8?B?QjBaQmtESXlYT2hNZ2tXTHZOeTJFRm44ekZpVmlTNFBjNlZTanRmdDNyU1Zx?=
 =?utf-8?Q?KwRSqJSGTrkglBfb0Y7M?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b624d2d3-4bb4-4c42-9129-08dc5b98a631
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 09:03:56.2964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3P287MB2108


On 2024/4/11 20:21, Inochi Amaoto wrote:
> As the clk patch is merged, Use real clocks for sdhci0.
>
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> ---
>   arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 12 +++---------
>   1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 75d0c57f4ffb..891932ae470f 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -47,13 +47,6 @@ osc: oscillator {
>   		#clock-cells = <0>;
>   	};
>
> -	sdhci_clk: sdhci-clock {
> -		compatible = "fixed-clock";
> -		clock-frequency = <375000000>;
> -		clock-output-names = "sdhci_clk";
> -		#clock-cells = <0>;
> -	};
> -
>   	soc {
>   		compatible = "simple-bus";
>   		interrupt-parent = <&plic>;
> @@ -298,8 +291,9 @@ sdhci0: mmc@4310000 {
>   			compatible = "sophgo,cv1800b-dwcmshc";
>   			reg = <0x4310000 0x1000>;
>   			interrupts = <36 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&sdhci_clk>;
> -			clock-names = "core";
> +			clocks = <&clk CLK_AXI4_SD0>,
> +				 <&clk CLK_SD0>;
> +			clock-names = "core", "bus";
>   			status = "disabled";
>   		};

Reviewed-by: Chen Wang <unicorn_wang@outlook.com>

Thanks.

>
> --
> 2.44.0
>