Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp408438lqp; Sat, 13 Apr 2024 02:27:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWyaj4kK7kLxdaBKZ8hesnzOBWar5unIUIMmbSWmKJzIJe1AqyjaaqKuH/XWyZWj1yx08wASNAoX5b73poTkWG/hENVvIu2uBU2m4VzgA== X-Google-Smtp-Source: AGHT+IH2G555mj2D1bK22Yc5wvxuCY+fIRqaYX1EoGIsKSOGP6yF3eKQiheIyJZRHmVpJ/kzL0dK X-Received: by 2002:a17:902:d58b:b0:1e2:1915:2479 with SMTP id k11-20020a170902d58b00b001e219152479mr5357409plh.12.1713000465469; Sat, 13 Apr 2024 02:27:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713000465; cv=pass; d=google.com; s=arc-20160816; b=d11LcoatgFTKn2sRivGMQSQg+YbURmRNCV8MLf/k0301DF0Eg/q4U2Odo6OQIQDpEt tD/gnAa6PEBsXr8RFqikGU86B2mLzU4FG9SyHxy6/+b1h8xRVhwN69wD+B4Rowkesv8d AbSKdWEMEwU1JZfesHIBawiuKadb07eHCvtnGclm/xZLAFiTnWse3mLPRM6vItdIJhAI oIKv37+mqd0TJV8cB4C/AdUl1Lht1zFCF5DiPd58Bu4RLV+J3yEczp1bELSN8OvrSTA6 ApUmMTzvp+VBCqnkcRSIuo16dYklnemO/KrHRldJ7110tAHS/82DIam+14OyRpBoMZa9 mv6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=B+IbTSl4mX32ESTPFuaSXbOS4c6uPDs8J155ji41rKk=; fh=1e6Cal33cWE5JW5ba8MF9Y9+aH2IllmjHRaK99oBic4=; b=OGTqxk+FAOYfWN953FADQYxnE2z7nPlUHZbCnjyQtZAOQvf3KcQ36RiaaYb75L1Ags TsBTfrJnapffxnwODYzcVK/S2UoCzmG81IchD8gah6Qddc0DcGa8VeNC9eaxS6zckJjy iCKUiPAl9iIEPIrsBcaRTjCGQDU+46xhSqwrjsBwVh5T4VWthSySyJNRaaCAkYi5o9bN 7lTB5RcIjSYekvu9ubClGNFWLr03ARksLTJzbZSjzJAPGTDkZhUwgkdm0UkZuiwk4was OT6zqjEjKYNYx84vwApm+Qo6WtOfoqUAIw+TUOg8FahW6gBePVbMpOUu7pP+8H0XQ3Qv 6OCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b9Hn57IX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-143650-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143650-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id mf6-20020a170902fc8600b001e27011a183si4762901plb.22.2024.04.13.02.27.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 02:27:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143650-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b9Hn57IX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-143650-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143650-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2FE5BB21A49 for ; Sat, 13 Apr 2024 09:27:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2BAAA2C870; Sat, 13 Apr 2024 09:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b9Hn57IX" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E68218B14; Sat, 13 Apr 2024 09:27:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713000451; cv=none; b=cigDI8fwjEBY+ENRke5uvxvC7zWcTs7SjYhry4uhx6dfamSAKH1AN/04xbl7LTrD9rlI+3PoGvxE+tazrTBreaxhPHgmoqBsOtiGyeNcwkUJJlkUbK/dOxQ8opMKCGQ7ususN6U0K12qbTMZWE01rSKZ79bxbRK5qoPkCB1yYPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713000451; c=relaxed/simple; bh=8FmkxRB0I6lztwgCbDGCSRZG9dB3qR5SIonDflggVww=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=thiaVFUBXXckpyVDIFarEFCDpKkleFsaR1P35cwOFqiXZEFp1HZMC+8uYvi9x3jBAWhgosqi26Ke2PM7DtIEHDRL8cdcfZ2ZB/OLDIXosEOpdyej2osgHWs7+0W38qsWHxJMb5Cv2ADjuGI0ettx/ZTnUMIVC5iK0uUl3w/vOYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b9Hn57IX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CB09C113CD; Sat, 13 Apr 2024 09:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713000450; bh=8FmkxRB0I6lztwgCbDGCSRZG9dB3qR5SIonDflggVww=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b9Hn57IX/VvTNUy9obuO8zlFnX+pRlFGrpvIqioTwwuScVCBVb5ogzv9pvoWuvVgg CdEXKW5u345k2qQWe01PwyguqSgOt41OMYFyGmYKAxuo1rGXj4rZaNOPMgpq0Czysc wTg+hO8PZMXlaWPGA/ObXguuOdsf/PB08UOazC6pKcfIVrkzggdYDZajDaqUyKHqLg A2EtU63HpGI7phjtOvR2FFPJWHpuUocLhSy9+Ik/2KFPO7rfW/RbCGrl3dhZRTJslp NENuo2+7vFLdbaAkEkqOIkNXZQTBGmTt9NVuNZQBGNnAiT18MveFHS938SosRb7dJL rHDrVDzwbTasw== Date: Sat, 13 Apr 2024 10:27:17 +0100 From: Jonathan Cameron To: Thomas Haemmerle Cc: joel@jms.id.au, bsp-development.geo@leica-geosystems.com, Eddie James , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] iio: pressure: dps310: support negative temperature values Message-ID: <20240413102717.1ad05f7e@jic23-huawei> In-Reply-To: <20240410103604.992989-1-thomas.haemmerle@leica-geosystems.com> References: <20240327084937.3801125-1-thomas.haemmerle@leica-geosystems.com> <20240410103604.992989-1-thomas.haemmerle@leica-geosystems.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Apr 2024 12:36:00 +0200 Thomas Haemmerle wrote: > This patch set fixes the reading of negative temperatures (returned in > millidegree celsius). As this requires a change of the error handling > other functions are aligned with this. > In addition a small code simplification for reading the scale factors > for temperature and pressure is included. One quick process thing. For IIO (and probably most of the rest of the kernel) we strongly discourage sending new versions in reply to a previous version. The only real result is that in a typical email client the threads become confused and the new version may be missed entirely. Just sent a fresh thread - the naming makes it easy to connect new versions to older ones and tools like b4 deal with this automatically. Jonathan > > --- > Changes in v2: > - include fixes tag > - Split up patch > - introduce variables for intermediate results in functions > - simplify scale factor reading > > Thomas Haemmerle (4): > iio: pressure: dps310: support negative temperature values > iio: pressure: dps310: introduce consistent error handling > iio: pressure: dps310: consistently check return value of > `regmap_read` > iio: pressure: dps310: simplify scale factor reading > > drivers/iio/pressure/dps310.c | 138 +++++++++++++++++++--------------- > 1 file changed, 77 insertions(+), 61 deletions(-) > > > base-commit: 2c71fdf02a95b3dd425b42f28fd47fb2b1d22702