Received-SPF: pass (google.com: domain of linux-kernel+bounces-143671-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 13 Apr 2024 12:12:56 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>, Puneet Gupta <puneet.gupta@amd.com>, 
	Nipun Gupta <nipun.gupta@amd.com>, linux-kernel@vger.kernel.org, 
	Abhijit Gangurde <abhijit.gangurde@amd.com>, kernel@pengutronix.de, 
	Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Subject: Re: [PATCH] cdx: Convert to platform remove callback returning void
Message-ID: <wyt4jvdvbq4wrgxslwkdeg3e6mhjtfue4xwdec7sil3whhromv@57xjgduvont7>
References: <5d40f57e978bcce003133306712ec96439e93595.1709886922.git.u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="s3i7kmvt6klw55wa"
Content-Disposition: inline
In-Reply-To: <5d40f57e978bcce003133306712ec96439e93595.1709886922.git.u.kleine-koenig@pengutronix.de>


--s3i7kmvt6klw55wa
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Greg,

On Fri, Mar 08, 2024 at 09:51:05AM +0100, Uwe Kleine-K=F6nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>=20
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

we just talked in irc about this thread that might have fell through the
cracks on your side.

Thanks for reconsidering to apply it for v6.10-rc1,
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--s3i7kmvt6klw55wa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYaWqcACgkQj4D7WH0S
/k42XAf+L94X/O0zykfTHe+CVju3dQcPIDr2btWJmpUSedAQdec4cmTn1IL2O4PU
UKS1sgvdO1Qid0qVJHrsEcZrFzeVOAxU9PEkKNl0G35iF3Ku3M8Rz1NJoSQrWjU7
J0m+4rbd8ZbWRcMMr4q+EOXa09QB508899blAXP+zV729MKnskvjhfWkuIlfPMFK
eayd3cv6MF1LGnq0/XgoB99enlGH9DJeucdSC8F+zVMxRHkU/ni1UJNVSMWmxZ4x
3ri8rjDAsd9cKn7De4AOdkjoTcLuTyP3Q06D6e5eFzyeuO5JMNGd1LUhC5i2r/bD
S1wLHuY50mgFlhRzEBZciME1rX6HLg==
=tSsa
-----END PGP SIGNATURE-----

--s3i7kmvt6klw55wa--