Received-SPF: pass (google.com: domain of linux-kernel+bounces-143685-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 13 Apr 2024 12:41:21 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>, Puneet Gupta <puneet.gupta@amd.com>,
	Nipun Gupta <nipun.gupta@amd.com>, linux-kernel@vger.kernel.org,
	Abhijit Gangurde <abhijit.gangurde@amd.com>, kernel@pengutronix.de,
	Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Subject: Re: [PATCH] cdx: Convert to platform remove callback returning void
Message-ID: <2024041316-unwrapped-parchment-88d8@gregkh>
References: <5d40f57e978bcce003133306712ec96439e93595.1709886922.git.u.kleine-koenig@pengutronix.de>
 <wyt4jvdvbq4wrgxslwkdeg3e6mhjtfue4xwdec7sil3whhromv@57xjgduvont7>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <wyt4jvdvbq4wrgxslwkdeg3e6mhjtfue4xwdec7sil3whhromv@57xjgduvont7>

On Sat, Apr 13, 2024 at 12:12:56PM +0200, Uwe Kleine-K?nig wrote:
> Hello Greg,
> 
> On Fri, Mar 08, 2024 at 09:51:05AM +0100, Uwe Kleine-K?nig wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> > 
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> > 
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> > 
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> 
> we just talked in irc about this thread that might have fell through the
> cracks on your side.
> 
> Thanks for reconsidering to apply it for v6.10-rc1,

Now applied, thanks.

greg k-h