Received-SPF: pass (google.com: domain of linux-kernel+bounces-143691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 13 Apr 2024 11:50:55 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>
Cc: Dumitru Ceclan via B4 Relay
 <devnull+dumitru.ceclan.analog.com@kernel.org>, dumitru.ceclan@analog.com,
 Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Rob Herring <robh@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, David Lechner <dlechner@baylibre.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] iio: adc: ad7173: fix buffers enablement for
 ad7176-2
Message-ID: <20240413115055.4f7a5892@jic23-huawei>
In-Reply-To: <05ef3e35-1ce0-48c4-9517-e8c1280cf96d@gmail.com>
References: <20240401-ad4111-v1-0-34618a9cc502@analog.com>
	<20240401-ad4111-v1-2-34618a9cc502@analog.com>
	<20240406155646.694f710b@jic23-huawei>
	<05ef3e35-1ce0-48c4-9517-e8c1280cf96d@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 8 Apr 2024 19:40:26 +0300
"Ceclan, Dumitru" <mitrutzceclan@gmail.com> wrote:

> On 06/04/2024 17:56, Jonathan Cameron wrote:
> > On Mon, 01 Apr 2024 18:32:20 +0300
> > Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel.org> wrote:
> >   
> >> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> >>
> >> AD7176-2 does not feature input buffers, enable buffers only on
> >>  supported models.
> >>
> >> Fixes: cff259bf7274 ("iio: adc: ad7173: fix buffers enablement for ad7176-2")
> >> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>  
> > How bad is this?  If you can find out if writing those bits does anything
> > harmful (they are reserved and datasheet says should be written 0 I think)
> > That will help people decide whether to backport the fix?  
> 
> The bits are marked as read-only and there does not seem to be any effect on the ADC.
> So drop this one?

Patch is good as makes the driver more consistent, just drop the Fixes tag so we
don't end up backporting this.  That is basically treat it as code improvement
rather than a fix.  Add a note on the bits being read only so this not fixing
a bug, just an inconsistency.

Thanks,

Jonathan