Received-SPF: pass (google.com: domain of linux-kernel+bounces-143705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sat, 13 Apr 2024 12:23:30 +0000
From: Thomas Kuehne <thomas.kuehne@gmx.li>
To: jikos@kernel.org, bentiss@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] HID: hid-debug: more informative output for EV_KEY
Message-ID: <Zhp5QlMGazcW+RV5@black>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
UI-OutboundReport: notjunk:1;M01:P0:OTqW0KqRI0A=;ve9dM0XsXOdiUM0XSwr9KaqU5TQ
 RzbwYEn0wWgsSBg6lwaeXT+xiaqlDcLPXdI6NkQOp8Z8E+m8UDsMcjnFHCPDrqIqKYa4iNedD
 0g/RHrLGGPYgq307r+lsGdhjg4WgAsMgOeb9fdcFVHrAI5n9ciWV0w/X4uz4h2VdpW8BBzUOI
 AwhOBi/uk2V8Ekk9pNLbvoA1ZtW9CyCyRdzchmOUYK73/dcQkalIRayo05ltNshR3hMqhuIEy
 bf3l0+y5sth9QRO6ONsQq+HFgycyXJyglC35BzWFC3GcHXdD80QMW+AxR4bP93oAOT7CCHOo7
 X555vL33rFKWCNGlc/WeKuRCk2SKv2PQyMOyBRLJdnVcfUZap7P4lqPAoHzIiGzP3elnaziZv
 AaGnFYeNNoASP8HLkju16Q1aVNrO6ftB/mwapCE5iZq11V7yKBgl+8a23GdI3KnWyoH1NFGUD
 7GLu5gROaNJjfYb/e+6h0nFYMlHOyX8GFz9coshoH/fa0IC9XvOEXyMu6jp6sBcfPD4wMKUJK
 Cp4AkSpUyq7N+ElshWWNPYzNTew/I7kWCx98wWS/j/MszQvUiBHGWcPBMy2f+72tsFnz+b2l4
 80v6LhakDquMjqOd/SPpQXdQSElP34AAXrqS8aNVOVd45cw5lMBlVf/3mlIrM8nVHM4bLfHn6
 rwlJMeuyORnNCVEn0lkOMIMGFMTM1FgY3pBUUirzF+9BYYTb/bAU/ydWS6fPz52wxulgXPbn6
 dR4mJ5/K2+To5ORv5G9bBMrHrK7n/oebSpQQYwYIAXeIxDr40urwFqrE+4yeVgZPhuj9QdWMV
 bzN2PHb0PvWCkt6NpNJqVx0JLIzK+4UwSJ3d8d0bRORiA=
Content-Transfer-Encoding: quoted-printable

Currently hid-debug's hid_resolv_event prints questions marks for
all entries without explicit mapping information. This makes
debugging unnecessarily complicated as multiple different
keys may simply result in the same uninformative output.

Some common event codes are deliberately not defined in
input-event-codes.h. For example the 16th gamepad key.

Instead, print the hexadecimal codes for all events without symbolic
names.

Signed-off-by: Thomas Kuehne <thomas.kuehne@gmx.li>
=2D--
 drivers/hid/hid-debug.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index add353a17853..0a0c435a1284 100644
=2D-- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -3582,8 +3582,15 @@ static const char **names[EV_MAX + 1] =3D {

 static void hid_resolv_event(__u8 type, __u16 code, struct seq_file *f)
 {
-	seq_printf(f, "%s.%s", events[type] ? events[type] : "?",
-		names[type] ? (names[type][code] ? names[type][code] : "?") : "?");
+	if (events[type])
+		seq_printf(f, "%s.", events[type]);
+	else
+		seq_printf(f, "%02x.", type);
+
+	if (names[type] && names[type][code])
+		seq_printf(f, "%s", names[type][code]);
+	else
+		seq_printf(f, "%04x", code);
 }

 static void hid_dump_input_mapping(struct hid_device *hid, struct seq_fil=
e *f)

base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39
=2D-
2.40.1