Received-SPF: pass (google.com: domain of linux-kernel+bounces-143722-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 13 Apr 2024 13:31:29 +0200
From: Etienne Buira <etienne.buira@free.fr>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC][resend after bogus] gpio-syscon: do not report
 bogus error
Message-ID: <ZhptEWb7tD5pummq@Z926fQmE5jqhFMgp6>
Mail-Followup-To: Linus Walleij <linus.walleij@linaro.org>, brgl@bgdev.pl,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <ZhgDCKhcHdwGoJ4Y@Z926fQmE5jqhFMgp6>
 <CACRpkdbTdGajQLSGDkD0cWRG+79tpojYkdyF3t0jD7_WEDtQLw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdbTdGajQLSGDkD0cWRG+79tpojYkdyF3t0jD7_WEDtQLw@mail.gmail.com>

On Fri, Apr 12, 2024 at 12:44:34PM +0200, Linus Walleij wrote:
> Hi Etienne,
> 
> thanks for your patch!
> 
> On Thu, Apr 11, 2024 at 5:35 PM Etienne Buira <etienne.buira@free.fr> wrote:
> 
> > Do not call dev_err when gpio,syscon-dev is not set albeit unneeded.
> > gpio-syscon is used with rk3328 chip, but this iomem region is
> > documented in
> > Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml and
> > does not look like to require gpio,syscon-dev setting.
> >
> > Signed-off-by: Etienne Buira <etienne.buira@free.fr>
> > X-Prefers: kind explanations over rotten tomatoes
./..
> So indeed the parent is a sycon, and syscon_node_to_regmap(np->parent) will
> be used to populate priv->syscon on RK3328.
./..
> if (!has_parent_syscon) {
> (...)
> 
> What do you think about this?
./..

Hi Linus,

Thanks for your review.

IIUC, that would prevent calling dev_err() if, for example,
gpio,syscon-dev were forgotten from
arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi, dspgpio0 node although
it is needed and would result in funny things without notice.

Thinking twice about it, a cleaner way looks to add gpio,syscon-dev node
to rk3328.dtsi. I'll send the one-liner to relevant people (that would
be really easier if there were only one repo, with different
branches...).

Do you agree?

Regards.

Note: I'm not subscribed to list, so please To or CC me.