Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp512665lqp; Sat, 13 Apr 2024 06:57:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWOq0gyw9HxrKepNL8MxPGxxaeCz8FXDN8JJFRTKAI686D2Ebam9ptKtSdRF/2/ogpF7Is3sJ/HrovOfxZfJwZGfnhsi9bzv6li7m5Ksg== X-Google-Smtp-Source: AGHT+IGlTyayH3nMIJgNql7uKmUx+YzFDsmkiSQ+jh0ddeYPQ120QC/XybwS5AE2Yhhysa9CA5Pk X-Received: by 2002:a05:6512:b92:b0:518:872f:e4d with SMTP id b18-20020a0565120b9200b00518872f0e4dmr3988667lfv.15.1713016659569; Sat, 13 Apr 2024 06:57:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713016659; cv=pass; d=google.com; s=arc-20160816; b=A8DdLHMDtJbriT3sHa2u5RtTCp1G+sMX/cnEN3IUw4IG0rlGwGyGz5ZDH6jPAaYLzw a6Rzs+3PNJECVJzO5LtbtYn8e+MmPBJATUs+LgYhVnCGgbKLQ1fXPWFeBp2Scd7GOfyy 4WBhppKvEtPeJgZDqyBzHcZzRycIqu/MBJJYffX+faSFlVsdRIEFlHB24FPpxAUj4w3w M7vsugBf/4nhhKZTEfvXSJ9MjS+9DGTDlnTKI+Fk4Cr8WV9RDI06Q1aWy9TuvCF51Oz2 gKZFJeHXACoLwy6EYn1bm7kELk0HWzKsHvEkFR3Fr37j6wW1jQB2Itx9umSX1aEULbf9 FoOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:mail-followup-to:message-id:subject:to:from:date; bh=gQrxHC832RqZp2kzuVYfU7YoWVcXKxz47hLT2Gx4baE=; fh=WDyvNO8lWeDOdI3vmeXwqzM/84OyC3cifgmzUwq+FvA=; b=be/vwqG0RI4yhiZwx6NBEkDwGNVG78RuItG+2Q/KHD4q2EPjjbzCu8tsmhHIsHw5QB HvnVbRtgxp8tOEeHesPhVR2I3aog8GanzdKLNfEEpYk1lRpwrsNrGctaoCWpYXzENvPl SilZmUm/sknsD0rXwIicMRwXnWkqXeutqjqILZ7b6oLZV+9/p46kCe0gZRc8R2JZuZoi wigEgogotUZqV7M4HA7BM69JraMO8FMFhSXAtSP5CbFOwqwoOgN6hTYowgl+xBFV2pYq jq1m4qvTECuRIhl//RDPg01a4PI0BcJtUb+p8eVVzn7H8ytgLYMmavP4UHMXc2qcGVxO bTHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=free.fr dmarc=pass fromdomain=free.fr); spf=pass (google.com: domain of linux-kernel+bounces-143742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143742-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=free.fr Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id dc12-20020a170906c7cc00b00a46b291e5d7si2621513ejb.904.2024.04.13.06.57.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 06:57:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=free.fr dmarc=pass fromdomain=free.fr); spf=pass (google.com: domain of linux-kernel+bounces-143742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143742-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=free.fr Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4B4201F21C0D for ; Sat, 13 Apr 2024 13:57:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C7A57446AC; Sat, 13 Apr 2024 13:57:29 +0000 (UTC) Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842DF1DFF4; Sat, 13 Apr 2024 13:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.27.42.2 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713016649; cv=none; b=qcui/jdDdyD1+gHUF9EDbCOnG0XWI9cytLOMAvfRnahmyahNp5k8V0WbNzuDlD6eo0iV2QpipOpQaRMIOQWqoCEUamUNTIGOVA0NtL1P35Id0MaRgFdQKFdLKBmpsUMlINHeLaWnrc6fXHzx9S9bjt6qqa+siJ3fd1L6uZK4Rcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713016649; c=relaxed/simple; bh=qawpc/DTqLcugOlpFIlyHOPojCNwyUlB8c5oN7kOICo=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=loQHW2sIRi8f6MMh83WICXB19R6ydQxRhtRFR3wCbgwjiydnGJ8zgMtrjsyLihxEfCPTONlfTo9R2qvb0c8q4K/xY/PQuIsvAYVAaMVFu/R+ynSyDnO97DsKPM5OSknP1iPdTmQt98NbtuZUfNXm5h9y5ufPe6TCz+dKSY8hWbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=free.fr; spf=pass smtp.mailfrom=free.fr; arc=none smtp.client-ip=212.27.42.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=free.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=free.fr Received: from localhost.localdomain (unknown [82.64.135.138]) by smtp2-g21.free.fr (Postfix) with ESMTPS id BA8FE2003C8; Sat, 13 Apr 2024 15:57:01 +0200 (CEST) Received: by localhost.localdomain (Postfix, from userid 1000) id 5423D40039; Sat, 13 Apr 2024 15:56:08 +0200 (CEST) Date: Sat, 13 Apr 2024 15:56:08 +0200 From: Etienne Buira To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Johan Jonker , Dragan Simic , shironeko , Etienne Buira , Jonas Karlman , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] Avoid error message on rk3328 use Message-ID: Mail-Followup-To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Johan Jonker , Dragan Simic , shironeko , Etienne Buira , Jonas Karlman , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline rockchip,rk3328-grf-gpio is handled as syscon, but syscon mandates presence of gpio,syscon-dev node (or it will call dev_err() when probed). Correct rk3328.dtsi and related documentation to follow syscon's expectations. Signed-off-by: Etienne Buira --- .../devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml | 2 ++ arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + 2 files changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml index d8cce73ea0ae..2c878e7db900 100644 --- a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml @@ -38,6 +38,7 @@ required: - compatible - gpio-controller - "#gpio-cells" + - gpio,syscon-dev additionalProperties: false @@ -47,4 +48,5 @@ examples: compatible = "rockchip,rk3328-grf-gpio"; gpio-controller; #gpio-cells = <2>; + gpio,syscon-dev = <&grf 0 0>; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index b6f045069ee2..fd25d5bee19f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -296,6 +296,7 @@ grf_gpio: gpio { compatible = "rockchip,rk3328-grf-gpio"; gpio-controller; #gpio-cells = <2>; + gpio,syscon-dev = <&grf 0 0>; }; power: power-controller { base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23 -- 2.43.0