Received-SPF: pass (google.com: domain of linux-kernel+bounces-143751-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 13 Apr 2024 16:35:06 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Heiko =?utf-8?Q?St=C3=BCbner?= <heiko@sntech.de>
Cc: Dragan Simic <dsimic@manjaro.org>, linux-i2c@vger.kernel.org, 
	Andi Shyti <andi.shyti@kernel.org>, linux-arm-kernel@lists.infradead.org, 
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts
Message-ID: <dnh4yiajjqcxcq7xjvj35quda7yrf7tubp2l2ktsaf4zgzai4n@xdefxkk76yyg>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Heiko =?utf-8?Q?St=C3=BCbner?= <heiko@sntech.de>, Dragan Simic <dsimic@manjaro.org>, linux-i2c@vger.kernel.org, 
	Andi Shyti <andi.shyti@kernel.org>, linux-arm-kernel@lists.infradead.org, 
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>
 <hgdhrf2jiovfxcppdtsq32sfbk4xuq7ewiwq4awwztj4mp3yez@kj6ixihkcxhe>
 <af8ac48f10a1636ab2486aef91e01c3f@manjaro.org>
 <8358604.T7Z3S40VBb@diego>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3rm5ajlyb22bpc7l"
Content-Disposition: inline
In-Reply-To: <8358604.T7Z3S40VBb@diego>


--3rm5ajlyb22bpc7l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


> Also we're talking about two lines of code, I wouldn't call that bloat ;-)

With this patch, yes. But once you allow debug code, it is hard to draw
a line which debug is still okay and which is too fine-grained. And then
you end up with a lot. Over the years, I developed the tendency to try
to have less but meaningful error printouts. But I don't enforce it
strictly because it is too much bike-shedding discussion.

In case of this error printout here, it is just wrong. But, see, it also
came from this tendency I don't like to have printouts for every error.


--3rm5ajlyb22bpc7l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmYamBoACgkQFA3kzBSg
KbZ5mQ//Sz4z/OJ/HyrUnuAtL6eJjBPkhIyxgjlxGgFSZ7sPECcUBR6Y0itNh20D
LVMfF3XdU05v1wHMbmysTKBje3SdNsBMhLpM4hYXC65CLyO9mlPGeath+W0yMtGR
DQIaItYs4WssxmRd9C9gbi9XDINsMq8JfSccPtVgFqWMXowYtnJHc+y9ykMH65R0
YT9X05NYGdCd9aNEfyDDb6I4t4S3v3p20/va00L/jfaQubpoTomDfuhtOGy04cQn
xzT1PAdTR6HPLN+2Nl0FUHMUhO1GaJzsn5MT5XSuuHzIgQ+d4zrVzfPXziP1fJP8
jsR/FMHBc7uhFtinY5YW+8DURLwA6zwe8pGNvuf5StFfGQK8MIefDH6cIOz4c3y1
xCbz9B7a/dOKB6Q8VkFLgvEC2Uxcj8J0klrG1vuxAtqTig30dm/zJO44gi9luivY
mUdkrCF6JDQlBuWdyku1U26vGbUZq/y5x3xLU++BkuaDBRQNyBo9rZi5up+FhZTe
rsRKO+Ey5ils8d1zyElAnaUylSoMrFlMpTb7IATzM4+v59+T9kCv1DL2cOrYJKb2
NU+Mp6yjYXAmK8fP/OJzO/7FzMlS7nxGue1XKaTH2NNM9Dq/SEvQIU5JZKJs27MJ
oYVVlVRo2cXhZIZ6Yfo9WvO91vYe9lWTxl2+MIJKhs9dhzNlTYo=
=I1ij
-----END PGP SIGNATURE-----

--3rm5ajlyb22bpc7l--