Received-SPF: pass (google.com: domain of linux-kernel+bounces-143836-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 13 Apr 2024 10:42:07 -0700
From: Yury Norov <yury.norov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Kyle Meyer <kyle.meyer@hpe.com>, linux-kernel@vger.kernel.org,
	linux@rasmusvillemoes.dk, mingo@redhat.com, peterz@infradead.org,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
	mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
	russ.anderson@hpe.com, dimitri.sivanich@hpe.com, steve.wahl@hpe.com
Subject: Re: [PATCH v2 2/2] sched/topology: Optimize topology_span_sane()
Message-ID: <ZhrD6NLFU1X6F/74@yury-ThinkPad>
References: <20240410213311.511470-1-kyle.meyer@hpe.com>
 <20240410213311.511470-3-kyle.meyer@hpe.com>
 <Zhe9ttm9Ppv2wT3S@smile.fi.intel.com>
 <ZhhcPwFCgxDUhndo@DESKTOP-IR8JFSN.>
 <ZhlEVoW6FJC6uBVE@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZhlEVoW6FJC6uBVE@smile.fi.intel.com>

On Fri, Apr 12, 2024 at 05:25:26PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 11, 2024 at 04:55:11PM -0500, Kyle Meyer wrote:
> > On Thu, Apr 11, 2024 at 01:38:46PM +0300, Andy Shevchenko wrote:
> > > On Wed, Apr 10, 2024 at 04:33:11PM -0500, Kyle Meyer wrote:
> 
> ...
> 
> > > > Since topology_span_sane() is called inside of for_each_cpu(), each
> > > > pervious CPU has already been compared against every other CPU. The
> > > 
> > > previous
> > 
> > Thank you for pointing that out. Should I send an updated version or can
> > a maintainer correct my mistake?
> 
> Depends on the maintainer. I'm not the one here, don't expect answer from me.

I like this rework, and I'll take it in bitmap-for-next for testing.

I see Vincent already acked it, so I can also move it upstream, if no
objections from Peter, Juri and Ingo.

Thanks,
Yury