Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp621933lqp; Sat, 13 Apr 2024 11:18:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUh9I8oEz4Kf6+sJE7mzIL/U03pHRuzn4BA8Dww/eBcQlVsOjNS1b8u/sNzq5Q07VQ+dljgiR0UugfswGsv5bUWdLk+oZpR81Oim+jW2w== X-Google-Smtp-Source: AGHT+IHAQDxvOo4pHmiuWo/4aLakX2RCe4U4lMIVAggs9AUXuROG0bsftOd0tRP63N9H8I4FA7Kc X-Received: by 2002:a17:907:9411:b0:a52:5676:2ff0 with SMTP id dk17-20020a170907941100b00a5256762ff0mr565781ejc.52.1713032283708; Sat, 13 Apr 2024 11:18:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713032283; cv=pass; d=google.com; s=arc-20160816; b=I8ZXsoMOoqcjsm5NxhBTO7Tfb6lEzqVc+NWeCcyfFcuLV9Stmn9sE+67zmNvAPdfwG BJ9Zg6TUXeED+c9FWRScGwxFgqdA34tRMGM1vESVH6PEPYpSnKszZQYYiT0a23oswUeE 9MXDqc+a/PMNBN/NLeGlrL+iFKEEpFSScCll2vafrb9QV+UZG39SeWrZM+KlQhUF8qET n9zCPqhNaT6uRwTOzvpT+l8FbD/HP9OqnMYo1WU40FsgsEvLa73s1i6+b+kqZXlFjlmj Eve188VBeZcRlRPL1+KfczRC10vAXyM37rdMai2gkZ1UV8VxYd2thsYLT86E47v4hDiF kSeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=FIGcdSTY9Oi1o9OOgFV+OcIbqMI7VOF8A83lrbI6TpU=; fh=E+zUzf7pysoGxr3Q06JJSkKLGfqtBXv4vkqSG6AJe8w=; b=i9F/+l03yjygV8bDN4Cq/SKhVsjwms6lGskNM7bSdgof4ien2s5lgUqJN1uxsl1u94 uTGqjCXCUy0gwLW5hn2ro1OQEHZXHQhvTBVq0JgDVO2TAD8XoHBtjMddEsxDqzZ8c9Zg kSUszIWqfezOh9M1hTC4KDba2F9PIy6lQoxdmbeqmLvhSK/GBmiWCoRAH68k1qX7mh9I +TsImQDc6yxxMWWh68ozVcpr7rlj7KK/ms2wDsMlewty+bpUEpsR4zDTxLKfJ5iRqiLN zyBN91b1/sa0IDw3b++n2kp7vIw/HUS54jpUW06gK6zJ3nTggZ6y1uOyQNnqKqu/Oqaq 4OSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=easystack.cn dmarc=pass fromdomain=easystack.cn); spf=pass (google.com: domain of linux-kernel+bounces-143839-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143839-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gr3-20020a170906e2c300b00a523cce6d16si1511598ejb.391.2024.04.13.11.18.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 11:18:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143839-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=easystack.cn dmarc=pass fromdomain=easystack.cn); spf=pass (google.com: domain of linux-kernel+bounces-143839-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143839-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 674A81F21847 for ; Sat, 13 Apr 2024 18:18:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6EB153365; Sat, 13 Apr 2024 18:17:52 +0000 (UTC) Received: from mail-m17246.xmail.ntesmail.com (mail-m17246.xmail.ntesmail.com [45.195.17.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1089C405F7; Sat, 13 Apr 2024 18:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.195.17.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713032272; cv=none; b=b9IYhTwpGqs3iAdZ48h9adFWi6Z7h7lCo2zNqU9a9/x7FxgrZOeHk4R7+xPDsTNZD6byxBlMNj3UM1p35Gy+r6xrK7Du+UB0MnoblUDqAGl02+KtIcaZgyMYC0CigYe7yT5SmBB/r7ToWVVtsUT0aPh7kNPg6Q0l8a2YQOynSW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713032272; c=relaxed/simple; bh=Mw0Udc146w+DJVcHuKpu3Yw25YQxQGimARuVph8en5M=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hLkHble++1EhLYGajoNjLf/m3lC7f98k2/wIDhhq3N45/0QNA48bwR4CQz5ssThM/IQjzD38NHmDgyiBHu4JxKu1DmbGHFtLIn7gR3iibcE2d1/nxCETSrWdf8mWKkTwv10I42JrdqnLbbsVvIAhfCzLSU4xhM3Iy8JRT5cb/h4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn; spf=pass smtp.mailfrom=easystack.cn; arc=none smtp.client-ip=45.195.17.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=easystack.cn Received: from localhost.localdomain (unknown [IPV6:2409:8a62:79b:ed10:24be:fa63:4b9b:ba6e]) by smtp.qiye.163.com (Hmail) with ESMTPA id 34398560169; Sat, 13 Apr 2024 16:48:54 +0800 (CST) From: "jun.gu" To: pshelar@ovn.org Cc: netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org, "jun.gu" Subject: [PATCH] net: openvswitch: Check vport name Date: Sat, 13 Apr 2024 16:48:26 +0800 Message-Id: <20240413084826.52417-1-jun.gu@easystack.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVkaTUNMVk9OGh1MH0gZHUxLTFUZERMWGhIXJBQOD1 lXWRgSC1lBWUlPS0JBQxpNSUFMQhlBHh9KS0FJTxkeQR0aTUhBTxlCGUEZGk0eWVdZFhoPEhUdFF lBWU9LSFVKTU9JTE5VSktLVUpCS0tZBg++ X-HM-Tid: 0a8ed6a53217023dkunm34398560169 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Py46Cxw6NzcwGS4NK0pONhUM NBkKCgJVSlVKTEpJQkJDSkhPTkNOVTMWGhIXVREOFVUcDjseGggCCA8aGBBVGBVFWVdZEgtZQVlJ T0tCQUMaTUlBTEIZQR4fSktBSU8ZHkEdGk1IQU8ZQhlBGRpNHllXWQgBWUFKT0JPNwY+ Check vport name from dev_get_by_name, this can avoid to add and remove NIC repeatedly when NIC rename failed at system startup. Signed-off-by: Jun Gu --- net/openvswitch/vport-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 903537a5da22..de8977d7f329 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c @@ -78,7 +78,7 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) int err; vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); - if (!vport->dev) { + if (!vport->dev) || strcmp(name, ovs_vport_name(vport)) { err = -ENODEV; goto error_free_vport; } -- 2.25.1