Received-SPF: pass (google.com: domain of linux-kernel+bounces-143871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sat, 13 Apr 2024 23:56:40 +0300
Message-Id: <D0JAMYT1JE4V.77DDGSKD7AL1@kernel.org>
To: "Huang, Kai" <kai.huang@intel.com>, "Mehta, Sohil"
 <sohil.mehta@intel.com>, "mingo@redhat.com" <mingo@redhat.com>,
 "x86@kernel.org" <x86@kernel.org>, "dave.hansen@linux.intel.com"
 <dave.hansen@linux.intel.com>, "cgroups@vger.kernel.org"
 <cgroups@vger.kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
 "tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
 "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>, "mkoutny@suse.com"
 <mkoutny@suse.com>, "haitao.huang@linux.intel.com"
 <haitao.huang@linux.intel.com>, "tglx@linutronix.de" <tglx@linutronix.de>,
 "tj@kernel.org" <tj@kernel.org>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>, "bp@alien8.de" <bp@alien8.de>
Cc: "mikko.ylinen@linux.intel.com" <mikko.ylinen@linux.intel.com>,
 "seanjc@google.com" <seanjc@google.com>, "anakrish@microsoft.com"
 <anakrish@microsoft.com>, "Zhang, Bo" <zhanb@microsoft.com>,
 "kristen@linux.intel.com" <kristen@linux.intel.com>,
 "yangjie@microsoft.com" <yangjie@microsoft.com>, "Li, Zhiquan1"
 <zhiquan1.li@intel.com>, "chrisyan@microsoft.com" <chrisyan@microsoft.com>
Subject: Re: [PATCH v10 08/14] x86/sgx: Add basic EPC reclamation flow for
 cgroup
From: "Jarkko Sakkinen" <jarkko@kernel.org>
References: <20240328002229.30264-1-haitao.huang@linux.intel.com>
 <20240328002229.30264-9-haitao.huang@linux.intel.com>
 <e616e520b021e2e7ac385b5b1c41febb781706de.camel@intel.com>
 <op.2lpq2mtswjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <0e406b207c7769359d45ba4e4594174e64ec3faa.camel@intel.com>
In-Reply-To: <0e406b207c7769359d45ba4e4594174e64ec3faa.camel@intel.com>

On Fri Apr 5, 2024 at 6:07 AM EEST, Huang, Kai wrote:
> On Thu, 2024-04-04 at 12:05 -0500, Haitao Huang wrote:
> > > > -static inline int sgx_cgroup_try_charge(struct sgx_cgroup *sgx_cg)
> > > > +static inline int sgx_cgroup_try_charge(struct sgx_cgroup *sgx_cg,=
=C2=A0=20
> > > > enum sgx_reclaim r)
> > >=20
> > > Is the @r here intentional for shorter typing?
> > >=20
> >=20
> > yes :-)
> > Will speel out to make it consistent if that's the concern.
>
> I kinda prefer the full name to match the CONFIG_CGROUP_SGX_EPC on case. =
 You
> can put the 'enum sgx_reclaim reclaim' parameter into the new line if nee=
ded:

Why don't cgroups for SGX get always enabled when SGX and
cgroups support are enabled?

BR, Jarkko