Received-SPF: pass (google.com: domain of linux-kernel+bounces-143899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 14 Apr 2024 00:49:45 +0300
Message-Id: <D0JBRMERS3G8.NJPPGQQU1E8R@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, "Peter Huewe" <peterhuewe@gmx.de>,
 "Jason Gunthorpe" <jgg@ziepe.ca>, "Rob Herring" <robh@kernel.org>,
 "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley"
 <conor+dt@kernel.org>, "Lukas Wunner" <lukas@wunner.de>, "Alexander
 Sverdlin" <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS
 binding
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>, "M. Haener"
 <michael.haener@siemens.com>, <linux-integrity@vger.kernel.org>
References: <20240413071621.12509-1-michael.haener@siemens.com>
 <20240413071621.12509-3-michael.haener@siemens.com>
 <8c13a349-a721-44d3-9e23-2e01f4c2ca4d@linaro.org>
In-Reply-To: <8c13a349-a721-44d3-9e23-2e01f4c2ca4d@linaro.org>

On Sat Apr 13, 2024 at 11:10 AM EEST, Krzysztof Kozlowski wrote:
> On 13/04/2024 09:15, M. Haener wrote:
> > From: Michael Haener <michael.haener@siemens.com>
> >=20
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
>
> A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
> prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree=
/bindings/submitting-patches.rst#L18
>
>
> >  Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml=
 b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> > index 3ab4434b7352..af7720dc4a12 100644
> > --- a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> > @@ -32,6 +32,7 @@ properties:
> >            - enum:
> >                - infineon,slb9673
> >                - nuvoton,npct75x
> > +              - st,st33ktpm2xi2c
>
> I got only one patch, but if these are compatible, why do you need
> second patch? Plus binding come before users.
>
> Please explain what are you doing in other patch.
>
> Best regards,
> Krzysztof

Thanks, I agree with the remarks. So holding for update.

BR, Jarkko