Received-SPF: pass (google.com: domain of linux-kernel+bounces-143977-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Chanh Nguyen <chanh@os.amperecomputing.com>
To: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Justin Ledford <justinledford@google.com>,
	devicetree@vger.kernel.org,
	linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
	Thang Nguyen <thang@os.amperecomputing.com>,
	Quan Nguyen <quan@os.amperecomputing.com>,
	Chanh Nguyen <chanh@os.amperecomputing.com>
Subject: [PATCH v2 2/3] hwmon: (max31790): Support config PWM output becomes TACH
Date: Sun, 14 Apr 2024 11:22:45 +0700
Message-Id: <20240414042246.8681-3-chanh@os.amperecomputing.com>
In-Reply-To: <20240414042246.8681-1-chanh@os.amperecomputing.com>
References: <20240414042246.8681-1-chanh@os.amperecomputing.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?m/eEWkSNbj5vSGMvdItkIXI7diJHoNCMVDLAbkZ1Iv4ik4PxM4O4Pp7rUlP6?=
 =?us-ascii?Q?WPOJiorXugHCW7ewibfjuosRyCq4LVY0Lqt93hhMsGMTmIAGic5+dbLn73PG?=
 =?us-ascii?Q?bSCwOyHESZSJYVoU6U7P0hrXNOGKtIuOmMznANehHxrSgBzy47j5Q4Hluzti?=
 =?us-ascii?Q?OKATxXtKzu4zImJFjzYtpj9vGsLEMMfqQjdp2VPUztUBL97scE6INiNxFeoz?=
 =?us-ascii?Q?T2ZY+TuLaz/PnL5kj+dJ7wm2Q0QE6Ua0zT5LYgE1s/sp73uk2RWUHL+zRYTc?=
 =?us-ascii?Q?eLs3ag52PLDRCLGQTdNPUnLeDHT2Kl6muZgT07yh+WNyUkJElOzK87vfsauO?=
 =?us-ascii?Q?o6xvs4LWYwJewXtyvHc/xtg4bW1e9kv3b3ITlULCJYj2omeBkj36+bBmXqhB?=
 =?us-ascii?Q?PAHNEeHtDZvyWK2tIthkSTGnzx7nqTkI7KZGJswBFOWiC3HL/mlqPFXI70tT?=
 =?us-ascii?Q?fmyOJjGo4bvDlUzH0O5IXpQhfHnH5Czsx1RphzvZEiORPU7dG1PzvuB/V1G4?=
 =?us-ascii?Q?XCg8k7fZxNmr9gwFQ42RfftEI7EP0K6ImSLQC3PMl+W4OpN4uQNqxPFaQi+O?=
 =?us-ascii?Q?W5AkxYVXglPfdYMh/nP8WMTgbfkidbc2z5B7nFrj/05tb0vJCDbUAJed/wkW?=
 =?us-ascii?Q?6IVUqopXXYQpaOwBCcRlx1gBKYV3BlsQ2C48R3F3qyYhEoHc3zcUNcqn0jN1?=
 =?us-ascii?Q?OFav9rceACF8SNbu1l9ENetJBpuSuwh27IQyxATFEjJFLkRvqXolkeNigvFY?=
 =?us-ascii?Q?FhurLg1y3sqRjG1LHjQDi2yBqOoCP3IG9ZahcrKfG71FR42tJmQxOjrG1Yrv?=
 =?us-ascii?Q?0cGnlBze4kcHJDX1lgJCY9GchA7dmR85KZMc5A6vwgf8Ptc7S1/nnlyGnZO1?=
 =?us-ascii?Q?yKF6AjTO1/dRmNYWOfJObJltUZHNjQAX+MaCklnNMKc6T6mg8PoNuCtLp7cb?=
 =?us-ascii?Q?U8iKyBcoK3FuZCJ52P1gmFx4e/kCqaEOJ6CbZZmnzNiYAHx2pEHglZwBZU8W?=
 =?us-ascii?Q?etr6wU68GhE7upb3M//TBtKVINWCKhDZtD40YWcdgz7qqTVK/I/fOetFiZfO?=
 =?us-ascii?Q?xtOTpwFekKrlg8FJ/VE9GEjBDetCIMgDYyCa1iDvsfpGWaoZyczMGcbt+Nan?=
 =?us-ascii?Q?RoO1yBOxbHtRw3n8q3e8TZR0jzy8INVZSE8SNoxMrBzXC7KH5wQHD4cuxVBS?=
 =?us-ascii?Q?SYtlRddvvXFKukbaaidkb7YqmovcVM77WKe/kv1WVGN5tSLP3tYm6tE8pJbV?=
 =?us-ascii?Q?A3z0SNp/NZXz8RMUVotDv88Zt4SGim8AkiEqz7iWQxQuYMe+7tDyZ0ANBAOs?=
 =?us-ascii?Q?V/ZpkQzj7At9zGQoEdLRgChD9tRlWHoLgZsaJCf6wt0FO9ip9QBseGtvMzBh?=
 =?us-ascii?Q?gOIgIjG2IeBeSUCngRI6wkRvPH0V2ukOqDyBXca7rUofVwePHZH43pMMANHm?=
 =?us-ascii?Q?c/hhCC5D+cL+9YCP0goxB95BVVXFjvISa99BkE5khq9UYk/b3w8ISJZHdj2s?=
 =?us-ascii?Q?JCBG/zjeyP0PqclmNDB6BdY6rwVN7nKmrliG40M/GBZssowl8troU8ljIEeC?=
 =?us-ascii?Q?TyIDjcnFi6+wAEcC8AfVEnhEWftjyLMaDXix09CCtfusOidNXIaR1PZMY1fa?=
 =?us-ascii?Q?2sHXXSoEeQl1F4AA6O5CYi0=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a6fd5e7-01fd-465e-fd05-08dc5c3aa2d0
X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5947.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2024 04:23:29.2660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yzgazkQh7wScBrLsoNpg7FZl+tE74KBfOIPvd1feegXceDkabZ/65Etzx/cQ+yCKbvo3hnId6dwL1MA7zdytVaWCmEZSkjzFKdV8n0gKsqMlT/EKVjrKfk4xQxtEAxVR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6715

PWMOUT pins on MAX31790 can be configured as a tachometer input pin by
setting bit[0] in the Configuration Register. When the bit[0] of a channel
is set, the PWMOUT pin becomes the tach input pin for the channel plus six.

This commit allows the kernel to set those pins when necessary if the
maxim,pwmout-pin-as-tach-input DT property exists.

Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
---
Changes in v2:
 - Update the vendor property name to "maxim,pwmout-pin-as-tach-input"   [Rob]
---
 drivers/hwmon/max31790.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/drivers/hwmon/max31790.c b/drivers/hwmon/max31790.c
index 3dc95196b229..ac0a8099acf6 100644
--- a/drivers/hwmon/max31790.c
+++ b/drivers/hwmon/max31790.c
@@ -12,6 +12,7 @@
 #include <linux/init.h>
 #include <linux/jiffies.h>
 #include <linux/module.h>
+#include <linux/property.h>
 #include <linux/slab.h>
 
 /* MAX31790 registers */
@@ -506,9 +507,12 @@ static int max31790_probe(struct i2c_client *client)
 {
 	struct i2c_adapter *adapter = client->adapter;
 	struct device *dev = &client->dev;
+	u8 pwmout_to_tach[NR_CHANNEL];
 	struct max31790_data *data;
 	struct device *hwmon_dev;
 	int err;
+	u8 tmp;
+	int i;
 
 	if (!i2c_check_functionality(adapter,
 			I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA))
@@ -528,6 +532,33 @@ static int max31790_probe(struct i2c_client *client)
 	if (err)
 		return err;
 
+	if (device_property_present(dev, "maxim,pwmout-pin-as-tach-input")) {
+		err = device_property_read_u8_array(dev, "maxim,pwmout-pin-as-tach-input",
+						    pwmout_to_tach, NR_CHANNEL);
+		if (err) {
+			/* The maxim,pwmout-pin-as-tach-input is an array of six values */
+			dev_warn(dev, "The maxim,pwmout-pin-as-tach-input property exist but malform");
+		} else {
+			for (i = 0; i < NR_CHANNEL; i++) {
+				tmp = data->fan_config[i];
+				if (pwmout_to_tach[i])
+					data->fan_config[i] |= MAX31790_FAN_CFG_TACH_INPUT;
+				else
+					data->fan_config[i] &= ~(MAX31790_FAN_CFG_TACH_INPUT);
+
+				if (tmp != data->fan_config[i]) {
+					err = i2c_smbus_write_byte_data(client,
+									MAX31790_REG_FAN_CONFIG(i),
+									data->fan_config[i]);
+					if (err < 0)
+						dev_warn(dev,
+							 "Fail to apply fan configuration at channel %d",
+							 i);
+				}
+			}
+		}
+	}
+
 	hwmon_dev = devm_hwmon_device_register_with_info(dev, client->name,
 							 data,
 							 &max31790_chip_info,
-- 
2.17.1