Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp849592lqp; Sun, 14 Apr 2024 02:23:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXTBNJT073JrZ/z9q9C3Q/+sIHNcJ33U1ZtQp18JKHpx15PXrKuoanClGAgsLPURah298XOmIuEmmOzOMIIHwFI49iuV/w2LhjTgQ1ZEg== X-Google-Smtp-Source: AGHT+IHIwZLJcyLICVw7otwdqbNy5rTX9k3PpYSV+boaI8HxkU2HwJEJ+YqS9G58X+CvcbnMuGpf X-Received: by 2002:a05:6512:29c:b0:515:d196:6d4d with SMTP id j28-20020a056512029c00b00515d1966d4dmr5530670lfp.24.1713086598860; Sun, 14 Apr 2024 02:23:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713086598; cv=pass; d=google.com; s=arc-20160816; b=NLfZh+SAZfagkx3rjhcazrOCWLktNbYUlhGzXecQqDCrz1eeuHohCRAr9vNysDX5Ku IjMyeZ85IQgv1QpiM6eBTbZ+cRJ2DmSk/TBFIf+fuRQ6yyyh6H6e4KUPYna8GdwZcMVB GsAKwYC3Mj8ZhrRRL2yV3j8y2x20nIWxSTVBlJU2oyNMbHCz6/I7Qdu7fN29H1qlOYhM dOIWoU4ekCTrWeVQBtRmuKicGcu8S1dpuQWxW32+TzLMTGLnNw9IM6aviHGO6rjx+Mfz Im/LkBfJ8ZCsyfjfaDEmZexY2pBVxoPj1BkToMu9/SskeUd6TcXBef4j4mThFXC+1pdM RrwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=s5ltjkK1gwJpndCII1TvY/cIdzI9eB2EsZ3Lgn3ig3E=; fh=z5tgC1ve+3/U9TC2P7GuTg25527eF8TOdgFSD+f8B3I=; b=YO3NCF9sIcUn8yTMKHqIo8ftkhyvcq564w2HzMGOGY9uqLDWe8wjgNprorFBf57onl 0f4pSHNrS4aHhcHFXfo134M5n9BunpnjffbL0cpCEWiDzJa7QggmAbhkE3sLQm3KiXnI FrY/x+QVGDuDqO4Psnyw6oDCWARl4ZIq8G7DchJRMbJlwjlUE7fvNxLWFj0POjzawAdP p2M8x88wz2eG8fzxfyEROHUN55yWETKgDkA8Dl4StB0Lyjsp3KMgGny0pMzW3nDv3vSg pHHZCKTY7UTmxv1FRd24M9Wbt9XcwSz5jhLcsweyrucRi6QXqB6n/Qp61+/cXrpBFKec pxhg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="sIo/CsoA"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-144072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144072-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qf4-20020a1709077f0400b00a51ce4057c2si3753123ejc.995.2024.04.14.02.23.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 02:23:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="sIo/CsoA"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-144072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144072-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8FBF71F215E1 for ; Sun, 14 Apr 2024 09:23:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED6B823748; Sun, 14 Apr 2024 09:23:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="sIo/CsoA" Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8A815E9B; Sun, 14 Apr 2024 09:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713086589; cv=none; b=QhuyZIOSDiIUs2QTvupaNXp96pzbKpQHpY+TqFCJ8MzZwPIWNPpZnUovB2f7b9jOoupXFe6C9/xOK3raI3wgPEDdHFhtv6nLSoDpiUJq4praZRg3zVbp8YiSY33jdWdUyUNwnrUdcXOYrjsv7sMpEzM3tchviHLV1xtGYt4C/L8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713086589; c=relaxed/simple; bh=CZbU5y5aS7bsN4EzHQELiX8tMKw5daTd36n4GBNvk8A=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=Y0o/fN4nCQaCG2AfnhaA10UgHsEMSt0GxWeP+EvLcpKNeOClzAdpL6T/ZG6q6d690ThD2zH5Qy8GEs/VQyx7j/OhWzmqA1nuWSDrv2vlDny5/2eyQeRHDUsyo+F+CKfoZy3cL8NZyj+LKrcrZHVOHxbTNcgfuhlHPHWv9HQpPug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=sIo/CsoA; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1713086579; x=1713691379; i=markus.elfring@web.de; bh=s5ltjkK1gwJpndCII1TvY/cIdzI9eB2EsZ3Lgn3ig3E=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=sIo/CsoAdjQQW0jx9crXA5pN3OhvhfLJLyeJE59/lMnfMf2gWaFYmmMqCt3aaXdR c7SRfHGlSdN9SDlsxp2W0hqwmovU8CVNmKBm1+Knacpa31AxHAJR5LFl3vcdlLLh7 P662qXPDnvbzxVgWq3O1Fe0XQTaU7c1fq7z7L+DHmYpxARpkFFuLhDK4XByUBTUF+ RCfA6M3Sq7au+e1O3c4bfdu8Ery5ocUP/PDkpGk3nGv7DXgteQg9QlYeO5pxU07Y8 G2YNkvBzy5cG5ZEzvIdjrYXyPIr+hBxwHCVGM04UK4NhBRrEfdmladuBkS4D62Z/m r598WQUQvqLAkwJbnw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.88.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MidDR-1sQqUJ45dn-00fQIp; Sun, 14 Apr 2024 11:16:49 +0200 Message-ID: <22f324ce-552a-4f6a-b4e5-2d84a00010aa@web.de> Date: Sun, 14 Apr 2024 11:16:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Li Nan , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Zhihao Cheng Cc: LKML , Hou Tao , Yang Erkun , Yu Kuai , Zhang Yi References: <20231208074629.1656356-1-linan666@huaweicloud.com> Subject: Re: [PATCH v2] ubi: block: fix memleak in ubiblock_create() Content-Language: en-GB From: Markus Elfring In-Reply-To: <20231208074629.1656356-1-linan666@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:78p3dblrsqPURz0FRE4t9XDi/hn8Hkx9PEJPx94ac+U8J2gEHyd ATSHvvuSo0/6ZUrt4X79V1sVdDHxzZV0Fk6+QX6uvvcat67jFNb9mOdBPiUm9ZTf5/42ipC Iac82O8R4x7hKff4bxvwRukSDZSYCe5z5K42hTU7CBVN9OE5/DSMtHMxNUAmjsshKnCB8+3 5jlJw7JL1UE6tfYrFbS/g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:78U8V0f2Fdo=;LGe4/JopxlNNRAM6CgWWkpkSAWk 3BCmW5wTgs7oumhZCoEm4Y1cojBqUQKuJI4dMvn+e/l45aHnnkquuCwjd1De05C1dPE/XFMsX XTqkYwNuGiO0XkJRKJaesoCF6tCpW6GKZfd5vChJi1nVpoO5QFQf3jek4qqhTySAjjA8Bk6Vm bSIqCc+Q9SJ4m0fXkcOFdmA6b105pbuKHJdoAzLO0LspYHeFebZPerPwI2/9PXVpsTiCUwnWH /+B4yn1M0HC5zDhFkC8OupQHU90jrQyDhlXKic64HZQUvI36dkVNlbw1z5S0vNWavZdtxk08U rThHeDXYEDFK6NGGIgbxk1xOMHCpSue+LEqtBfmjhqVKSuHJqV+5rENU8+vEntxg6XDdxzO0/ HbkZn4RQo4zZq0vjzvWYaac6r0UEEEjqtxqPBfqJdAtVWXHWlntPS97h1xHchIct94poZpRt2 8EtgDek1KDaB5bR5WXSRtGf/tbhz4AOMukxL3IqYlSX2tSCbnQre5qyGImR2IT9qc09S5p1M0 pzq0yi/3N+nhBL/xaf9nEK7thqKQI6Na7fx9z2lvRWkbz/rNDm7ueKzB69vUBIzbtCtBQ41ec pHBnBNtv7LO4dMmiSwnTkPEerrnZEgR9BtQrXnde4MLLcJfcroxsmjdgoyFyUclZ9u+FGw6gj PeBrpFhdHIDCsF6yMmzjqEmtAYdb3fyTwXWY1/qx/tbZvL/jJQ4elVFMqymIM2Nc7o4UKEDHd 4irKba+X9tEk1L6pLoV9jTiqYY140iQP0eYgSVIWIDkRigouuXUw+gSm25ib2NcUm3pTvSnfi V7nIUbVGbIwD2W0OSCIXIx0t1opC6iDl2qJ+5Vv81cZck= Can it be nicer to use the term =E2=80=9Cmemory leak=E2=80=9D instead of = =E2=80=9Cmemleak=E2=80=9D in the patch subject? =E2=80=A6 > 'gd' will not be put anymore. Fix it by putting 'gd' directly. Would the following wording variant be more desirable? =E2=80=A6 anymore. Thus pass the variable =E2=80=9Cgd=E2=80=9D to a put_disk() call direct= ly. Would you like to add the tag =E2=80=9CFixes=E2=80=9D accordingly? Regards, Markus