Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp917100lqp; Sun, 14 Apr 2024 05:53:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVheKSwR99l2lzYv89gcvvD5ebxjb6WjvWwc9R98HHJxHyuzJKOLdnA+1lqfZcMHP6nlHKaP+pr6Ky3YORm2HEdX04av42EJlRa9dnHXg== X-Google-Smtp-Source: AGHT+IH28MxwN1Yj7K0ebkxxGiyG07FF34RIL2tjU0uWeNgLrh/0mkz8JoRqBDyBhuJQOVCAhNPG X-Received: by 2002:a05:620a:2119:b0:78d:7588:c19b with SMTP id l25-20020a05620a211900b0078d7588c19bmr8211407qkl.40.1713099184067; Sun, 14 Apr 2024 05:53:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713099184; cv=pass; d=google.com; s=arc-20160816; b=Fki02IvoTsk+wnMiIMXp/c0UO8zYsRRb1gmEsX2uUEbvOm+ZhRz2Boyu3G+1pT3lCM KNRTwlax7JAT0oH/yYrX0VH4IF/hidBXvO6D3O4BLJrJXpczD82PyNDSS3mQH6Fj3v34 bXGNwFtRpZNj4C1XB8EO5Bh0Or0tfofMsBxPoXbWSUDhqsx3GBIj2qRWZNcSSwAAVuuj xIbZbWXqUknptBWFEjazvO40vDq/zTwmDc0A7if5YZqNPJr1oq/l9HqflGd5F82lRame H6YTSedUZXxcd7pRNuGY72hx29PzxsxLoF9wz7yWETcGmu2AZ7ncitHhwFxkv8iJy8LU NOeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+OaTZqKPuqgrlAzsoM7cIz46knXdX9d/0a6PcC/nGz8=; fh=8g2KtbjHv0qNLsfjlD7T5E4uLhcbzCLNSSaO4SwXmnY=; b=AOqko0AsoeysQ9SK+Y4YC+7dzQsZMxKFaPFQP2ThGB0v1Jr9NaXpWBWmzmwyhuZtbH xiV3pSdE9rsHWeLmqtcydug1OmGuZTHNU7xe2qgpAKYw7a8iZQYorQ+tLFZJyyYAiGOp 0Q/BnvuVCdYAVNOmZ/WwKymra5WlcHB7Co44JrPBRJEaDITuCIVpkLAs0fHm8cWDbC0O v21AAcIga1fEkTY79RZLNa9E0Pm0Mw0u5cAaO2THCkQLNiwlUz0SnXa39LZxjpYUKiGl XpVUPuAuc2a+heYerFms4Ptsz8tLc/AlWxGiD/W2bCh5M6YXMLJAZECqxI+dmEslaQho KzOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ToXMfwEI; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-144140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144140-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y11-20020a05620a44cb00b0078ec89642dasi6965038qkp.554.2024.04.14.05.53.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 05:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ToXMfwEI; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-144140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144140-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 58E5C1C20AF4 for ; Sun, 14 Apr 2024 12:53:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 716C43EA90; Sun, 14 Apr 2024 12:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ToXMfwEI" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E38114292; Sun, 14 Apr 2024 12:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713099171; cv=none; b=ESBU6bPiP0xjC7uTlOeld/jMlaybRIVc8AMCURkt6hGFUIndyUT7W2Xd643u81ZDnckZgwJ8XLqVMyTLE8MOnmBJTWKhEmF2IgX5QfWKPaN1G6KY5Geu73PKaOySSdEk5aVkaFounPQfK2UxH8XU1mBp5tFfRo7QQmSZscbOOoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713099171; c=relaxed/simple; bh=ylzy7/WxQmtDrQrEHLpFCt6of1KyGEM6HQ+QR40PWmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FSb43TWhTfDK5MSTu1LIBOTAvwB01zBGP09+zaRLJ8cJ4DroiiGBOLWiB/lF0WR6+ey4W9w3F/v2GgzQMCaSNG9F+ZGDCnla1oYcQyh6wtx5e7P3sAwEjTmF8SlEHKAHqlXzMfvI/MZYs4oWlwOJ/gW+nYFAeVflHuaw84DQOck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ToXMfwEI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD4F3C072AA; Sun, 14 Apr 2024 12:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713099171; bh=ylzy7/WxQmtDrQrEHLpFCt6of1KyGEM6HQ+QR40PWmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ToXMfwEIW2w/Y2zUh8zHAO52nKF86eQSEUaxcJ9T7iE+DKwI7NJDcl4ZHg8S50UhL y2ZYp/2Gskl5n+dqknd3pWYr9LgmSB82MedBiLevQC1O8GgwoVqPv15zW/m7EGxA0x Yy6H/JK8CJGLJNQOuBIKD0aczHCEYShuelAT1nd8= Date: Sun, 14 Apr 2024 14:52:48 +0200 From: Greg KH To: Christophe JAILLET Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: gadget: function: Remove usage of the deprecated ida_simple_xx() API Message-ID: <2024041432-cranial-spyglass-17d3@gregkh> References: <779bc8ae-0f24-4f34-8f20-633e6e6f2fc5@wanadoo.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <779bc8ae-0f24-4f34-8f20-633e6e6f2fc5@wanadoo.fr> On Sun, Apr 14, 2024 at 02:09:08PM +0200, Christophe JAILLET wrote: > Le 14/01/2024 ? 12:39, Christophe JAILLET a ?crit?: > > ida_alloc() and ida_free() should be preferred to the deprecated > > ida_simple_get() and ida_simple_remove(). > > > > Note that the upper limit of ida_simple_get() is exclusive, but the one of > > ida_alloc_max() is inclusive. So a -1 has been added when needed. > > > > Signed-off-by: Christophe JAILLET > > --- > > drivers/usb/gadget/function/f_hid.c | 6 +++--- > > drivers/usb/gadget/function/f_printer.c | 6 +++--- > > drivers/usb/gadget/function/rndis.c | 4 ++-- > > 3 files changed, 8 insertions(+), 8 deletions(-) > > > > Hi, > > polite reminder. Odd, this isn't in my review queue anywhere. Can you rebase and resend? thanks, greg k-h