Received-SPF: pass (google.com: domain of linux-kernel+bounces-144267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 14 Apr 2024 12:33:48 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Kory Maincent <kory.maincent@bootlin.com>, 
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, 
 Andrew Lunn <andrew@lunn.ch>, 
 Heiner Kallweit <hkallweit1@gmail.com>, 
 Russell King <linux@armlinux.org.uk>, 
 "David S. Miller" <davem@davemloft.net>, 
 Eric Dumazet <edumazet@google.com>, 
 Jakub Kicinski <kuba@kernel.org>, 
 Paolo Abeni <pabeni@redhat.com>, 
 Richard Cochran <richardcochran@gmail.com>, 
 Radu Pirea <radu-nicolae.pirea@oss.nxp.com>, 
 Jay Vosburgh <j.vosburgh@gmail.com>, 
 Andy Gospodarek <andy@greyhouse.net>, 
 Nicolas Ferre <nicolas.ferre@microchip.com>, 
 Claudiu Beznea <claudiu.beznea@tuxon.dev>, 
 Jonathan Corbet <corbet@lwn.net>, 
 Horatiu Vultur <horatiu.vultur@microchip.com>, 
 UNGLinuxDriver@microchip.com, 
 Simon Horman <horms@kernel.org>, 
 Vladimir Oltean <vladimir.oltean@nxp.com>, 
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>, 
 netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 linux-doc@vger.kernel.org, 
 Maxime Chevallier <maxime.chevallier@bootlin.com>, 
 Rahul Rameshbabu <rrameshbabu@nvidia.com>
Message-ID: <661c056cf26d6_3e7732294f3@willemb.c.googlers.com.notmuch>
In-Reply-To: <20240414073315.5aa7adf0@kmaincent-XPS-13-7390>
References: <20240409-feature_ptp_netnext-v10-0-0fa2ea5c89a9@bootlin.com>
 <20240409-feature_ptp_netnext-v10-8-0fa2ea5c89a9@bootlin.com>
 <66175265992c8_2d6bc6294d8@willemb.c.googlers.com.notmuch>
 <20240414073315.5aa7adf0@kmaincent-XPS-13-7390>
Subject: Re: [PATCH net-next v10 08/13] ptp: Add phc source and helpers to
 register specific PTP clock or get information
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Kory Maincent wrote:
> On Wed, 10 Apr 2024 23:00:53 -0400
> Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
> 
> > > +/**
> > > + * netdev_ptp_clock_register() - register a PTP hardware clock driver for
> > > + *				 a net device
> > > + *
> > > + * @info: Structure describing the new clock.
> > > + * @dev:  Pointer of the net device
> > > + */
> > > +
> > > +extern struct ptp_clock *
> > > +netdev_ptp_clock_register(struct ptp_clock_info *info,
> > > +			  struct net_device *dev);  
> > 
> > No need for explicit extern?
> 
> Indeed I don't think it is needed.
> I am wondering why few other functions uses it (ptp_clock_register,
> ptp_clock_event, ptp_clock_index). Do you know?

Perhaps it predates the coding style rule

    Do not use the ``extern`` keyword with function declarations as this makes
    lines longer and isn't strictly necessary.