Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754794AbYAXHHh (ORCPT ); Thu, 24 Jan 2008 02:07:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753189AbYAXHHJ (ORCPT ); Thu, 24 Jan 2008 02:07:09 -0500 Received: from gate.crashing.org ([63.228.1.57]:48100 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbYAXHHI (ORCPT ); Thu, 24 Jan 2008 02:07:08 -0500 Subject: Re: [PATCH v2][POWERPC] Always build setup-bus.c on powerpc From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Kumar Gala Cc: Greg KH , linux-pci@atrey.karlin.mff.cuni.cz, Paul Mackerras , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org In-Reply-To: References: <1201156120.6815.48.camel@pasglop> <8642742F-E8BF-43C7-9FE4-AAF54855ECF7@kernel.crashing.org> Content-Type: text/plain Date: Thu, 24 Jan 2008 18:06:35 +1100 Message-Id: <1201158395.6815.50.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 40 On Thu, 2008-01-24 at 00:38 -0600, Kumar Gala wrote: > The common arch/powerpc code calls in to functions in setup-bus.c > so some builds of ppc32 would fail. > > Note, ppc32 usage of setup-irq.c is limited to arch/ppc and should be > removed when arch/ppc goes away. > > Signed-off-by: Kumar Gala > Signed-off-by: Greg Kroah-Hartman Ack. Funny I didn't catch it on my 4xx testing, I must have always had HOTPLUG enabled. > --- > > Here's the proper diff, will send this via paulus. > > drivers/pci/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile > index 5550556..f697f3d 100644 > --- a/drivers/pci/Makefile > +++ b/drivers/pci/Makefile > @@ -32,7 +32,7 @@ obj-$(CONFIG_ARM) += setup-bus.o setup-irq.o > obj-$(CONFIG_PARISC) += setup-bus.o > obj-$(CONFIG_SUPERH) += setup-bus.o setup-irq.o > obj-$(CONFIG_PPC32) += setup-irq.o > -obj-$(CONFIG_PPC64) += setup-bus.o > +obj-$(CONFIG_PPC) += setup-bus.o > obj-$(CONFIG_MIPS) += setup-bus.o setup-irq.o > obj-$(CONFIG_X86_VISWS) += setup-irq.o > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/