Received-SPF: pass (google.com: domain of linux-kernel+bounces-144313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 14 Apr 2024 19:52:03 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Stafford Horne <shorne@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Jonas Bonn <jonas@southpole.se>, 
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Andrew Davis <afd@ti.com>, linux-openrisc@vger.kernel.org
Subject: Re: [PATCH] openrisc: Use do_kernel_power_off()
Message-ID: <rfbxtgppobtvtp2flghzpw7mzlrhnzwuk5gulwdauf5ecfkpa7@xk4qspf3mo3c>
References: <20240331070230.2252922-1-shorne@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5g3tqu2f5hovaone"
Content-Disposition: inline
In-Reply-To: <20240331070230.2252922-1-shorne@gmail.com>


--5g3tqu2f5hovaone
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Mar 31, 2024 at 08:02:28AM +0100, Stafford Horne wrote:
> After commit 14c5678720bd ("power: reset: syscon-poweroff: Use
> devm_register_sys_off_handler(POWER_OFF)") setting up of pm_power_off
> was removed from the driver, this causes OpenRISC platforms using
> syscon-poweroff to no longer shutdown.
>=20
> The kernel now supports chained power-off handlers. Use
> do_kernel_power_off() that invokes chained power-off handlers.  All
> architectures have moved away from using pm_power_off except OpenRISC.
>=20
> This patch migrates openrisc to use do_kernel_power_off() instead of the
> legacy pm_power_off().
>=20
> Fixes: 14c5678720bd ("power: reset: syscon-poweroff: Use devm_register_sy=
s_off_handler(POWER_OFF)")
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  arch/openrisc/kernel/process.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>=20
> diff --git a/arch/openrisc/kernel/process.c b/arch/openrisc/kernel/proces=
s.c
> index 86e02929f3ac..3c27d1c72718 100644
> --- a/arch/openrisc/kernel/process.c
> +++ b/arch/openrisc/kernel/process.c
> @@ -65,7 +65,7 @@ void machine_restart(char *cmd)
>  }
> =20
>  /*
> - * This is used if pm_power_off has not been set by a power management
> + * This is used if a sys-off handler was not set by a power management
>   * driver, in this case we can assume we are on a simulator.  On
>   * OpenRISC simulators l.nop 1 will trigger the simulator exit.
>   */
> @@ -89,10 +89,8 @@ void machine_halt(void)
>  void machine_power_off(void)
>  {
>  	printk(KERN_INFO "*** MACHINE POWER OFF ***\n");
> -	if (pm_power_off !=3D NULL)
> -		pm_power_off();
> -	else
> -		default_power_off();
> +	do_kernel_power_off();
> +	default_power_off();
>  }
> =20
>  /*
> --=20
> 2.44.0
>=20

--5g3tqu2f5hovaone
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYcF78ACgkQ2O7X88g7
+pq5mQ/+M+426GVgXDcqLWaBeZW3HA03bp5BIZ/MDyTJhm0Rddyq9+9y1SftS9bc
A1Hn5oGq3LBhUarGxPIsDzum+BFAnY9H0iLLNSa9GxFNHvatxsEsPPLAgF1+M3Q5
PaU9fBuC25Kihszf9bfnopMAt+3RbgDc2IVQv/f9sPjnd2S//342bFq2e8E7MTGp
sMa91/Jn4/2OPwjiSogBx1LehE4cnREYOWo7ruBCp8fW4e6G+wpQ5FhSVfe3NF/m
RYVpsVXGvVoIU1XecjC2CTi6g0MKJ6xZhXfjjRnmYDHnod04lVggh5zKzWgO6j+b
7M+7pw7EaCce/38W5u/hM40X0FH1GT/ZUdmTFhaBPUFzBBTpw1X9HXe0VLJhIYGe
urGx2G6QnX/x0YbDrbKJv27NsgVorKfE5qwPtpbD4MEhQqWovEl80Ysv0gCajs08
RmPVqqmFsxSqbPjsrzP8BL1bPTMBN/2iM05hzScis9/OgrGHRuSm8TNCGx7stYpE
PBoiE8bMlEKREoLriPRrcKvkpPCcKD1T19hsjonZZpLry6sTiQaCQbbeugNM97uK
EWy5DmeTgiYSQ/10auOYWkJG2Tp1FKPWz9o5D892DBrRKeyweHnJEF5g7LYjC+hy
5IQvYdd8SKIyrJACVazpoPbMWk8bjnmXuwBcXp8x2G+o7NtSzxY=
=fROO
-----END PGP SIGNATURE-----

--5g3tqu2f5hovaone--