Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1051151lqp; Sun, 14 Apr 2024 11:37:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWS6GeiQZGN4A1P4icxBWuzBRDC2BsCV67r/2is8MKrbw2PcVRp4fhwwg8qhKBBi5SRGmiTHGE7nIgrx7AOUCGIzF3yKsLDxQOQyKFJOg== X-Google-Smtp-Source: AGHT+IEgb+NoFKxUlWcvEZDRvcBW2aNI8yjaExeRY0ZZPmDyxJ6gdCnIQvIjBYK3Uidev7wj4Pf4 X-Received: by 2002:a17:906:46c8:b0:a52:42ce:7d9f with SMTP id k8-20020a17090646c800b00a5242ce7d9fmr3599757ejs.21.1713119820271; Sun, 14 Apr 2024 11:37:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713119820; cv=pass; d=google.com; s=arc-20160816; b=baVH19f3R/PzyYaqOecM/tGlQfZaJcCavffAj6THnN5o7JMiapuC2KMrI2jys7298E C9DiYYfXyMyUdQRv2o++sUOiMMiW8cczsIdO5GMulWQ4L6DJqpAZBoVJF5d1xiy6qESS yXx50fD00PSLjLEdGjIS4kygJCQ1zrAvjUHsQdPBeep5F1izpCY6JxxIPT42xHsg3Mmw seLO+khy1PacohtN2JWIIuVifQe48Swi7GNbzGZlUIZWvjUPrRyAlBPjkg1uE9sHxHy7 uQplzvnQyMKsrw1sECmU+TexSGSyiIEBcNYSOAWoAvz0mGiekCJ2W3ygfpPJ9xOjFYqM PQIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JgBceyI1Z5oi2LPsjNpgLr+AZDXXUmHqsZtH20Rmir8=; fh=mUQbaoX63C03z+l2kUQ+4k8xeT/sVmgr+UrDOk4IkmQ=; b=NlyC7wozTpDc/mmIAGctPitHEvSxTUaPb5foB+3iizT7cqaj04ZBANfnbboeNlD0Hp g15Z/REspc+hgtO7ezX2WjMvQHnXi4wgaz0ALVsU0mqUU4/Z8iwXJNs9100J6P7l7eh2 9rMNYUF3AZPpnyfXh9YoNIc3QEqjRoDHMzsR5zdrK+cp2/VnybsFZRNJvnitK+JYCDdh Q8Zbp1hD0AwNf8bSeRoddXAtAgdVYD23F/+x9fbiquoB06rugixU8Vd0o3vIMEVMZ8V2 N0iYXMXOG9PTSAMzreMf7Q+/eI6skzMMZBP9aXh8KbwWogCevsAyLL+2OTuQw7UtLcAG hqYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=tdwmPxjh; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-144322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144322-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id bs19-20020a170906d1d300b00a51f459bd09si3649957ejb.786.2024.04.14.11.37.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 11:37:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=tdwmPxjh; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-144322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144322-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D16741F2112A for ; Sun, 14 Apr 2024 18:36:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1830D1350EA; Sun, 14 Apr 2024 18:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="tdwmPxjh" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D13FB29B0; Sun, 14 Apr 2024 18:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713119807; cv=none; b=a+D+OnB2kibElUxON87LFtJnwybfizNApxBGTdwrc2y7aSBq2OHTEGccYNsJYWlUPSq/hYOQNAXzhULMIKQrjJWm0NZQh0kqDZw9fXiVg4Z8O9ifosANYT+WNVXXRmXOSouepnzPDMCdOXxmkg2ON2xoV5U0xyVCawdOG1xeuEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713119807; c=relaxed/simple; bh=rT0Ls6DVFCzzlFPUOlmKHuVQHe6JZ+Laed7jwNJb4no=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=be5YJ4TohO9my088OBLgJg8iZSl4hKt9X8v+KDdUAkbMRzDedZj5vAgfr+YIucP8I0N6dBy9plx1e4YwTShSSXXWLInh2g9eM4ZCU0ubpMt7yY3USWubyQgZwQQBapDO48bQAjYD0GohM1w7Dw42OCysAxUafFoPWbdX5QIlg68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=tdwmPxjh; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713119803; bh=rT0Ls6DVFCzzlFPUOlmKHuVQHe6JZ+Laed7jwNJb4no=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tdwmPxjhpI1tcBVd8qCh7/nSyl+LjbG52efcfiCsa05jLLrWb8WDMD0V2h7DHsRIe pA2cPJr6sITGynILUsqCSlmenANEGPNeEWqRZdLBz7lFk0bhhfdyVLuhlf7yvPktTr 1TJXzw0OK95ShF1u5/EX0/n3NgDt9zbfIwgIe2WQ5X9XsXt/Bl8lLFOfZJG4+dG+CZ 2bsYl+uTLg1fa7Mm8AgERoRgtQ03Ay92Fxxsdbawh829J7IYiJBt2HOkgXmu4L80OJ WjUkLix9Mn07oSVZBKel2yYT6tFyOkDWrEhee7YhffLKQEB124D6/le17MP/1fi8LN 2B3QSakDPslYA== Received: from mercury (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B1DE237814A4; Sun, 14 Apr 2024 18:36:43 +0000 (UTC) Received: by mercury (Postfix, from userid 1000) id 31571106134A; Sun, 14 Apr 2024 20:36:41 +0200 (CEST) Date: Sun, 14 Apr 2024 20:36:41 +0200 From: Sebastian Reichel To: Jianfeng Liu Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org, sfr@canb.auug.org.au Subject: Re: [PATCH v5 1/2] arm64: dts: rockchip: Add Hantro G1 VPU support for RK3588 Message-ID: References: <20240413064608.788561-1-liujianfeng1994@gmail.com> <20240413064608.788561-2-liujianfeng1994@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cwtj3nebnsz4gzrf" Content-Disposition: inline In-Reply-To: <20240413064608.788561-2-liujianfeng1994@gmail.com> --cwtj3nebnsz4gzrf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Apr 13, 2024 at 02:46:07PM +0800, Jianfeng Liu wrote: > Enable Hantro G1 video decoder in RK3588's devicetree. >=20 > Tested with FFmpeg v4l2_request code taken from [1] > with MPEG2, H.264 and VP8 samples. >=20 > [1] https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/multim= edia/ffmpeg/patches/v4l2-request/ffmpeg-001-v4l2-request.patch >=20 > Signed-off-by: Jianfeng Liu > --- Reviewed-by: Sebastian Reichel -- Sebastian > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/= dts/rockchip/rk3588s.dtsi > index ac5bd630f..de823f461 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > @@ -1072,6 +1072,27 @@ power-domain@RK3588_PD_SDMMC { > }; > }; > =20 > + vpu: video-codec@fdb50000 { > + compatible =3D "rockchip,rk3588-vdpu121", "rockchip,rk3568-vpu"; > + reg =3D <0x0 0xfdb50000 0x0 0x800>; > + interrupts =3D ; > + interrupt-names =3D "vdpu"; > + clocks =3D <&cru ACLK_VPU>, <&cru HCLK_VPU>; > + clock-names =3D "aclk", "hclk"; > + iommus =3D <&vdpu_mmu>; > + power-domains =3D <&power RK3588_PD_VDPU>; > + }; > + > + vdpu_mmu: iommu@fdb50800 { > + compatible =3D "rockchip,rk3588-iommu", "rockchip,rk3568-iommu"; > + reg =3D <0x0 0xfdb50800 0x0 0x40>; > + interrupts =3D ; > + clock-names =3D "aclk", "iface"; > + clocks =3D <&cru ACLK_VPU>, <&cru HCLK_VPU>; > + power-domains =3D <&power RK3588_PD_VDPU>; > + #iommu-cells =3D <0>; > + }; > + > av1d: video-codec@fdc70000 { > compatible =3D "rockchip,rk3588-av1-vpu"; > reg =3D <0x0 0xfdc70000 0x0 0x800>; > --=20 > 2.34.1 >=20 >=20 --cwtj3nebnsz4gzrf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYcIjQACgkQ2O7X88g7 +pru+g//TSGr8OdwYvLGz5eiAnvv//OdV2zNbWBeVOb5TQnuvB/kxBbwspIJAY44 +Bkgz9AWLjEZuooKaIoQrgCFNJu5o4+rdTiIhKMEo9M6QSjji/jRvB0J4TIUVbUR brTZUvJhTQJNNh81CWstGJtiYvPf57IJvojjk7VJRJFg97eTf/kZszfRArbWohhn 4Ij7oW9bR9e9fX8PIJd5zVgJD/ljHHmKU48ZkI8WMwhplYVJh84+lOaI9KbTjuN1 fqPjTNJeQm4l9VbQ1nvoe/LC9HErVoPc77obiChmO0FwCD4nAL0xMfC6m9Qweayg 7e9rG8crDGy2takHP5+vrOjLMdwucwzL2vNV8SuZbiF2NWPLDyD1TZkNKI6Tw4af xBu4OSA/de+vulnxpfIFYx3ieasHNfgl8PTwDOtliugOf6i+aiczpblhvLsqNcyK WtY4VUiR/B+YVNLOdsDFkDwHJ3r+YHCoke67R9MVYPZdq3JKIwxRaj2xqgHAUzBb joaX8pRdYrrxPkIquHKPUteegweV1Fr3FiZPvelNcSB/6l90HMa+XoYM5vR3ARnx zHpzLKJygYzlkUi4fR3y1Ad2H0FfV5MHx4TIJ+FlQuUJTuEnp30hWb7Sc/YCC0Ec YgZGoH/r8ARl0V+Zmvi/R6bFrZmnBETRnn55EzWnOfDUy3KHcyk= =HMGY -----END PGP SIGNATURE----- --cwtj3nebnsz4gzrf--