Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1085111lqp; Sun, 14 Apr 2024 13:41:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXHOgymgWAqCPS1nMHk3pMHTN6wu8wsUcPLe4lHPo6heZgzq+K59alyZurzN7T1AZUhESAtl/HreMTzjEh9Q3m9l9pnlp4cW7jxboHvcQ== X-Google-Smtp-Source: AGHT+IFw7VkcoISgS4YmLQlOHiS4ubCRNGYqHK4X9AGwwoDyP+eu1KO/lRNJUeGDyV6PykGExUwt X-Received: by 2002:a05:6a00:1a94:b0:6ec:ef1c:4dcd with SMTP id e20-20020a056a001a9400b006ecef1c4dcdmr10501366pfv.6.1713127284183; Sun, 14 Apr 2024 13:41:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713127284; cv=pass; d=google.com; s=arc-20160816; b=oKtS1692u6r0p3nFH+B+vSPQocL3zIEoToX608kkYUH+woWD2qdrw3njj9g3qo28br IziqoJJO+mBYEvud0s0hugtRJ3u1ISni5n+pnU4gW/PrQdooOHg1I4ioudlgwI7zfHDE UGfoLeugpFKGxF8Pud+VBU9tvdbxWLJ4USMb/YwaEYr+Zsn18roxrNYVY6k45EjzBp5X WG1LT/2WRN8m9JWZM5/H2zYQ8juqgRInknnKZqb5QMed8kcfJx6JJcE2UrRjvKBo22Bp ocmIfjesLOipZJvudNFl5/qeNkrNpFf5AkK66w8nc/zn6ZC2L1wWZOZZg86C4136KyIe eTCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=cGenqqyPt/Fp5kIA6u0AGK6xiTKXiqyafdjUpgpFSv0=; fh=ng0FUFwPgHHqIHtWcUlLUSBs0e7fHIUGeuUhfcQSRgA=; b=Wzl5kITzYdryvEOlzxUqfuk34sTCJS2BoxSLyfiCgOdJz46BPmpUEsinmNkvs/IgYM JwhV44J/377YTQPd+KAxMCWmDb6E/7Y4DAqmBtMU+0at3ya513/bjc6xIgkpMF77oiDl M/J2NEtBD1UNGpBVB1NfPO6EsDe3oKA/4V6RtbiaNPFgDaj9vo804H/P96e/gU5Rudv8 70HKPBiPuCoudPri5cUUcpu1kKmLLD58PoxiO1Ntm8fL0Qr0+lhPIoKBDYY3YgLQZjwR s9GCNnn7tgq00AD6rU1EykXKQd3biY0cAj3jfHHFQDvQQdfCrwWhG5x/HKCfo9Bsw/La 79Ag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=TjlIq1lz; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-144385-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144385-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j16-20020a056a00175000b006ead466f3d9si6847140pfc.18.2024.04.14.13.41.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 13:41:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144385-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=TjlIq1lz; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-144385-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144385-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BD57B280C05 for ; Sun, 14 Apr 2024 20:41:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 246AF137C20; Sun, 14 Apr 2024 20:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="TjlIq1lz" Received: from mail-108-mta50.mxroute.com (mail-108-mta50.mxroute.com [136.175.108.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D9C136983 for ; Sun, 14 Apr 2024 20:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713127247; cv=none; b=G0I4/IDJx627Bk7OfQvGYUsYX8dpsueqJJOdD3WDuYTFnzQzEIz4V0N3eMRbCY55rQHBgOOxU+muXyPd3LV9XyGzPpGy684G5CMB1cnreR+iuqJrN3x+QeVSpT95RquHGHrjCVc5iPcG5fOgyAenwVqo2ZQIHSoTMif3bFsN4Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713127247; c=relaxed/simple; bh=pWHVLRfYub4vLHZQ82uqXL9w4o6X1xxrAcCbjuVxJt8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=elV1aPT5adANM4hFdqhRNkMoGZKOx+eNiWxiLQfUpaoMGC8UGBSJsy1r3UgxC8C0IgL5aIPi+KuB/4C13T2yN5byzO4chH8/W3v30oRzt7CrmVEERiRxz+BcrfpQW2M/A2yOxDPD1CGtxYI2+eZg4mZlk3NQ5JaUqoRc4bUysds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=TjlIq1lz; arc=none smtp.client-ip=136.175.108.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta50.mxroute.com (ZoneMTA) with ESMTPSA id 18ede524e890003bea.010 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 14 Apr 2024 20:35:19 +0000 X-Zone-Loop: 9170e162deb840192439b01c6bb17c78a5e85566166b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cGenqqyPt/Fp5kIA6u0AGK6xiTKXiqyafdjUpgpFSv0=; b=TjlIq1lzHX0GvBcF/cZzaL+GP3 W4BWH3vfpetwc7HJPL7EE2NkDUViAaIf4NI+o0zTZACQAUlKqRdxMKOeQQEgbNz7SU3k5D7gi4wqr Shm/0uhT9W7HuLSMZwQRSR/BjgI54aIaaPYumpiaOu7AiWzMJgw9dAJLorvid7gE0q6D10urUM/uj jDvgaSHVnbMMZQZISmtmfHVYb5OzqAgp5FCR3KNqKxHBX4T4xdI02KO9fTeMXVEYDrKRoJZDqQjOM /FdyYi1jqW6fqplCBCcpCxw90VlTfLH3vdvc5cgUs+i9GyEncgBy0/CA2vKy+dhP6JkMwrtzte5k1 3SiN0MlQ==; From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Luis Garcia Subject: [PATCH v4 04/25] media: i2c: imx258: Remove redundant I2C writes. Date: Sun, 14 Apr 2024 14:34:42 -0600 Message-ID: <20240414203503.18402-5-git@luigi311.com> In-Reply-To: <20240414203503.18402-1-git@luigi311.com> References: <20240414203503.18402-1-git@luigi311.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: personal@luigi311.com From: Dave Stevenson Registers 0x0202 and 0x0203 are written via the control handler for V4L2_CID_EXPOSURE, so are not needed from the mode lists. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek --- drivers/media/i2c/imx258.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index 0ae4371940ca..df7ed4716762 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -237,8 +237,6 @@ static const struct imx258_reg mode_4208x3120_regs[] = { { 0x034E, 0x0C }, { 0x034F, 0x30 }, { 0x0350, 0x01 }, - { 0x0202, 0x0C }, - { 0x0203, 0x46 }, { 0x0204, 0x00 }, { 0x0205, 0x00 }, { 0x020E, 0x01 }, @@ -356,8 +354,6 @@ static const struct imx258_reg mode_2104_1560_regs[] = { { 0x034E, 0x06 }, { 0x034F, 0x18 }, { 0x0350, 0x01 }, - { 0x0202, 0x06 }, - { 0x0203, 0x2E }, { 0x0204, 0x00 }, { 0x0205, 0x00 }, { 0x020E, 0x01 }, @@ -475,8 +471,6 @@ static const struct imx258_reg mode_1048_780_regs[] = { { 0x034E, 0x03 }, { 0x034F, 0x0C }, { 0x0350, 0x01 }, - { 0x0202, 0x03 }, - { 0x0203, 0x42 }, { 0x0204, 0x00 }, { 0x0205, 0x00 }, { 0x020E, 0x01 }, -- 2.44.0