Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1114726lqp; Sun, 14 Apr 2024 15:32:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXWfxAYElDpy61xmiKuUG3VX7C1YBG/XuutCgWMqtS5D4EamBt5rrsljkDxeax5C5Auc88QoeZkv6Jmij+OAgzgEFpSAjaonDuwZ+m94A== X-Google-Smtp-Source: AGHT+IF0DqM6ZUVurjDmRkD1RypuFy0g7C/U1Rh883uxfIGTaJKjaeBP+tI2ynamrNU8bjAJBCGH X-Received: by 2002:a50:d714:0:b0:568:9cfe:1974 with SMTP id t20-20020a50d714000000b005689cfe1974mr4764970edi.18.1713133945552; Sun, 14 Apr 2024 15:32:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713133945; cv=pass; d=google.com; s=arc-20160816; b=PjHZnwHdibdQWHFtay4/stN4G8oPkqk6eZDvfdN5MUahXojAtfxFkXyZCgCsyvYxq+ KgHLvF2zBpV1hXvHXDj0JVE5fGL4w6gKqtlyC+IVhsWoOMLv5hUXFW6yxV+Amey5cTyK 7fa4DlUH/Q880kiTsL0JxyiN0EIKcgvdo744ClFjyZkjL8WsAfmtSyComeJQxa5AYGST fLEQFBwwVGmp43h8u15V9I6m8pVxBc3UGe4TIPvEJ6FNys2K0av6Oheih5jORCK/vezk OyIZ3hylWW8ixCXF+uFSAMTNfHsICsSO/y2/gVazL86dZYiB8tm97LjG7m6RwF6fx8U+ 8xag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:dkim-signature :date; bh=KiyLn6RhoZasL+FS6LenVdQAJyHGH6C0x6+1YBj1+g4=; fh=CaM/Na74l5mhhweLXBiUizwuPzBw0gIuw6bEv2sqfRU=; b=JPa4zH/XMmfraj3GLxyi5F7xeR1pmy4H0norujerZM5ygT8V4W1ASI73DxmPrXUQwz +/SnXiGc0l0hHQxBqv5uIzykPTmeQLVcyrD135Ut+EsZxGSSZ/iQltdrgrGkgiW0ZuNT JXuUnJsXX9kQS8xm4Yp3sLau4ecyljACyj04LaClH3VKJnMzsEWetl5b8VBK0jXZeTb7 pbJBNjdT6L757vqTiaNhjHpQyt1HjXzLGYsfk9oh61uAdaKsKq9ldgUO2eqJ8Axcunvb J2lQqfD9swmexfsAwQ2n2SoMB7awcliuOvq55udQ/+jDD1k2XIkSfKJLaJq6h0OS+Xr1 wTmA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=XNHVuFXM; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-144414-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144414-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a15-20020a05640213cf00b0056df3fb89e5si4157647edx.484.2024.04.14.15.32.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 15:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144414-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=XNHVuFXM; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-144414-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144414-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 24DB81F216A7 for ; Sun, 14 Apr 2024 22:32:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 959B8134433; Sun, 14 Apr 2024 22:32:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XNHVuFXM" Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9761DFD9 for ; Sun, 14 Apr 2024 22:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713133934; cv=none; b=nNIPGRnpAMe4abWbyMWkyq+W6TF+uSzloWMd1lt2qx76gm8e7Zl4IOqJ0fSgQnnmxYwq7o2qt5gGyTT7/wfnjB/rLxV0VOs1BwvgD01wsH2UX1+zSsOfujz0ACh2N0N0FfSEXZYihlM6Z3tuDcHJ1amAHJX16YPmysmBytd3CMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713133934; c=relaxed/simple; bh=MnYksIqvb5FtaeoglclkXGEgkSgT6ycUtxodaz3XLgc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=TUS37kKzar7sjQK1zwjljkqXTOqgRE7+8OoE946VkMJUNhHNZqNbjhxEII8BO8ZuWsX3F5JrbgAUZxFj+Av5c3BrkMIWsPFqDpF1jH+5GmZTfCTfGvG6u7QFH1eCRCTRhEBjTipjx27j3SnLLBHnhfB8sgYM4lFOvrJzXtR3C7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XNHVuFXM; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Sun, 14 Apr 2024 18:32:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713133930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=KiyLn6RhoZasL+FS6LenVdQAJyHGH6C0x6+1YBj1+g4=; b=XNHVuFXMPoDHtMGbDkL0Sa/VOnws7xo16dQBrDLMtK2N16jtoP3JqGfFwGbNA2jaX0JTgG MY+YDGPBFK9yY161N9cTqHcLW2p7nU6yI368ey/f75Mqf5J2Lkap8BpLaGZ4x8Jh8rl0vW plRrfGvrrs170Egck8gOa9nXD79w7mU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Johannes Berg Cc: linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: debugfs revoke broken? Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Migadu-Flow: FLOW_OUT I recently started seeing test failures like the following; from the "shutdown complete" line we're well after the point where we called debugfs_remove_recursive() - yet from the backtrace we were still able to call into debugfs. And I see from the history the remove path has been getting tweaked, so... 00091 ========= TEST generic/001 00091 00092 Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) 00092 no label, UUID=73a80295-2b03-4512-aae1-785187926ce3 00092 Adding 2097148k swap on /dev/vde. Priority:-2 extents:1 across:2097148k 00092 configuration error - unknown item 'NONEXISTENT' (notify administrator) 00092 configuration error - unknown item 'PREVENT_NO_AUTH' (notify administrator) 00094 configuration error - unknown item 'NONEXISTENT' (notify administrator) 00094 configuration error - unknown item 'PREVENT_NO_AUTH' (notify administrator) 00094 configuration error - unknown item 'NONEXISTENT' (notify administrator) 00094 configuration error - unknown item 'PREVENT_NO_AUTH' (notify administrator) 00101 building 001... done 00101 bcachefs (vdb): mounting version 1.7: mi_btree_bitmap 00101 bcachefs (vdb): initializing new filesystem 00101 bcachefs (vdb): going read-write 00101 bcachefs (vdb): marking superblocks 00101 bcachefs (vdb): initializing freespace 00101 bcachefs (vdb): done initializing freespace 00101 bcachefs (vdb): reading snapshots table 00101 bcachefs (vdb): reading snapshots done 00101 bcachefs (vdb): done starting filesystem 00102 FSTYP -- bcachefs 00102 PLATFORM -- Linux/aarch64 Debian-1103-bullseye-arm64-base-kvm 6.9.0-rc2-ktest-g2719f811ae24 #18142 SMP Sun Apr 14 16:26:05 NZST 2024 00102 MKFS_OPTIONS -- --encrypted --no_passphrase /dev/vdc 00102 MOUNT_OPTIONS -- /dev/vdc /mnt/scratch 00102 00102 bcachefs (vdc): mounting version 1.7: mi_btree_bitmap 00102 bcachefs (vdc): initializing new filesystem 00102 bcachefs (vdc): going read-write 00102 bcachefs (vdc): marking superblocks 00102 bcachefs (vdc): initializing freespace 00102 bcachefs (vdc): done initializing freespace 00102 bcachefs (vdc): reading snapshots table 00102 bcachefs (vdc): reading snapshots done 00102 bcachefs (vdc): done starting filesystem 00102 bcachefs (vdc): shutting down 00102 bcachefs (vdc): going read-only 00102 bcachefs (vdc): finished waiting for writes to stop 00102 bcachefs (vdc): flushing journal and stopping allocators, journal seq 3 00102 bcachefs (vdc): flushing journal and stopping allocators complete, journal seq 5 00102 bcachefs (vdc): shutdown complete, journal seq 6 00102 bcachefs (vdc): marking filesystem clean 00102 bcachefs (vdc): shutdown complete 00102 bcachefs (vdb): shutting down 00102 bcachefs (vdb): going read-only 00102 bcachefs (vdb): finished waiting for writes to stop 00102 bcachefs (vdb): flushing journal and stopping allocators, journal seq 6 00102 bcachefs (vdb): flushing journal and stopping allocators complete, journal seq 7 00102 bcachefs (vdb): shutdown complete, journal seq 8 00102 bcachefs (vdb): marking filesystem clean 00102 bcachefs (vdb): shutdown complete 00102 Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010 00102 Mem abort info: 00102 ESR = 0x0000000096000004 00102 EC = 0x25: DABT (current EL), IL = 32 bits 00102 SET = 0, FnV = 0 00102 EA = 0, S1PTW = 0 00102 FSC = 0x04: level 0 translation fault 00102 Data abort info: 00102 ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 00102 CM = 0, WnR = 0, TnD = 0, TagAccess = 0 00102 GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 00102 user pgtable: 4k pages, 48-bit VAs, pgdp=000000011585c000 00102 [0000000000000010] pgd=0000000000000000, p4d=0000000000000000 00102 Internal error: Oops: 0000000096000004 [#1] SMP 00102 Modules linked in: 00102 CPU: 7 PID: 1805 Comm: cat Not tainted 6.9.0-rc2-ktest-g2719f811ae24 #18142 00102 Hardware name: linux,dummy-virt (DT) 00102 pstate: 00001005 (nzcv daif -PAN -UAO -TCO -DIT +SSBS BTYPE=--) 00102 pc : bch2_journal_seq_pins_to_text+0x100/0x208 00102 lr : bch2_journal_seq_pins_to_text+0xf0/0x208 00102 sp : ffff0000d6dd3c80 00102 x29: ffff0000d6dd3c80 x28: ffff0000ca361f00 x27: 0000000000000000 00102 x26: 0000000000000000 x25: ffff0000da0002c0 x24: ffff0000da0002f0 00102 x23: ffff0000d50668c0 x22: ffff800080998950 x21: ffff0000da0002c0 00102 x20: ffff0000c46165c0 x19: 0000000000000000 x18: 00000000fffffffe 00102 x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 00102 x14: ffffffffffffffff x13: ffff0000c0ada1df x12: ffff0000c0ada1d9 00102 x11: 0000000000000000 x10: 0000000000000000 x9 : ffff800080400ec8 00102 x8 : 0000000000000000 x7 : 20746e756f63203a x6 : 0000000000000000 00102 x5 : 0000000000000020 x4 : 000000000000000d x3 : ffff0000c0ada1d0 00102 x2 : 0000000000000010 x1 : ffff0000c0ada1d0 x0 : 0000000000000012 00102 Call trace: 00102 bch2_journal_seq_pins_to_text+0x100/0x208 00102 bch2_journal_pins_read+0x48/0xd0 00102 full_proxy_read+0x64/0xb8 00102 vfs_read+0xd0/0x2d0 00102 ksys_read+0x5c/0xe0 00102 __arm64_sys_read+0x20/0x30 00102 invoke_syscall.constprop.0+0x50/0xe0 00102 do_el0_svc+0x44/0xc8 00102 el0_svc+0x18/0x58 00102 el0t_64_sync_handler+0xb8/0xc0 00102 el0t_64_sync+0x14c/0x150 00102 Code: f94002b3 eb15027f 54000180 d503201f (f9400a63) 00102 ---[ end trace 0000000000000000 ]--- 00102 Kernel panic - not syncing: Oops: Fatal exception 00102 SMP: stopping secondary CPUs 00102 Kernel Offset: disabled 00102 CPU features: 0x0,00000003,80000008,4240500b 00102 Memory Limit: none 00102 ---[ end Kernel panic - not syncing: Oops: Fatal exception ]--- 00107 ========= FAILED TIMEOUT generic.001 in 1200s