Received-SPF: pass (google.com: domain of linux-kernel+bounces-144453-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Apr 2024 09:37:04 +0800
From: Huang Rui <ray.huang@amd.com>
To: "Yuan, Perry" <Perry.Yuan@amd.com>
Cc: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Huang, Shimmer" <Shimmer.Huang@amd.com>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
	"Du, Xiaojian" <Xiaojian.Du@amd.com>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 1/8] cpufreq: amd-pstate: Document *_limit_* fields
 in struct amd_cpudata
Message-ID: <ZhyEwE3Hr8Waf620@amd.com>
References: <cover.1711335714.git.perry.yuan@amd.com>
 <6b8432f302165e686a01ffe7d1d98852d5e88609.1711335714.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6b8432f302165e686a01ffe7d1d98852d5e88609.1711335714.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tOVt2nUr663nR6sIScdyzOhmT5hJcYOj2Jttw+Ke7nRHbzuz0qMiGswCTmw+?=
 =?us-ascii?Q?WbPfg10e9OCD7Fn5eDRHgjCLeGVTFzKMcBm3nSz94bA2FqAXuzqePOXjQKmK?=
 =?us-ascii?Q?A9b024pZGjZWaS4QseS00KJGZUq79kYs0RSnJ/tcclRIKssu3dWodSRyKMnA?=
 =?us-ascii?Q?fS/Rgor2mS/0JIyoWiEVNU+NyVu+2psuHwpHVH+LRxQjr54qb0PK06abG2+8?=
 =?us-ascii?Q?9u/VqG14IEa1M9eyK4B66G2Od6oXJPrk7SV7wb9qh5jFX68fJpCxuks3CtMx?=
 =?us-ascii?Q?b8vDQZMJnB4F6AiVMNjTTzkWQwJ6+ciB7ZJeBh0aS3JkxHXipDVO1LK3KPCJ?=
 =?us-ascii?Q?8G/1C/3mtpt2JnrN0lX/4Yp8DtEXC+dxraOpQ7CTFZmJ7OHn+PrLuNPkEiry?=
 =?us-ascii?Q?bAHPU5CCalqEVAngDcfwrH0Njg6BjPA3lyZxG86AWsk53no0nSnfPnVuGKK8?=
 =?us-ascii?Q?wWGUCItpSEvrMVeRYI5JWIg1811AKN3HaC9E6ZvF5XkQ0oqA5zRmegkEtR++?=
 =?us-ascii?Q?d/VsA4kE0ozXg30snUr7we/2mknToBjTQzvBdzo5r2hJbQlVICkCWxBzlfhx?=
 =?us-ascii?Q?X3A0xniFNBzAFla2mHfNbWkLkUE0Jlkqs7za4RM+2jf3uPcK3GMiR6dSArjh?=
 =?us-ascii?Q?5UKriuYWaezAzmWW+QNPGdzV2ISQtXUgs8+OZZhAAtgRjJ4mjZqwj0U5sEzh?=
 =?us-ascii?Q?JadW0VapkY+dhCDST9cBwdUAqKxarIFHL9dIpEZe8tQlUKhdn2PJqXuHBvQa?=
 =?us-ascii?Q?DpccSxDIXBA68zVEADPU+MwPjygb6Mq3NRvROjhxODjhjRefvO14iImyiKbq?=
 =?us-ascii?Q?kPci5j+9m+o12Ngc0XOQC03lvVEDZxJ8BCTwSrpObOUg333riak7ClmxpFyC?=
 =?us-ascii?Q?05gnBMaFiM8L1jShN05cOeie5E5FeJYxalipmkn+ZSDxt3KjnS/MOBEcXOF/?=
 =?us-ascii?Q?M3/FCawKz+RTkOWly2L3gVYHZftVzMpzb6bIoZWTCU0NHH0jpUSqOIMjaB4t?=
 =?us-ascii?Q?ZFKGaETR6+2k+vLM+WQv+RebCvKvVlXAH4bDdWUImSK2mS6o2hxK8M6zRVKE?=
 =?us-ascii?Q?h5hwZFh53Y0UK8azshWD7hBp7muQWpjL7MdOr+DTk+7NQxkNxbmgQOWY2cUH?=
 =?us-ascii?Q?D6rcx/Etm9umfTje9afB9SnqyXOUGM40gOjwnCkJlk4Qxyf9Q9YmBS1BAo4H?=
 =?us-ascii?Q?Vq9WmHjfZ3OeYdm93saSeXwitEhWePRjn06LP0e7PTt4x4aTMviqj/OBVRfM?=
 =?us-ascii?Q?x1fdS1b6KFgQUwylyXWLGKP4g9BcEqOzUhTmlyzZScUqgX9IEq4wpxDESfYY?=
 =?us-ascii?Q?5EAqKlRbP0jipY6wBE931AWBnMpnvpQJzBDfkwiyVMoMn3cBWM1gTgJ1gKdS?=
 =?us-ascii?Q?0v4i70gMZ+uPNotw04E2+ru8Vz5YKdRvfoiq1YECi1Pd5jf4ETfh9KTfDncU?=
 =?us-ascii?Q?BwQQj+mt2C7WBSy7bxMguW7djIacDO8jbJVrEjkUybenxYfC3E0+tCbUkMC3?=
 =?us-ascii?Q?zUbVHQCX2+WiRoJuCWRWor3rlqcC6FFRuILsiqocdvgny0qhXu9TKLmunWd3?=
 =?us-ascii?Q?YS3QFGn/DY5eyYsx/2Xcz1ScnQsaO5hwbIpATfup?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8264d88d-8b79-42e5-1b43-08dc5cec9948
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 01:37:23.6869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JWW4Zy4Lnh7RJl0kTbl4GYUJQT7e4INSPoLOMklKL5piWDmC4WmBxvNIrwNKGDFoHQSQJVVbKEIWtBxtQOKVIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4342

On Mon, Mar 25, 2024 at 11:03:21AM +0800, Yuan, Perry wrote:
> From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
> 
> The four fields of struct cpudata namely min_limit_perf,
> max_limit_perf, min_limit_freq, max_limit_freq introduced in the
> commit febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and
> scaling_max_freq update") are currently undocumented
> 
> Add comments describing these fields
> 
> Fixes: febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and scaling_max_freq update")
> Reviewed-by: Li Meng <li.meng@amd.com>
> Tested-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>  include/linux/amd-pstate.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index d21838835abd..212f377d615b 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -49,6 +49,10 @@ struct amd_aperf_mperf {
>   * @lowest_perf: the absolute lowest performance level of the processor
>   * @prefcore_ranking: the preferred core ranking, the higher value indicates a higher
>   * 		  priority.
> + * @min_limit_perf: Cached value of the perf corresponding to policy->min
> + * @max_limit_perf: Cached value of the perf corresponding to policy->max

I think we should use "performance" instead of "perf" in the comments.

With that fixed, patch is Acked-by: Huang Rui <ray.huang@amd.com>

Thanks,
Ray

> + * @min_limit_freq: Cached value of policy->min
> + * @max_limit_freq: Cached value of policy->max
>   * @max_freq: the frequency that mapped to highest_perf
>   * @min_freq: the frequency that mapped to lowest_perf
>   * @nominal_freq: the frequency that mapped to nominal_perf
> -- 
> 2.34.1
>