Received-SPF: pass (google.com: domain of linux-kernel+bounces-144454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 15 Apr 2024 09:38:58 +0800
From: Huang Rui <ray.huang@amd.com>
To: "Yuan, Perry" <Perry.Yuan@amd.com>
Cc: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Huang, Shimmer" <Shimmer.Huang@amd.com>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
	"Du, Xiaojian" <Xiaojian.Du@amd.com>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 2/8] cpufreq: amd-pstate: Document the units for freq
 variables in amd_cpudata
Message-ID: <ZhyFMiYffSEBcJKi@amd.com>
References: <cover.1711335714.git.perry.yuan@amd.com>
 <87c6aeb265a0281b3abebd07ba2069d80da21944.1711335714.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87c6aeb265a0281b3abebd07ba2069d80da21944.1711335714.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kxWM+Dsb4VoCsHRsjOYgzy0+pcd8ioZVKvSAdI8oyDtFrv8rpeEce269qak+?=
 =?us-ascii?Q?1lCsq74YN9Z4eF+cn2OVsurNF8+TyEP9NdswOm6Wszw+TsVlXx2ePB/6Ws9i?=
 =?us-ascii?Q?KhSOTzT6ebneUQ1djT1BSRpcGNOKV7Gf8pC/DOvWW/yQCOGFzJYD2Vhx6eEX?=
 =?us-ascii?Q?EYW5D+BKuuQmP+/0tlBGB2oAIws0dGNOBDboPv127wXChDFWx3wuIeUUylMv?=
 =?us-ascii?Q?ZYq8xi33Iktz5pYRUJI+lBxEHkJpXVecoycEWqQ4qkxxgTlSPNXRps9g+gQ1?=
 =?us-ascii?Q?kp/gqWTmsqT5JNrM2h9u5PAt5wyNVgA7jPqyk3O4lZnR9b9K4xCSYNJfphlf?=
 =?us-ascii?Q?aLSjzl+8s4/uzCbYK42tw9AGZtXkn3RkmhjvyOWm6knX+ARXBVr2unCCljSC?=
 =?us-ascii?Q?ygLC8vjHfI0aOOBrC49UHmcHRt3ywnZOsZMrEAKEqGyXinfFaBWeKtF3qlYQ?=
 =?us-ascii?Q?L+qVezeyuIds+dQrxbzKEuLiRJpOMZNf2IIWyFZawRzU1ESeR1CPhm5RwMSx?=
 =?us-ascii?Q?ATz478gF6oeE9bPZr3t4mbp11vjg4Z4PwoLZ/MmcbRlwmA3PLL1hjaBrlaO0?=
 =?us-ascii?Q?E6D0d/6NwsOWltAm7WHYEZDLaVvuGcA3aX+wo6wlJtkrdB+lN+qQLadgPPAU?=
 =?us-ascii?Q?LmXdSZQYrE1KcmaAzUGQ5j9wvvt3WoNQIwFX20afz+ZsPvq0pwznLh5pGNfD?=
 =?us-ascii?Q?8nTlfx0n9xGTYMzBxZFQPlGTlqaWG33JzUJDOTaz7ls9RwHlu+J+UBSJ0gW6?=
 =?us-ascii?Q?k2u2nyQfmc9CfSXbP9JcZh9AQX84V2Bcfqq3ViTDSvhymqStftGsNXwiEJzK?=
 =?us-ascii?Q?vDmNMzDjm5v/3o8Md62WXgx9WdWsnbXT6/MdNTWWdKK5Ss9jg3FJC4gEcvdT?=
 =?us-ascii?Q?J1jyIX30vPJG5vzIXamDerXUsJhrSiwN1KZeRTfCKjXr/e6HqJc70hcPlmqo?=
 =?us-ascii?Q?vcvkKYdnxUx0JF0omFl+4302MnNa4eCG/uP42YTk312F4o0nnw/VpBSPui3Q?=
 =?us-ascii?Q?Qzgw7Lp8O2G9A7dbXpqfALY+43EDwGHmo3zCa0tWa6KVNJ5+AogQ+8fJYcIp?=
 =?us-ascii?Q?1wYtbSSeFnuzMU8thYsic94wBamD8Ps7TCosujqxy5ubYszjIBFxfaEkcSpp?=
 =?us-ascii?Q?L+1XBerkgv5wniqk/3pGz+vWwJ7U8OrqYFjAumL9jw5+8tLmmWS/9/pMLy6f?=
 =?us-ascii?Q?KB0ftffcFlPunPLCVfJMOLgojF/fVSrv7fIs19wG9NEDfLqL92TB/n/zocnU?=
 =?us-ascii?Q?+0DOjaurMpgeij0dQyKK+6IqVFdP4oKtfhqBMkT9j2RiAdCmIUFqsSTdleZV?=
 =?us-ascii?Q?vwdpg06rwHrF0+78ondDUQw9IUxU972MjoHfLYTWv/z4OXESOkebWWWNeSs8?=
 =?us-ascii?Q?1G9dRlXwM1fsdRn9JRMB2I+LrNAzGEww7A5zkVWY72riB/OVl+Qrux5/SpHM?=
 =?us-ascii?Q?JJFEkMZpP4lz8Y0zlknrEXQ2ei7f1E68XuwmoiGwNbotwe7qwjF5u6RZ/xUw?=
 =?us-ascii?Q?z5PRK6X2pWnDhCQ7J4/vLDbD45WFU1wVJQFKvX7gQWx/4IduA5twCdsUL52F?=
 =?us-ascii?Q?Xdr2oK/kJN3pcywZbD1rZilio2xTaS+v3Yb8pWjx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 034dbc8b-55da-4630-dc43-08dc5cecde43
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 01:39:19.2369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sNs1lfjdfaGFbJfF+AFRT0bZPcQLKuZJuj3KI5yq0MPoLKtwngkl8ndf13V9lPMPJwbqZFjppQhasvr1T7FSsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6028

On Mon, Mar 25, 2024 at 11:03:22AM +0800, Yuan, Perry wrote:
> From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
> 
> The min_limit_freq, max_limit_freq, min_freq, max_freq, nominal_freq
> and the lowest_nominal_freq members of struct cpudata store the
> frequency value in khz to be consistent with the cpufreq
> core. Update the comment to document this.
> 
> Reviewed-by: Li Meng <li.meng@amd.com>
> Tested-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---

Acked-by: Huang Rui <ray.huang@amd.com>

>  include/linux/amd-pstate.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index 212f377d615b..ab7e82533718 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -51,15 +51,15 @@ struct amd_aperf_mperf {
>   * 		  priority.
>   * @min_limit_perf: Cached value of the perf corresponding to policy->min
>   * @max_limit_perf: Cached value of the perf corresponding to policy->max
> - * @min_limit_freq: Cached value of policy->min
> - * @max_limit_freq: Cached value of policy->max
> - * @max_freq: the frequency that mapped to highest_perf
> - * @min_freq: the frequency that mapped to lowest_perf
> - * @nominal_freq: the frequency that mapped to nominal_perf
> - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf
> + * @min_limit_freq: Cached value of policy->min (in khz)
> + * @max_limit_freq: Cached value of policy->max (in khz)
> + * @max_freq: the frequency (in khz) that mapped to highest_perf
> + * @min_freq: the frequency (in khz) that mapped to lowest_perf
> + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf
> + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf
>   * @cur: Difference of Aperf/Mperf/tsc count between last and current sample
>   * @prev: Last Aperf/Mperf/tsc count value read from register
> - * @freq: current cpu frequency value
> + * @freq: current cpu frequency value (in khz)
>   * @boost_supported: check whether the Processor or SBIOS supports boost mode
>   * @hw_prefcore: check whether HW supports preferred core featue.
>   * 		  Only when hw_prefcore and early prefcore param are true,
> -- 
> 2.34.1
>