Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1172568lqp; Sun, 14 Apr 2024 18:50:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTBUGVtjaeqf4/va0oS5xrtD9IY3J3MweuwGSQClOGybgZb6TYxk8prFzJSbpOEj43dds0Nep3Snmq/RB3URONgwdjU8PedUc42R81IQ== X-Google-Smtp-Source: AGHT+IH84ahD4KQVLGsYvbvKl+vF1iWTA5G9oMpdkwe4YSM0WHZfSItsOHf5TxMw00SZY6X9eDmf X-Received: by 2002:a05:620a:4588:b0:78e:bb82:135d with SMTP id bp8-20020a05620a458800b0078ebb82135dmr18630064qkb.29.1713145806640; Sun, 14 Apr 2024 18:50:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713145806; cv=pass; d=google.com; s=arc-20160816; b=I2OkZudt1d9KQcPGLe/sO1GLoEPA+PvkBcRM3lYQPgmUTxKgwUV68i5uB0Rh4xHt2N 6CNKT1psjAGoC8Z9HoyXC1SMK4m/7pNHsz8k9xmREblyMXrWg7viulqsLbjcpWWG9Lwq S4eXmzAng4XsgSQvwH2DGC6dmbodWkztFIov4ceAfXiWoNuRByxdOhkj8P1Qm5Eg1cyS HBZy7zaBerrgz5YsFUvNO+sW2GFdplOJHlsrrS8QZB5ktDVIt8McL1rogCVlw6rYVIWF I4VClEKD/bqQ4f8sYlTgXGfKAp32KfKIFWF1dRvbqeDc3Jit28OK+svS1fKLtgIXBAm0 I2Zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=licgOxTBwH5HE6JMtIa11fru+0SsRJYTvektX4nhCnQ=; fh=MTKXw8qylc3KxLBC2WsFb3y7S97vKQMlU6wqLeEAJXM=; b=f3q3xDz8Jkxow4odcNtBSMq/hmYLui+8ABULIXj+886F5BU4cb0VAXxGpR8UVJBtIf rk00aU1iVUW6MUPKDSShL6to/pfbRfbKA25HegN5swkBXWVgIQxk5mrNEE3m1ywtGbCU Aay3K3yw8Ivvb17fVHziS67mc3y32g6bSSYCfPQffkDzx5B2yH8fWIVYUAyyiSTyv7ZS aG2wDIX4ASH8QEf3xmMQWxubxXlIGjs8xTX/h+GNA6CR5p51lOEgywezmC8GQWKxZEQ4 LTQkir4uG3fa85LPS4EoCMdz29qalk2N6SC4xoe401CVNxlSyyihesOF22U/ha3QUDhU CWBQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-144458-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144458-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x6-20020ae9e646000000b0078ec3f3d80esi8304416qkl.94.2024.04.14.18.50.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 18:50:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144458-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-144458-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144458-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5F2F61C21742 for ; Mon, 15 Apr 2024 01:50:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CB901FC11; Mon, 15 Apr 2024 01:49:56 +0000 (UTC) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3057639; Mon, 15 Apr 2024 01:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713145796; cv=none; b=oIHEVUFB4Pw1sSUJXVedhoUVPjNaoik4X9mWUMBk7Lta0ee8avvXtCnCLoY2T/jLN+rl5MrWb+4HTlnDWDraexpU8pywbIKqhoptW9RrHXKuxF5+iXPMTSBq8WqvaurIo2ctFNs4PVDc9u+BatFj/QrlhDU+7uirG/5MFIzfhsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713145796; c=relaxed/simple; bh=Mv/80EYxGhF/H8SBXJeJUFeYkvjR2K8Dq5JVqInNFFk=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=c/Z2eIWTGAYiE9iB1YMBmtG7U97uqNA3a/GUJO0lH1BxlNZmwLSzHxcRsP4N/1glkkREiT0oPf2ieRlkYrCYbLvarDL2cCDf+VUrGyRhv5Jxgd7R7/GDFM+b3iKdV+ehAH1xbPjd5/je+ylcXKCYYTTvcA8q+pZxT3BxILaJK94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VHqpM67DLz1GHN2; Mon, 15 Apr 2024 09:48:59 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id 019BF180063; Mon, 15 Apr 2024 09:49:51 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 15 Apr 2024 09:49:50 +0800 From: Ye Bin To: , , , , , , CC: Subject: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable() Date: Mon, 15 Apr 2024 09:50:29 +0800 Message-ID: <20240415015029.3699844-1-yebin10@huawei.com> X-Mailer: git-send-email 2.31.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500010.china.huawei.com (7.192.105.118) If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak. Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler") Signed-off-by: Ye Bin --- drivers/vfio/pci/vfio_pci_intrs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index fb5392b749ff..e80c5d75b541 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -277,8 +277,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev, return -ENOMEM; ctx = vfio_irq_ctx_alloc(vdev, 0); - if (!ctx) + if (!ctx) { + kfree(name); return -ENOMEM; + } ctx->name = name; ctx->trigger = trigger; -- 2.31.1