Received-SPF: pass (google.com: domain of linux-kernel+bounces-144463-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 14 Apr 2024 21:00:31 -0500
From: Bjorn Andersson <andersson@kernel.org>
To: Umang Chheda <quic_uchheda@quicinc.com>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: qcom: qcs6490-rb3gen2: enable PMIC
 Volume and Power buttons
Message-ID: <jlwxlnllpt557eiktovujcrfm2qwd3ynlxpo2v2witkekvocey@indbptcgvitm>
References: <20240403132839.2117675-1-quic_uchheda@quicinc.com>
 <6b3gqfrvljvlfaf365l55kjcbjd4rfmw223tro6rqy5crykxgb@l66dptcrujip>
 <3ca2f601-ce45-43cf-b0dd-e28865874455@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3ca2f601-ce45-43cf-b0dd-e28865874455@quicinc.com>

On Fri, Apr 12, 2024 at 04:18:36PM +0530, Umang Chheda wrote:
> Hi Bjorn,
> 
> On 4/9/2024 8:47 PM, Bjorn Andersson wrote:
> > On Wed, Apr 03, 2024 at 06:58:39PM +0530, Umang Chheda wrote:
> >> The Volume Down & Power buttons are controlled by the PMIC via
> >> the PON hardware, and the Volume Up is connected to a PMIC gpio.
> >>
> >> Enable the necessary hardware and setup the GPIO state for the
> >> Volume Up gpio key.
> >>
> >> Signed-off-by: Umang Chheda <quic_uchheda@quicinc.com>
> >> ---
> > 
> > I suppose this isn't a "resend" either, so please send me a new version
> > of this as well.
> > 
> 
> I had earlier sent [1] for review, on which I hadn't received any review comments.
> 

I see.

If you want reviews on your patches, ask a colleague to invest a few
minutes in the patch and send a Reviewed-by or Tested-by. That both 

Not only will this give you reviews, it will show the community and the
maintainer that there's someone out there who's interested in seeing the
patch merged.

> Hence, I resent this patch again after 2 weeks for review.
> 

Please only resend patches if you strongly believe that necessary
recipients didn't receive the patch.

Regards,
Bjorn