Received-SPF: pass (google.com: domain of linux-kernel+bounces-144470-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Xu Yang <xu.yang_2@nxp.com>
To: frank.li@nxp.com,
	will@kernel.org,
	mark.rutland@arm.com,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	shawnguo@kernel.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	festevam@gmail.com,
	john.g.garry@oracle.com,
	jolsa@kernel.org,
	namhyung@kernel.org,
	irogers@google.com
Cc: mike.leach@linaro.org,
	peterz@infradead.org,
	mingo@redhat.com,
	acme@kernel.org,
	alexander.shishkin@linux.intel.com,
	adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: [PATCH v9 5/8] perf: imx_perf: fix counter start and config sequence
Date: Mon, 15 Apr 2024 10:03:50 +0800
Message-Id: <20240415020353.3833367-5-xu.yang_2@nxp.com>
In-Reply-To: <20240415020353.3833367-1-xu.yang_2@nxp.com>
References: <20240415020353.3833367-1-xu.yang_2@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?DnXQ3rt0ZOQye9Sq2TyC2EnU0yhN4+GkDmdNgU7NVtQIjeg/jwf4rK/ITHCL?=
 =?us-ascii?Q?bKka9IKQmBJCeJ8CQiPe6EjjyFtjn5/LNeNLnELEKKCBZeJjMH6jC8iA5jpD?=
 =?us-ascii?Q?JHJVl2uzt15aY7U8+8BugSny3dObb7ptfwKYjqj8mQIKQMoje5aFnJh8zR/Q?=
 =?us-ascii?Q?WqZVGKPkG3+hpsUrYyd9mrgGUIguoQVr+c/Qu4FeVGgwstwUvgogRn1ER3KM?=
 =?us-ascii?Q?rDgV2BPoNFH/nNW9Ag3KYi0e5o8ssLnDDGG5ugZgNazz9c8b/mLh5cywhBz2?=
 =?us-ascii?Q?BlEZUCpllldwOoJuMH+K4qcskxdPFYsDoxgCz3efdYKmJ4imwgdklLw/FL/g?=
 =?us-ascii?Q?xNYa0Fxz0wPQwkattMzq6IS4HkoAeVZdBKqXWpPwBdG1OiV/yxQzy5lm3AVI?=
 =?us-ascii?Q?aayGkLodyi1H1P2+z8BEUS0+ZkSSeyFoX5XODNAaH4hay6tRzey4q2uUHVOD?=
 =?us-ascii?Q?480ic13HlQS7NLMoInL0RIzFmzXRSPgT/yFJ//NuTbA6OhONqZob+vPkHYdq?=
 =?us-ascii?Q?1eOKxMc5OjS1i5rm4Pf89fpK9kYVl+aNGsOOEKFlMuHb6W0Ak1sbKXe4ZLpr?=
 =?us-ascii?Q?+U4m0HRHiz3Qy5uyCuV/QJtyXaWwsxKy0Hj3RM614JLLZ/vZgG/NnWJPHdGd?=
 =?us-ascii?Q?KcME7lltizpBLfSQZYvncucxRoae04CvEPls5vJoUDfBUrh7jS0jem1mSwK9?=
 =?us-ascii?Q?ayHTP5+XgS/vFsUwvHRgiqYQqfMHzsNGcb0mWuULflWSowaztDQjG1rZQuXa?=
 =?us-ascii?Q?cfHXdS0FKEWp075vn52UErStRxkmIb18t5H+RNLNVmbVjbzOZfzusSPh7C2X?=
 =?us-ascii?Q?sxIfG9imhgcnKJdpMJTM9MiI+GgIPqfJhdzy0TzkPeSMKaMkofvgGzCZigwO?=
 =?us-ascii?Q?cRRxd2tgHUfAY7s8UwMT7OeDCULRkfrKXiynCmZnrxEtz+NpsQvtUheN9KsA?=
 =?us-ascii?Q?CC9sIePQhPR64MNQk1cSLffTkYfSrIQtv0JEn41VR+bGQq/ym+d6YSM6z8ij?=
 =?us-ascii?Q?ySLFEg4i/5AYMwmr1SBtzgWsxEEluLqgEyZV404kd37t7bN3YuMDi7CuqMrS?=
 =?us-ascii?Q?psg8YgHM0CVOwetPQbpcF+Ie9z7Om2ROZ1BQdFdLji1EZAg6F2xqhwZebaNT?=
 =?us-ascii?Q?GoVJsk9Bju60HjvmfSyRjyztYGGqsz35hHQAmmpo918pJXPf6AytiP/bOGER?=
 =?us-ascii?Q?QeVa1tsNyYXDs7wlQLHHfEoo08N14ZgTVdYKRMGzhr+SyZtJyr6cmy8blqwa?=
 =?us-ascii?Q?vmbhmZKPAtItmNOz4BdHA9k+Bwwpu7IxFjIctjk1C0O1s/JncxyCSccvL95H?=
 =?us-ascii?Q?5NaQ959aAplXUe6O1bRmPd23RSMqTiXBOYoWsbyhfBxckdTYbZhUpOqoXJfN?=
 =?us-ascii?Q?tnUQyA3Xoeo8JVqRO6Uz1pIEaMCUaz6YF9xVLTSJzQBRJkT361yE6fNZM5wY?=
 =?us-ascii?Q?GqdfS4hUZKIoslckkLTBM0SVVrPCx7qr1fPB4wSFM4SB/bULwEsPSbKyGvcI?=
 =?us-ascii?Q?3U3zNEK/mieMOAjP5TKeXeZ+Dr8c2VDJaM7bgGBYl96ywH+QCb9Z7I6IOGtT?=
 =?us-ascii?Q?xK4U9SUpWKaVvkqJaj+A+AHREmqcok71PM9DmRGj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5524b646-2fb5-4ba0-362e-08dc5cf04a1f
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 02:03:48.8327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qv2BbXaKwrZABlYPQdvduDxbrI8zD7Rbc2VniR1vyQUnxEng4M+H4zx6sOsdfvxWqzsr97+4T8H8POWgARj4jA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9233

In current driver, the counter will start firstly and then be configured.
This sequence is not correct for AXI filter events since the correct
AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Fixes: 55691f99d417 ("drivers/perf: imx_ddr: Add support for NXP i.MX9 SoC DDRC PMU driver")
cc: <stable@vger.kernel.org>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v5:
 - new patch
Changes in v6:
 - no changes
Changes in v7:
 - no changes
Changes in v8:
 - add fix tag
Changes in v9:
 - add Rb tag
---
 drivers/perf/fsl_imx9_ddr_perf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index 1510502862fe..910fda7eb2c6 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -541,12 +541,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
 	hwc->idx = counter;
 	hwc->state |= PERF_HES_STOPPED;
 
-	if (flags & PERF_EF_START)
-		ddr_perf_event_start(event, flags);
-
 	/* read trans, write trans, read beat */
 	imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2);
 
+	if (flags & PERF_EF_START)
+		ddr_perf_event_start(event, flags);
+
 	return 0;
 }
 
-- 
2.34.1