Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1183215lqp; Sun, 14 Apr 2024 19:29:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXL0cwET2SsTJMvt0CFuUjtBks33Eo3nadGDqLqmg25PeP+8EZHFd8KlR/lz1KO7+sAXMfgwZTN96UMkvplUunxOHNwyVmpgQJk3FKK7Q== X-Google-Smtp-Source: AGHT+IFeYY/ZSgCSSW5pnAEU/lKKFq73AuUVV04BYjrMNRwLilNFgPtxIv/FbbkEHWOeE7BxRuO/ X-Received: by 2002:a17:902:b288:b0:1e4:9ad5:7522 with SMTP id u8-20020a170902b28800b001e49ad57522mr6582607plr.21.1713148173213; Sun, 14 Apr 2024 19:29:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713148173; cv=pass; d=google.com; s=arc-20160816; b=Dt5pUoKESugdbKaDKoCOh+8EsU8qvs6lYC01I9f+25hxs/6628DQGEyeMQiSLdvMGG t4/5OysqOzgHUizcNG+1yskS04a0BNZGWyQSTImHHkBx7s/M9R40BGsjYkfiGGeGee5l vKbHUq51849chge0G/4MciZngyxWXDuCOPDemnVUu3pVha3chFH/AhGruwBNUcC/tswN y+LUiM0eyC7FJMnzL3eXtK808fEbh7wZOsTW+MIYDDlICapqsfm5qD6SWnyC8vPGYodC FOsOXmLAorMvVihB/XI+4aq4ef/hZ5BRQ2jxD56oewWK5GIoZhnBUFp9AhIjViHWEw3d oYJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=cpKZ7q8sCVw7GHHagvD0frFCb4Rjbet4khG0tSwvEX4=; fh=EUxW/UhI+JcTY0MVKdLRVAvsYn/m13GuGhc3lqBGVIg=; b=Cvk8GuQYuxCg8GYErx6e1yYxx6MPwep8GnnNPAG93D14c3C4r+yBVcAwyAH6NcaLVo QUhBhYW7Gq88sQcjc0f60TpNaQqweSAhGR92Cuo0lonrJLKLk2IQPdDmcUD/btDlPpig 2c1DV4FKLpuI+nQ9nFG2676qb7W5nKdYyNaBIO2ttk7Y2CbbnjtO4gmACWBk5N/VN1sv LcOI0BhnbiMU1Ruy3CZWjWlaV8chi3ULJgF5rhEuAo2b58dhOK27g135eoErnPUs6lHi QPanr+csk4B9lzBQgi9+Oolaeud41y+HaGDliTAMqMQg/PLIa+G8dshOK/1arhUp91rZ /13Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c7lZRSEd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-144486-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144486-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i14-20020a17090332ce00b001e2b723f5a0si7378975plr.258.2024.04.14.19.29.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 19:29:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-144486-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c7lZRSEd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-144486-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-144486-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 17AE8B21904 for ; Mon, 15 Apr 2024 02:26:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D955917736; Mon, 15 Apr 2024 02:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c7lZRSEd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0483A848D; Mon, 15 Apr 2024 02:26:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713147976; cv=none; b=egIieX4GoC6/Ajct+1IsmxZVpda3pOvzCsrUq60UuLeOd7W54n0i7qyZFKEEVqCqBA7qqn+XQhIpn+zxMGf4tgBDl+SEFZ4ihucuAMcsxhkwW+qIzF3f0cuE+jxu68Ui6FceiYEeSKoXo6Ulmo3PG8lXv86oM9qZW+VeHQEzGuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713147976; c=relaxed/simple; bh=d+sWxRJcFYWDfl1g1hpky8Wk0cZLGATyDM6LOemMcEs=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=b7wJjcHLsgH+JZQ7/O26lf/aQsuY++iDJsnOieKghcwxZxZpvlEReElssWbClwvjZg9uJT9AAJ3D9gMtLGRo10t8Aw4GQw4Nv13fkex9XrIGeS+eOYKizidl1GOWi0WaBA+j0exkhIS8sxOkH5S+EWlCEGYaLk2yO6BAJ+RQNYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c7lZRSEd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8306C072AA; Mon, 15 Apr 2024 02:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713147975; bh=d+sWxRJcFYWDfl1g1hpky8Wk0cZLGATyDM6LOemMcEs=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=c7lZRSEdzsr9Nn7/FXaeq0JgYid1V+ueNmv08TM4w20O7u2isRkZaFyTN0gTv1gcB fqyHyfU+Syw8NJXZaye4+LLW6qH9bOu1knw/wzrFgBsFI+l6RdK1I7bPTDDDZILTsU NzQtbQDWnGgVSY96N9+CtIxVzw1JQRh2K1rPP+TkgRNEKohtaDRDZsegsptcIrSURD ZFUkqCUOXuv+ot8BgXOsraZFEoF5sZOox0htdfFumc+5wgfsJuQys10/rPg86RcrMP U31q/+ivTZ02F/DhCUhUcTm9tlU6pNKt6ydIAwGSoLhR9jhEw3C5q4ghIaf6YD+/OT 4tr3KWl6/r76Q== From: Mark Brown To: Richard Fitzgerald , Dan Carpenter Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <450dd21a-b24b-48ba-9aa4-c02e4617852f@moroto.mountain> References: <450dd21a-b24b-48ba-9aa4-c02e4617852f@moroto.mountain> Subject: Re: [PATCH v3] ASoC: soc-card: soc-card-test: Fix some error handling in init() Message-Id: <171314797306.1649319.17265441558891168082.b4-ty@kernel.org> Date: Mon, 15 Apr 2024 11:26:13 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14-dev On Fri, 12 Apr 2024 15:07:01 +0300, Dan Carpenter wrote: > There are two issues here: > 1) The get_device() needs a matching put_device() on error paths. > 2) The "if (!ret)" was supposed to be "if (ret)". > > I re-arranged the code a bit to do the allocation before the > get_device(). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: soc-card: soc-card-test: Fix some error handling in init() commit: a8cad4a4e431e250edc05242a8ca1be6e4b33749 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark