Received-SPF: pass (google.com: domain of linux-kernel+bounces-144489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1b9fcded-3048-4fa9-b388-34543a44b025@linux.ibm.com>
Date: Mon, 15 Apr 2024 08:01:04 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf sched: Rename switches to count and add usage
 description, options for latency
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        namhyung@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        irogers@google.com, adrian.hunter@intel.com, acme@redhat.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240328090005.8321-1-vineethr@linux.ibm.com>
Content-Language: en-US
Cc: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Reply-To: 20240328090005.8321-1-vineethr@linux.ibm.com
From: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
In-Reply-To: <20240328090005.8321-1-vineethr@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 28/03/24 14:30, Madadi Vineeth Reddy wrote:
> Rename 'Switches' to 'Count' and document metrics shown for perf
> sched latency output. Also add options possible with perf sched
> latency.
> 
> Initially, after seeing the output of 'perf sched latency', the term
> 'Switches' seemed like it's the number of context switches-in for a
> particular task, but upon going through the code, it was observed that
> it's actually keeping track of number of times a delay was calculated so
> that it is used in calculation of the average delay.
> 
> Actually, the switches here is a subset of number of context switches-in
> because there are some cases where the count is not incremented in
> switch-in handler 'add_sched_in_event'. For example when a task is
> switched-in while it's state is not ready to run(!= THREAD_WAIT_CPU).
> 
> commit d9340c1db3f5 ("perf sched: Display time in milliseconds, reorganize
> output") changed it from the original count to switches.
> 
> So, renamed switches to count to make things a bit more clearer and
> added the metrics description of latency in the document.
> 
> Signed-off-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
> ---

Hi Arnaldo,
Any comments on this patch?

Thanks and Regards
Madadi Vineeth Reddy