Received-SPF: pass (google.com: domain of linux-kernel+bounces-144490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <81fa2939-37b8-479b-a03b-1f2ea17b2131@nuvoton.com>
Date: Mon, 15 Apr 2024 10:32:29 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC
Content-Language: en-US
To: Rob Herring <robh@kernel.org>
Cc: broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org,
 devicetree@vger.kernel.org, linux-sound@vger.kernel.org,
 krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
 conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com, YHCHuang@nuvoton.com,
 KCHSU0@nuvoton.com, CTLIN0@nuvoton.com, SJLIN0@nuvoton.com,
 scott6986@gmail.com, supercraig0719@gmail.com, dardar923@gmail.com,
 edson.drosdeck@gmail.com, u.kleine-koenig@pengutronix.de
References: <20240412103554.3487290-1-wtli@nuvoton.com>
 <20240412155220.GA2918590-robh@kernel.org>
From: WTLI <wtli@nuvoton.com>
In-Reply-To: <20240412155220.GA2918590-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RS9HakFOYTAvOVVvZXJObVd5OG1CTE5kdGpVdVFCM0lzbU9QK3FqMkd2Zng3?=
 =?utf-8?B?ODJENXNHUWFjVjRodEc1WFhNa2FWZWUzWkpPbis5Slg0ZjVaUzdvSW5BamxF?=
 =?utf-8?B?ZWpSeUl2VHE2YkN5N0Y5SGFEbTErMWRmTWd5TjhjUGRyZmc5NE9DM0J1SzIr?=
 =?utf-8?B?aTk1cmxtTTh4TTVDejlXLzFJL2VaZHFGMlNaQlY4L1Y0L0VxTnFaTTVCbkFn?=
 =?utf-8?B?OWhGN0pzL3Y3eHQ1dFFQMkdkQysvY3g4NjdzeXBmc1JQVWpGYml6S0Z1K05r?=
 =?utf-8?B?RDB2QkVSYjhFS0NzNzhKVnJRMHlYYml1a3pwRzM5a0hxRU45SnU4STJvR0lV?=
 =?utf-8?B?MVBkMlhxUWF1YkVBK3RUYTFVbTE5Ulg5TThuWmRycWVnRDEzWTR4KzZDQStL?=
 =?utf-8?B?VHg5bCtleDBUS0lXanpYNVdRTFBwN1dhRlJPN1J2MmhqcDhwcGxJd3pTNkNt?=
 =?utf-8?B?eldvN2pxY2NYb2NVN1htRFdWRGFVaFpqeFFFZmZ2ZXNTQkQzT2pvS1d0RUk4?=
 =?utf-8?B?NnhoVTZGSXozWWFTdVVncnE3dDBrUGkyRmtzSkNlTmYxN3pZVW5maGNrUmZK?=
 =?utf-8?B?SXg3ZnlvTHRqeGRXTkk5NmJ1dXFNV1M2THh4ZkNWMlgzbVBFVnpDc1A2eFBY?=
 =?utf-8?B?QzlsK0ZnZXIzbmJ0NEFVeU9zUk83TUZ1NUc0YmpkZ1dXYmswYnFmSU1wazZP?=
 =?utf-8?B?NEg4dE5GMEtSSWJGOXVzcVR5YW51bGIzZ090NjB5NFhWUlNKSlZUR0VnYW4x?=
 =?utf-8?B?SmZRUFl4dmJsTTFTZEl4QjFQUGQ3U25wK3VwUklBNHVzRk4xanhaWXNKWnNK?=
 =?utf-8?B?T3lOYlh1d0xYd0tYRTFRSldBTjhOS0NZc0cvcW5IcVBpclNEMExuU0lJUlZU?=
 =?utf-8?B?Q2dIV05lSUk3ZEhxdDd6S2FMMHcvcUcyMytCd3ArMTFwdTllVmlqeUZFT0lp?=
 =?utf-8?B?N2V6Y2tpcmkyZ1QxWnlMYUowVTJ6T1d2N2c1TFpad2IvTDNOUVhWK2FFQTdm?=
 =?utf-8?B?a1E4RTc4R1NHYXh1Z2hXRXVzakVzb0JiQy96YXp3Q0IvRHY3eGIxdjBZM0g4?=
 =?utf-8?B?b1Q1VkRiVEwyRWp2d1NKamMxK3NrK0hOc3lvd1FNdk5CRnNEMlJlTkZ4eFdl?=
 =?utf-8?B?OU1NSHJpUDZBd0hwQmNnTzl6VzEvUzRGTnQ1VitzNnQxRndJaUxvcGF4M2xC?=
 =?utf-8?B?dENFOXBocVpFL2hMaUV0V2JQMDZxN0pJQnpyTlltaTUrNlZtdWpIUmwrSlBP?=
 =?utf-8?B?SEU5dU1heWY1b2hmTHE2WHBPMUtZY2xkdFRESEZnb0JIdmhpUkdxcU91OEFz?=
 =?utf-8?B?SHhRaVRCQytGN0lFNUpGWmtZbVNaWmZRK3lpdm94MUhoekFvYVg1NVJKeW8z?=
 =?utf-8?B?ckpnK3Z3WkxqdkpaeWYybTZvYlZMbVY1Y1NHQzlvTjFqcVd2M25YMGcxc2xy?=
 =?utf-8?B?bnRGZy9OQlFaa0pJd0RscXM4MFYyM3ZoSlBDckdqNTBVYUpCcXFVRi9YTmhn?=
 =?utf-8?B?LzdrcERhMDZmRzhLYk5MOVdpVXV1VHJwOVZrL2xVUDJtZDJ3VXRVS3NOd3RU?=
 =?utf-8?B?bzJDYlJsVy9BdFpqbWJod0xEdXB4N01XT2o4N0FPT1RWdTZXaytwdTI1Yzdx?=
 =?utf-8?B?WDN1MmZvN3RKbXVsSUc1cVZRR28xRm00cnFkUytleW5uRFkxZGdZWkM2VVRX?=
 =?utf-8?B?Mi8ybmNpU3Q3WXgyV0Y3WElWVG5UMlptdUtsYmNaNXR0UU5DK1F1cDZYOTE4?=
 =?utf-8?B?VG5zU2FROWZjQ09GczJ0Yk1iR21Sd2NMT09OYzdGdW1CNnlPbmtDdVVzK1Y2?=
 =?utf-8?B?NHZ1U054bitqMEJBazI1SVBsNytHUzQxVE1DSEl0eXUwOThJWFBlTkkrb2JI?=
 =?utf-8?B?RnNSYzVEQUNMRUlnVWVLYXJnUUdMZVZocGlBVUVzQ010OUhZVVlqcUlhQ2tN?=
 =?utf-8?B?aG1FNTAweW9vVkZDL2hyQjRheWFPQXg2VE9nWGF5dDMxYnR2ZWxZRmxoK0ph?=
 =?utf-8?B?WFU2eTNNQ1lKb2JaeThncU1HSjdjTGM4WUZKRGhtKzVqNzlFSmI2U1RsS3FI?=
 =?utf-8?B?OXBTRks2TXRWekhsdS9iVUlaVjBndi9BTFNSUHdjU1Y2a3M1bDR3dXQvd0FP?=
 =?utf-8?Q?lHBxvzNGd5UwhF1vHNkeXWijl?=
X-OriginatorOrg: nuvoton.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 651c4010-c32d-425a-b512-08dc5cf44f33
X-MS-Exchange-CrossTenant-AuthSource: SI6PR03MB8987.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 02:32:35.1836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a3f24931-d403-4b4a-94f1-7d83ac638e07
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6xRGQENI2rio76ZXlpZajdhEFPWHDPwubgZHk/Lj0vjfLzj/Cm+rBZ+CmtLZOQjVFMG9ANxT2R4bhgLwvofSIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB8295


Rob Herring =E6=96=BC 4/12/2024 11:52 PM =E5=AF=AB=E9=81=93:
> CAUTION - External Email: Do not click links or open attachments unless y=
ou acknowledge the sender and content.
>
>
> On Fri, Apr 12, 2024 at 06:35:52PM +0800, Seven Lee wrote:
>> Change the original fixed delay to the assignment from the property. It
>> will make it more flexible to different platforms to avoid pop noise at
>> the beginning of recording.
>>
>> Signed-off-by: Seven Lee <wtli@nuvoton.com>
>> ---
>>   .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yam=
l b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> index 054b53954ac3..a726c5a9b067 100644
>> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> @@ -103,6 +103,13 @@ properties:
>>           just limited to the left adc for design demand.
>>       type: boolean
>>
>> +  nuvoton,adc-delay-ms:
>> +    description: Delay (in ms) to make input path stable and avoid pop =
noise.
>> +        The default value is 125 and range between 125 to 500 ms.
> No need to state constraints in prose.

okay, I will fix it.

>
>> +    minimum: 125
>> +    maximum: 500
>> +    default: 125
>> +
>>     '#sound-dai-cells':
>>       const: 0
>>
>> @@ -136,6 +143,7 @@ examples:
>>               nuvoton,jack-eject-debounce =3D <0>;
>>               nuvoton,dmic-clk-threshold =3D <3072000>;
>>               nuvoton,dmic-slew-rate =3D <0>;
>> +            nuvoton,nuvoton,adc-delay-ms =3D <125>;
>>               #sound-dai-cells =3D <0>;
>>           };
>>       };
>> --
>> 2.25.1
>>
________________________________
________________________________
 The privileged confidential information contained in this email is intende=
d for use only by the addressees as indicated by the original sender of thi=
s email. If you are not the addressee indicated in this email or are not re=
sponsible for delivery of the email to such a person, please kindly reply t=
o the sender indicating this fact and delete all copies of it from your com=
puter and network server immediately. Your cooperation is highly appreciate=
d. It is advised that any unauthorized use of confidential information of N=
uvoton is strictly prohibited; and any information in this email irrelevant=
 to the official business of Nuvoton shall be deemed as neither given nor e=
ndorsed by Nuvoton.