Received-SPF: pass (google.com: domain of linux-kernel+bounces-144500-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <66546f2a-1fab-4115-8ff5-27e8aec276f1@huawei.com>
Date: Mon, 15 Apr 2024 10:55:23 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bcachefs: remove unneeded semicolon
Content-Language: en-US
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	<kent.overstreet@linux.dev>
CC: <bfoster@redhat.com>, <linux-bcachefs@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Abaci Robot <abaci@linux.alibaba.com>
References: <20240415023557.5851-1-jiapeng.chong@linux.alibaba.com>
From: Hongbo Li <lihongbo22@huawei.com>
In-Reply-To: <20240415023557.5851-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

I remember other people also submit this likely patch:

https://lore.kernel.org/linux-bcachefs/20240103010720.39784-1-yang.lee@linux.alibaba.com/

https://lore.kernel.org/linux-bcachefs/20240103095942.3982021-1-lihongbo22@huawei.com/

On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   fs/bcachefs/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>   
>   		prt_bdevname(&buf, fs->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
>   		prt_newline(&buf);
>   
>   		prt_bdevname(&buf, sb->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
>   		prt_newline(&buf);
>   
>   		if (!opts->no_splitbrain_check)