Received-SPF: pass (google.com: domain of linux-kernel+bounces-144525-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <a10be737-2f2f-4132-9793-3a6a6adf90ea@intel.com>
Date: Mon, 15 Apr 2024 09:46:13 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/xe/irq: remove unneeded semicolon
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	<lucas.demarchi@intel.com>
CC: <ogabbay@kernel.org>, <thomas.hellstrom@linux.intel.com>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
	<intel-xe@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>, Abaci Robot <abaci@linux.alibaba.com>
References: <20240415032733.39584-1-jiapeng.chong@linux.alibaba.com>
Content-Language: en-US
From: "Chauhan, Shekhar" <shekhar.chauhan@intel.com>
In-Reply-To: <20240415032733.39584-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGxpWWFwUmVocFNyYkl5d0d4c0VDYUQvNkVMSnJlVWh0bGdhMlJUUXU0a3Yw?=
 =?utf-8?B?RGdZc21kaDI2SlRqZ3dXcTVQaFc4bm9BZ2UzWUhBd2dlczdBVEtHYVJzbDl3?=
 =?utf-8?B?d1JwU1N4b2JhMXNwQkhrbEMwUGNWY3AvMkhmSW5tNzdFOElRaFJ5TzNJbTRy?=
 =?utf-8?B?STVwS1BIenlPSHlGS2xwZnJIaHdkZ2FITER1c1J4V2d1NFNpRWdSZ3BNMmha?=
 =?utf-8?B?Q2lXSGd0cCtZcDVZRlducW9FQXVKTkJOMEJ0US9Sek9hdXB5VCtHaGZleEFF?=
 =?utf-8?B?RlhuZWtVUGRvRGR1eWI5TUx1aW5mRDg1aTdKaWlZdG02OGkrNVNqT0g3WGhV?=
 =?utf-8?B?ajljOWVRcU5UQlBVZ0U0bG5qd0wwNlk4MkwxTkVOT3JlanVHQzVESEd1MEZa?=
 =?utf-8?B?WFBhRGpGeG10dGpmUkttT21jU0hWdUNxVURBTWQyWktkbjBSWGtadW12NTRG?=
 =?utf-8?B?SnhpOGNKaDFQa05qeE9yM25qWXB3N1ZVUENlODJZY0NFeDhHMGhJRC9kNlUv?=
 =?utf-8?B?eTF5TDlyeHZrNlRGUzFSdFpWemIyUjVRUm5pb2RlTDV3eXpHZmtIWlFkOE93?=
 =?utf-8?B?c2FQMEV4aWhod1dyTG84TmRSejJaWXRCb3gySTB4NTF5UEtoRDJVeUMwbjJE?=
 =?utf-8?B?Z2EvajVHZnptRWp5N0VaQkR6YUt4ZC9NVkFEeVkxdERNY0ZHRk1zaDd1TWdG?=
 =?utf-8?B?OUxJRW5YdU0rNGlaNGhTeEd3QlNLVFU2MVp3S2dwaUo0cHhoOS90MWRxNE1j?=
 =?utf-8?B?SFVKdWtsQUhQRURNUm5CQ0JLWFQ5R0xBSjcxbysrNlliOG1kYlB0Qklyc3Z2?=
 =?utf-8?B?ZmRGai9hcXJ1Qi9yZlgvTWJ3SFE1QjJ6MHFhemRMalR0Q1Z1cWlSNmZsRThN?=
 =?utf-8?B?WSt5U3JvTWRoWEFXSnV1SnowTEJza0xLUjltaUNiQ1loY2pSQWZZbTArNGxY?=
 =?utf-8?B?OWJkQ05neVppamtJUWRuSlc2d2F3dEMvZFA1SE93elVrdGN1UngzbjFYMmJI?=
 =?utf-8?B?b1UrOVdoUlcxYkYvUUdGWWFDSm5wT09lS2VUUmpoL3NuYVE1enFQaE1hL2lh?=
 =?utf-8?B?SW9VUXBKRjNaZ2ttQ3VMcUhIS2pzUUNJSmhhNTFwQzYvYjM0UzFDUGxkTU1y?=
 =?utf-8?B?SmlvRk5GWlhFM0RqSjI2cnZmaTZIWUszdFVrbmFOWEZ4MVRxU0VoZ3FnNnYr?=
 =?utf-8?B?MExEUnVYUGExcEVmemtRNmFYOENCN0I0b2tCckd2VnpHNzlCcExVaE1ZS1RI?=
 =?utf-8?B?RUN5MmdieTZEWjZPWlNWS244bWdjZ1JWNzB0MEFtV2VyNGFVRlFRMUxZVFVa?=
 =?utf-8?B?ZTFCRk1mOTZOa2xGY3lGVFNTVXZqWXE1L3l1TEFtK2c2VElKci9HbkNUWWJv?=
 =?utf-8?B?RWM4cXJNWkNYTGpWRjdPa3FWcll3SlhEVkU4TkFPY0o3ZzFLZWJXWExWYmlu?=
 =?utf-8?B?cHRUVDZzR2FYazdVUkNzcVMwRVYya3Azd1FEd1dRZHBQSGtSUllzT1lMckpV?=
 =?utf-8?B?ZldKVjY5eDlxNHBkOTh2WjNrZGovQnNHa1hQemFnOVU2TnpVT3dIZWt2b2M4?=
 =?utf-8?B?NGR2WUFpMldoYVZ0TmlUdFZLcWtBVUQveVQ4M0doUXgwdjArYnBmZXV3WVdh?=
 =?utf-8?B?T043cVRVTjlIMWYzWGI5bEllaUdUZlBpb3RoV0FnSkVRYThqV2tsNmI0UmRT?=
 =?utf-8?B?K25rQVQ4MTg2dUdCKzdhYi95V0lCL25BY2NUQ25Hd1JJMTBwakQ1MHZwYndO?=
 =?utf-8?B?cHhPL1VMS2M4UTVqZjZJMjhDZG1oTW83ZDhjWXl1UTdFWXRqYVlSKzlsV0I1?=
 =?utf-8?B?dzBUaHQ2SC9sYytNMnBNVmRsN2RHbVRsazdXVjRDR284VmhFMm9rYUFuZkFE?=
 =?utf-8?B?T0ZLRmVhMUF0a0JJSEN0VkdSd29LZkRTNnFFRmloY1hzTVAvQ1ZPTFJKY3RK?=
 =?utf-8?B?UVpDd2xZRStLbUUxdm5rS0NTV0VJMzhpQmdCbDkyZnVDOUxaWisvall3Mzlk?=
 =?utf-8?B?dGg5TFQ1c2NFUFBiZ1MrL3BZNWpuYlpBUWdSR04xN3FyaXI4UitETndPWjdi?=
 =?utf-8?B?Nm5aTGFxcDhHc2hJZ0dyY2RWcHdpcHVVdkpBMVdKUXdDaG9uM1FoTnh4anhZ?=
 =?utf-8?B?L0JYcllWcEpXS1dTaXdMRXRtNExTa1lobllQWlVpcG9sRUdsSXdLWVUwVHU4?=
 =?utf-8?B?RlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d1b17a4-d309-4e44-ad71-08dc5d02ce87
X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8607.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 04:16:22.0068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x6K5MOhCzPqIhYm563ndECfxaknVC9kQPNv/NzMwcPIg/rYks793ha+Gnc1QwsWfRsofXQ5dfGMJj7vFCRoLbagEovLnjv3kkOfreLvhPFI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6936
X-OriginatorOrg: intel.com


On 4/15/2024 08:57, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon.

Specifying a specific line number in a commit message might not be the 
most resilient approach as it could become outdated.

Maybe rewrite it as:
"Remove unnecessary semicolon in pick_engine_gt()"

With that,
Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/gpu/drm/xe/xe_irq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 996806353171..5b1a2f46a1b2 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
>   			return tile->media_gt;
>   		default:
>   			break;
> -		};
> +		}
>   		fallthrough;
>   	default:
>   		return tile->primary_gt;

-- 
-shekhar